MantisBT - Piwigo
View Issue Details
0003126Piwigoalbumspublic2014.08.24 22:522014.10.09 21:37
flop25 
flop25 
normalfeaturehave not tried
closedfixed 
 
2.7.0RC22.7.1 
any
Apache 1.3.x
0003126: can apply Is Commentable on sub albums
from the edition page of an album, set sub albums as commentable on demand
No tags attached.
Issue History
2014.08.24 22:52flop25New Issue
2014.08.24 22:52flop25Statusnew => assigned
2014.08.24 22:52flop25Assigned To => flop25
2014.08.24 22:52flop25browser => any
2014.08.24 22:52flop25Web server => Apache 1.3.x
2014.08.24 22:56svnCheckin
2014.08.24 22:56svnNote Added: 0007595
2014.08.24 23:04flop25Statusassigned => closed
2014.08.24 23:04flop25Resolutionopen => fixed
2014.08.24 23:04flop25Fixed in Version => 2.7.0RC2
2014.10.01 06:50rvelicesNote Added: 0007651
2014.10.01 06:50rvelicesStatusclosed => feedback
2014.10.01 06:50rvelicesResolutionfixed => reopened
2014.10.01 19:59svnCheckin
2014.10.01 19:59svnNote Added: 0007654
2014.10.01 20:06svnCheckin
2014.10.01 20:06svnNote Added: 0007655
2014.10.01 21:02flop25Statusfeedback => closed
2014.10.01 21:02flop25Resolutionreopened => fixed
2014.10.01 21:02flop25Fixed in Version2.7.0RC2 => 2.7.1
2014.10.03 19:32rvelicesNote Added: 0007660
2014.10.03 19:32rvelicesStatusclosed => feedback
2014.10.03 19:32rvelicesResolutionfixed => reopened
2014.10.03 21:20flop25Note Added: 0007662
2014.10.09 21:34svnCheckin
2014.10.09 21:34svnNote Added: 0007673
2014.10.09 21:35svnCheckin
2014.10.09 21:35svnNote Added: 0007674
2014.10.09 21:37flop25Statusfeedback => closed
2014.10.09 21:37flop25Resolutionreopened => fixed

Notes
(0007595)
svn   
2014.08.24 22:56   
[Subversion] r29265 by flop25 on trunk

-----[Subversion commit log]----------------------------------------------------
feature:3126
Apply on subalbum checkbox about comments
(0007651)
rvelices   
2014.10.01 06:50   
I get a warning
PHP Notice: Undefined index: apply_commentable_on_sub
(0007654)
svn   
2014.10.01 19:59   
[Subversion] r29857 by flop25 on trunk

-----[Subversion commit log]----------------------------------------------------
feature:3126 no more notice should be displayed
thx to rvelices for the report!
(0007655)
svn   
2014.10.01 20:06   
[Subversion] r29858 by flop25 on branch 2.7

-----[Subversion commit log]----------------------------------------------------
Merged revision(s) 29857 from trunk/admin:
feature:3126 no more notice should be displayed
thx to rvelices for the report!

(0007660)
rvelices   
2014.10.03 19:32   
I think the issue is still there because the if expression is evaluated left to right so the first part will produce the warning anyway (I did not test but I believe so).

Did you test your change ?

I think just
if (isset($_POST['apply_commentable_on_sub']))

is enough.
(0007662)
flop25   
2014.10.03 21:20   
Sry! I couldn't reproduce; error_reporting issues for sure on my config
indeed just an isset should be enough Will check then commit soon Thx again
(0007673)
svn   
2014.10.09 21:34   
[Subversion] r29949 by flop25 on trunk

-----[Subversion commit log]----------------------------------------------------
bug:3126
just an isset
(0007674)
svn   
2014.10.09 21:35   
[Subversion] r29950 by flop25 on branch 2.7

-----[Subversion commit log]----------------------------------------------------
Merged revision(s) 29949 from trunk:
bug:3126
just an isset