|
Notes |
|
|
(0007595)
|
|
svn
|
|
2014.08.24 22:56
|
|
[Subversion] r29265 by flop25 on trunk
-----[Subversion commit log]----------------------------------------------------
feature:3126
Apply on subalbum checkbox about comments |
|
|
|
|
I get a warning
PHP Notice: Undefined index: apply_commentable_on_sub |
|
|
|
(0007654)
|
|
svn
|
|
2014.10.01 19:59
|
|
[Subversion] r29857 by flop25 on trunk
-----[Subversion commit log]----------------------------------------------------
feature:3126 no more notice should be displayed
thx to rvelices for the report!
|
|
|
|
(0007655)
|
|
svn
|
|
2014.10.01 20:06
|
|
[Subversion] r29858 by flop25 on branch 2.7
-----[Subversion commit log]----------------------------------------------------
Merged revision(s) 29857 from trunk/admin:
feature:3126 no more notice should be displayed
thx to rvelices for the report!
|
|
|
|
|
I think the issue is still there because the if expression is evaluated left to right so the first part will produce the warning anyway (I did not test but I believe so).
Did you test your change ?
I think just
if (isset($_POST['apply_commentable_on_sub']))
is enough. |
|
|
|
(0007662)
|
|
flop25
|
|
2014.10.03 21:20
|
|
Sry! I couldn't reproduce; error_reporting issues for sure on my config
indeed just an isset should be enough Will check then commit soon Thx again |
|
|
|
(0007673)
|
|
svn
|
|
2014.10.09 21:34
|
|
[Subversion] r29949 by flop25 on trunk
-----[Subversion commit log]----------------------------------------------------
bug:3126
just an isset |
|
|
|
(0007674)
|
|
svn
|
|
2014.10.09 21:35
|
|
[Subversion] r29950 by flop25 on branch 2.7
-----[Subversion commit log]----------------------------------------------------
Merged revision(s) 29949 from trunk:
bug:3126
just an isset
|
|