Piwigo Bugtracker
Main | My View | View Issues | Change Log | Roadmap | Docs
  

Viewing Issue Advanced Details [ Jump to Notes ] [ Issue History ] [ Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0002515 [Piwigo] template minor always 2011.11.18 15:43 2012.01.02 23:22
Reporter plg View Status public  
Assigned To rvelices
Priority normal Resolution fixed Platform
Status closed   OS
Projection none   OS Version
ETA none Fixed in Version 2.4.0beta1 Product Version 2.3.1
  Target Version 2.4.0beta1 Product Build
Summary 0002515: a few icons are not in CSS sprite
Description The CSS sprite has been successfuly adopted for the majority of icons and in all themes. A few icons are not used in the CSS sprite yet :

* delete.png (comment_list.tpl)
* edit.png (comment_list.tpl)
* validate_s.png (comment_list.tpl)
* recent.png (thumbnails.tpl, mainpage_categories.tpl, menubar_categories.tpl)
* recent_by_child.png (mainpage_categories.tpl, menubar_categories.tpl)
* start_filter.png (menubar_categories.tpl)
* stop_filter.png (menubar_categories.tpl)
* datepicker.png (include/datepicker.inc.tpl)
Steps To Reproduce
Additional Information
Tags No tags attached.
browser any
Database engine and version
PHP version
Web server Apache 1.3.x
Attached Files

- Relationships

-  Notes
(0005810)
rvelices (developer)
2011.11.18 16:58

 not added because:
1) first 5 have different dimmensions so they require different sprite / css rules
2) the 2 filter images are "resized" through css in Sylvia because of the rounded corner - impossible to do with a sprite
3) datepicker jquery ui does not allow anything else than a button text and/or button background image

Any suggestion ?
(0005818)
plg (manager)
2011.11.24 15:47

 For Piwigo 2.4, we should remove all useless icons from core themes, don't you think?

1) yes, they are 16px icons. Can't we make an exception in the CSS rules and simply have them top right in the 26px square of the "all icons" files?

2) can't we slightly change the CSS rule :

#menubar .button {top: 22px;}

and remove height/width

3) ok, we have to comply with datepicker rules
(0005825)
svn (reporter)
2011.11.29 20:27

 [Subversion] r12671 by rvelices on trunk

-----[Subversion commit log]----------------------------------------------------
bug 2515: a few icons are not in CSS sprite (start/stop filter are now)
also removed many icons that are not used anymore since 2.2
(0005826)
svn (reporter)
2011.11.30 21:51

 [Subversion] r12676 by rvelices on trunk

-----[Subversion commit log]----------------------------------------------------
bug 2515: a few icons are not in CSS sprite (comment actions use text links now)

- Issue History
Date Modified Username Field Change
2011.11.18 15:43 plg New Issue
2011.11.18 15:43 plg Status new => assigned
2011.11.18 15:43 plg Assigned To => rvelices
2011.11.18 15:43 plg browser => any
2011.11.18 15:43 plg Web server => Apache 1.3.x
2011.11.18 16:58 rvelices Note Added: 0005810
2011.11.24 15:47 plg Note Added: 0005818
2011.11.29 20:27 svn Checkin
2011.11.29 20:27 svn Note Added: 0005825
2011.11.30 21:51 svn Checkin
2011.11.30 21:51 svn Note Added: 0005826
2012.01.02 23:22 plg Status assigned => closed
2012.01.02 23:22 plg Resolution open => fixed
2012.01.02 23:22 plg Fixed in Version => 2.4.0beta1

Mantis 1.1.6[^]
Copyright © 2000 - 2008 Mantis Group
Contact
Powered by Mantis Bugtracker