Piwigo Bugtracker

Piwigo bug tracker has moved to Github

This bugtracker is kept to provide history on old issues.


View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002776Piwigotemplatepublic2012.10.22 17:162012.10.27 14:41
ReporterMatthes0815 
Assigned To 
PrioritynormalSeverityminorReproducibilityalways
StatusnewResolutionopen 
PlatformOSOS Version
Product Version2.4.5 
Target VersionFixed in Version 
Summary0002776: Move hardcoded html entirely to templates
DescriptionCurrently it is nearly impossible to create a valid website with strict doctype.
Too much html is still generated inside the functions and therefore not easy to edit and maintain.

For example:
template.class.php writes the combined css with <link> where it should be <link /> for a strict doctype. I'd have to change the php file and would lose it on updates.
TagsNo tags attached.
browserany
Database engine and version
PHP version
Web server
Attached Files

- Relationships

-  Notes
(0006704)
mistic100 (developer)
2012.10.27 14:21

as we have switched to the HTML5 doctype for Piwigo 2.5 I don't think this is still relevant
(0006706)
Matthes0815 (reporter)
2012.10.27 14:41

Well, it's at least still bad style...
It should be in the template's choice, which doctype gets used. I like to use XHTML and create my own little template, but I have to edit core files to make it valid - especially if I want to serve it with the right mime type "application/xml" or "application/xhtml+xml".

It's not a big thing to move the entire html to template files. Instead of assigning the whole link-tag for the combined css there could be the link-tag inside the template and template.class.php just assigns the new src.

- Issue History
Date Modified Username Field Change
2012.10.22 17:16 Matthes0815 New Issue
2012.10.22 17:16 Matthes0815 browser => any
2012.10.27 14:21 mistic100 Note Added: 0006704
2012.10.27 14:41 Matthes0815 Note Added: 0006706


Copyright © 2000 - 2018 MantisBT Team
Contact
Powered by Mantis Bugtracker