Piwigo Bugtracker

Piwigo bug tracker has moved to Github

This bugtracker is kept to provide history on old issues.

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002811Piwigouploadpublic2012.12.20 14:592013.01.01 13:53
Assigned To 
PlatformOSUbuntuOS Version12.10
Product Version2.4.6 
Target VersionFixed in Version2.6.0beta1 
Summary0002811: The directories created in _data or upload have all the permissions
DescriptionWhen piwigo create a directory in upload or _data, it gives all the permissions to that directory (777). This is a bad practive in my humble opinion.

A better approch should be to read the permissions of the parent directory and to give the same permissions to the new directories. We can also create a new configuration parameter and let the users choose the best permission for them.
Steps To Reproduce1- Upload a file with piwigo
2- look at the permissions of the new directories
Additional InformationIt is done on this file.
http://piwigo.org/dev/browser/branches/2.4/admin/include/functions_upload.inc.php#L379 [^]
TagsNo tags attached.
Database engine and version
PHP version
Web serverApache 1.3.x
Attached Files

- Relationships

-  Notes
plg (manager)
2013.01.01 13:53

Actually I see that rvelices had already avoided this problem in [Subversion] r12802 but only function mkgetdir uses $conf['chmod_value'] and function prepare_directory doesn't use mkgetdir.

We should use mkgetdir (Piwigo function) instead of mkdir (php core function).

- Issue History
Date Modified Username Field Change
2012.12.20 14:59 YoBoY New Issue
2012.12.20 14:59 YoBoY browser => any
2012.12.20 14:59 YoBoY Web server => Apache 1.3.x
2012.12.20 15:00 plg Fixed in Version => 2.6.0beta1
2013.01.01 13:53 plg Note Added: 0006791

Copyright © 2000 - 2019 MantisBT Team
Powered by Mantis Bugtracker