Changeset 10505 for extensions/jiwigo-ws-api/src/main/java/fr/mael/jiwigo/dao/impl/CategoryDaoImpl.java

Timestamp:

Apr 20, 2011, 5:17:02 AM (13 years ago)

Author:

anthony43

Message:

huge refactoring to introduce JiwigoException : a generic exception encapsulating low level exceptions (IOException, ProxyAuthentication, etc...)
The aim is to have, on the consumer side, just one exception to catch them all.
this refactoring may need a code review to check the changes.

File:

• extensions/jiwigo-ws-api/src/main/java/fr/mael/jiwigo/dao/impl/CategoryDaoImpl.java (modified) (4 diffs)

extensions/jiwigo-ws-api/src/main/java/fr/mael/jiwigo/dao/impl/CategoryDaoImpl.java

@@ -17 +17 @@
 import fr.mael.jiwigo.transverse.enumeration.MethodsEnum;
 import fr.mael.jiwigo.transverse.exception.FileAlreadyExistsException;
+import fr.mael.jiwigo.transverse.exception.JiwigoException;
 import fr.mael.jiwigo.transverse.exception.ProxyAuthenticationException;
 import fr.mael.jiwigo.transverse.session.SessionManager;
@@ -53 +54 @@
      * @param recursive true : recursive listing of the categories
      * @return the list of categories
+     * @throws JiwigoException 
      * @throws IOException
      * @throws ProxyAuthenticationException
      */
-    public List<Category> list(boolean recursive) throws IOException, ProxyAuthenticationException {
+    public List<Category> list(boolean recursive) throws JiwigoException {
         Document doc = sessionManager.executeReturnDocument(MethodsEnum.LISTER_CATEGORIES.getLabel(), "recursive",
                 String.valueOf(recursive));
@@ -92 +94 @@
      * @return true if the category is successfully created
      * @throws ProxyAuthenticationException
+     * @throws JiwigoException 
      */
-    public boolean create(Category category) throws ProxyAuthenticationException {
+    public boolean create(Category category) throws JiwigoException {
         try {
             if (category.getDirectParent() != null) {
@@ -102 +105 @@
                         "name", category.getName()));
             }
-        } catch (IOException e) {
-            LOG.error(Tools.getStackTrace(e));
         } catch (FileAlreadyExistsException e) {
             LOG.error(Tools.getStackTrace(e));
+            throw new JiwigoException(e);
         }
-        return false;
     }