Changeset 10505 for extensions/jiwigo-ws-api/src/main/java/fr/mael/jiwigo/service/impl/ImageServiceImpl.java

Timestamp:

Apr 20, 2011, 5:17:02 AM (13 years ago)

Author:

anthony43

Message:

huge refactoring to introduce JiwigoException : a generic exception encapsulating low level exceptions (IOException, ProxyAuthentication, etc...)
The aim is to have, on the consumer side, just one exception to catch them all.
this refactoring may need a code review to check the changes.

File:

• extensions/jiwigo-ws-api/src/main/java/fr/mael/jiwigo/service/impl/ImageServiceImpl.java (modified) (6 diffs)

extensions/jiwigo-ws-api/src/main/java/fr/mael/jiwigo/service/impl/ImageServiceImpl.java

@@ -13 +13 @@
 import fr.mael.jiwigo.service.ImageService;
 import fr.mael.jiwigo.transverse.exception.FileAlreadyExistsException;
+import fr.mael.jiwigo.transverse.exception.JiwigoException;
 import fr.mael.jiwigo.transverse.exception.ProxyAuthenticationException;
 import fr.mael.jiwigo.transverse.exception.WrongChunkSizeException;
@@ -51 +52 @@
      * @throws ProxyAuthenticationException
      */
-    public List<Image> listByCategory(Integer categoryId, boolean rafraichir) throws IOException,
-            ProxyAuthenticationException {
+    public List<Image> listByCategory(Integer categoryId, boolean rafraichir) throws JiwigoException {
         return dao.listByCategory(categoryId, rafraichir);
     }
@@ -68 +68 @@
      * @throws FileAlreadyExistsException
      * @throws NoSuchAlgorithmException
+     * @throws JiwigoException 
      * @throws Exception
      */
     public boolean create(String filePath, Integer idCategory, Integer originalWidth, Integer originalHeight,
             Double chunckSize, Integer privacyLevel) throws IOException, NoSuchAlgorithmException,
-            FileAlreadyExistsException, ProxyAuthenticationException, WrongChunkSizeException {
+            FileAlreadyExistsException, ProxyAuthenticationException, WrongChunkSizeException,
+            JiwigoException {
         File originalFile = new File(filePath);
         //get the byte array of the original file, to keep metadata
@@ -117 +119 @@
      * @throws ProxyAuthenticationException
      */
-    public boolean addTags(Image image, String tagId) throws IOException, ProxyAuthenticationException {
+    public boolean addTags(Image image, String tagId) throws JiwigoException {
         return dao.addTags(image.getIdentifier(), tagId);
     }
@@ -128 +130 @@
      * @throws ProxyAuthenticationException
      */
-    public List<Image> search(String queryString) throws IOException, ProxyAuthenticationException {
+    public List<Image> search(String queryString) throws JiwigoException {
         return dao.search(queryString);
     }
@@ -144 +146 @@
     }
 
-    public void addSimple(File file, Integer category, String title) throws IOException {
+    public void addSimple(File file, Integer category, String title) throws JiwigoException {
         dao.addSimple(file, category, title);