Changeset 1086

Timestamp:

Mar 17, 2006, 5:13:19 AM (18 years ago)

Author:

rvelices

Message:

URL rewrite for chronology: uses $pagechronology and
$pagechronology_date. $pagechronology is an array with 'field',
'style' and 'view' keys. This is step 1.

Location:

trunk

Files:

• category.php (modified) (3 diffs)
• include/calendar_base.class.php (modified) (14 diffs)
• include/calendar_monthly.class.php (modified) (19 diffs)
• include/calendar_weekly.class.php (modified) (3 diffs)
• include/functions.inc.php (modified) (37 diffs)
• include/functions_calendar.inc.php (modified) (12 diffs)
• include/section_init.inc.php (modified) (17 diffs)
• picture.php (modified) (14 diffs)

trunk/category.php

@@ -132 +132 @@
 $icon_recent = get_icon(date('Y-m-d'));
 
-$calendar_view_link = duplicate_index_URL(
-  array(),                            // nothing to redefine
-  array('chronology_type', 'start')   // what to remove ?
-  );
-
-if (!isset($page['chronology_type']))
-{
-  $calendar_view_link.= '/calendar-';
-
+if (!isset($page['chronology']))
+{
+  $chronology =
+    array(
+      'chronology' =>
+        array(
+          'field' => 'created',
+          'style' => 'monthly',
+          'view' => 'list',
+        )
+    );
   $template->assign_block_vars(
     'mode_created',
     array(
-      'URL' => $calendar_view_link.'created'
-      )
-    );
-
+      'URL' => duplicate_index_URL( $chronology, array('start') )
+      )
+    );
+
+  $chronology['chronology']['field'] = 'posted';
   $template->assign_block_vars(
     'mode_posted',
     array(
-      'URL' => $calendar_view_link.'posted'
+      'URL' => duplicate_index_URL( $chronology, array('start') )
       )
     );
@@ -160 +163 @@
     'mode_normal',
     array(
-      'URL' => $calendar_view_link
-      )
-    );
-
-  $calendar_view_link .= '/calendar-';
-  if ($page['chronology_type'] == 'created')
-  {
-    $template->assign_block_vars(
-      'mode_posted',
-      array(
-        'URL' => $calendar_view_link.'posted'
-        )
-      );
+      'URL' => duplicate_index_URL( array(), array('chronology','start') )
+      )
+    );
+
+  $chronology = $page['chronology'];
+  if ($chronology['field'] == 'created')
+  {
+    $chronology['field'] = 'posted';
   }
   else
   {
-    $template->assign_block_vars(
-      'mode_created',
-      array(
-        'URL' => $calendar_view_link.'created'
-        )
-      );
-  }
+    $chronology['field'] = 'created';
+  }
+  $url = duplicate_index_URL(
+            array(
+              'chronology'=>$chronology
+            ),
+            array('chronology_date', 'start')
+          );
+  $template->assign_block_vars(
+    'mode_'.$chronology['field'],
+    array('URL' => $url )
+    );
 }
 
@@ -294 +297 @@
   array(
     'URL' =>
-      make_index_URL()
-      .'/calendar-'
-      .($conf['calendar_datefield'] == 'date_available' ? 'posted' : 'created')
-      .'-monthly-c',
+      make_index_URL(
+        array(
+          'chronology'=>
+            array(
+              'field' => ($conf['calendar_datefield']=='date_available' ? 'posted' : 'created'),
+              'style' => 'monthly',
+              'view' => 'calendar'
+            )
+        )
+      ),
     'TITLE' => $lang['calendar_hint'],
     'NAME' => $lang['calendar']

trunk/include/calendar_base.class.php

@@ -34 +34 @@
   // used for queries (INNER JOIN or normal)
   var $inner_sql;
-  // base url used when generating html links
-  var $url_base;
-  // array of date components e.g. (2005,10,12) ...
-  var $date_components;
   //
   var $calendar_levels;
@@ -45 +41 @@
   /**
    * Initialize the calendar
-   * @param string date_field db column on which this calendar works
    * @param string inner_sql used for queries (INNER JOIN or normal)
-   * @param array date_components
-   */
-  function initialize($date_field, $inner_sql, $date_components)
-  {
-    $this->date_field = $date_field;
+   */
+  function initialize($inner_sql)
+  {
+    global $page;
+    if ($page['chronology']['field']=='posted')
+    {
+      $this->date_field = 'date_available';
+    }
+    else
+    {
+      $this->date_field = 'date_creation';
+    }
     $this->inner_sql = $inner_sql;
-    $this->date_components = $date_components;
     $this->has_nav_bar = false;
   }
@@ -59 +60 @@
   function get_display_name()
   {
-    global $conf;
+    global $conf, $page;
     $res = '';
-    $url = $this->url_base;
-
-    for ($i=0; $i<count($this->date_components); $i++)
+
+    for ($i=0; $i<count($page['chronology_date']); $i++)
     {
       $res .= $conf['level_separator'];
-      if ($i>0)
-      {
-        $url .= '-';
-      }
-      $url .= $this->date_components[$i];
-      if ( isset($this->date_components[$i+1]) )
-      {
+      if ( isset($page['chronology_date'][$i+1]) )
+      {
+        $chronology_date = array_slice($page['chronology_date'],0, $i+1);
+        $url = duplicate_index_url(
+            array( 'chronology_date'=>$chronology_date ),
+            array( 'start' )
+            );
         $res .=
           '<a href="'.$url.'">'
-          .$this->get_date_component_label($i, $this->date_components[$i])
+          .$this->get_date_component_label($i, $page['chronology_date'][$i])
           .'</a>';
       }
@@ -82 +82 @@
         $res .=
           '<span class="calInHere">'
-          .$this->get_date_component_label($i, $this->date_components[$i])
+          .$this->get_date_component_label($i, $page['chronology_date'][$i])
           .'</span>';
       }
@@ -132 +132 @@
    * Creates a calendar navigation bar.
    *
-   * @param string url_base - links start with this root
+   * @param array date_components
    * @param array items - hash of items to put in the bar (e.g. 2005,2006)
    * @param array selected_item - item currently selected (e.g. 2005)
@@ -141 +141 @@
    * @return string the navigation bar
    */
-  function get_nav_bar_from_items($url_base, $items, $selected_item,
+  function get_nav_bar_from_items($date_components, $items, $selected_item,
                                   $class_prefix, $show_any,
                                   $show_empty=false, $labels=null)
   {
-    global $conf;
+    global $conf, $page;
 
     $nav_bar = '';
@@ -181 +181 @@
       {
         $nav_bar .= '<span class="'.$class_prefix.'">';
-        $url = $url_base . $item;
+        $url = duplicate_index_url(
+          array('chronology_date'=>array_merge($date_components,$item)),
+          array( 'start' )
+            );
         $nav_bar .= '<a href="'.$url.'">';
         $nav_bar .= $label;
@@ -204 +207 @@
       {
         $nav_bar .= '<span class="'.$class_prefix.'">';
-        $url = $url_base . 'any';
+        $url = duplicate_index_url(
+          array('chronology_date'=>array_merge($date_components,'any')),
+          array( 'start' )
+            );
         $nav_bar .= '<a href="'.$url.'">';
         $nav_bar .= $label;
@@ -222 +228 @@
   function build_nav_bar($level, $labels=null)
   {
-    global $template, $conf;
+    global $template, $conf, $page;
 
     $query = '
@@ -241 +247 @@
 
     if ( count($level_items)==1 and
-         count($this->date_components)<count($this->calendar_levels)-1)
-    {
-      if ( ! isset($this->date_components[$level]) )
+         count($page['chronology_date'])<count($this->calendar_levels)-1)
+    {
+      if ( ! isset($page['chronology_date'][$level]) )
       {
         list($key) = array_keys($level_items);
-        $this->date_components[$level] = (int)$key;
-
-        if ( $level<count($this->date_components) and
+        $page['chronology_date'][$level] = (int)$key;
+
+        if ( $level<count($page['chronology_date']) and
              $level!=count($this->calendar_levels)-1 )
         {
@@ -256 +262 @@
     }
 
-    $url_base = $this->url_base;
-    for ($i=0; $i<$level; $i++)
-    {
-      if (isset($this->date_components[$i]))
-      {
-        $url_base .= $this->date_components[$i].'-';
-      }
-    }
     $nav_bar = $this->get_nav_bar_from_items(
-      $url_base,
+      $page['chronology_date'],
       $level_items,
       null,
@@ -289 +287 @@
   function build_next_prev()
   {
-    global $template;
+    global $template, $page;
     $prev = $next =null;
-    if ( empty($this->date_components) )
+    if ( empty($page['chronology_date']) )
       return;
     $query = 'SELECT CONCAT_WS("-"';
-    for ($i=0; $i<count($this->date_components); $i++)
-    {
-      if ( 'any' === $this->date_components[$i] )
+    for ($i=0; $i<count($page['chronology_date']); $i++)
+    {
+      if ( 'any' === $page['chronology_date'] )
       {
         $query .= ','.'"any"';
@@ -305 +303 @@
       }
     }
-    $current = implode('-', $this->date_components );
+    $current = implode('-', $page['chronology_date'] );
 
     $query.=') as period' . $this->inner_sql .'
@@ -328 +326 @@
       $template->assign_block_vars( 'calendar.navbar', array() );
     }
+
     if ( $current_rank>0 )
     { // has previous
       $prev = $upper_items[$current_rank-1];
+      $chronology_date = explode('-', $prev);
       $template->assign_block_vars(
         'calendar.navbar.prev',
         array(
           'LABEL' => $this->get_date_nice_name($prev),
-          'URL' => $this->url_base . $prev,
+          'URL' => duplicate_index_url(
+                array('chronology_date'=>$chronology_date), array('start')
+                )
           )
         );
     }
     if ( $current_rank < count($upper_items)-1 )
-    {
-      // has next
+    { // has next
       $next = $upper_items[$current_rank+1];
+      $chronology_date = explode('-', $next);
       $template->assign_block_vars(
         'calendar.navbar.next',
         array(
           'LABEL' => $this->get_date_nice_name($next),
-          'URL' => $this->url_base . $next,
+          'URL' => duplicate_index_url(
+                array('chronology_date'=>$chronology_date), array('start')
+                )
           )
         );

trunk/include/calendar_monthly.class.php

@@ -1 @@
-<?php
+  <?php
 // +-----------------------------------------------------------------------+
 // | PhpWebGallery - a PHP based picture gallery                           |
@@ -39 +39 @@
   /**
    * Initialize the calendar
-   * @param string date_field db column on which this calendar works
    * @param string inner_sql used for queries (INNER JOIN or normal)
-   * @param array date_components
    */
-  function initialize($date_field, $inner_sql, $date_components)
-  {
-    parent::initialize($date_field, $inner_sql, $date_components);
+  function initialize($inner_sql)
+  {
+    parent::initialize($inner_sql);
     global $lang;
     $this->calendar_levels = array(
@@ -68 +66 @@
  * where not included here, true otherwise
  */
-function generate_category_content($url_base, $view_type)
-{
-  global $conf;
-
-  $this->url_base = $url_base;
-
+function generate_category_content()
+{
+  global $conf, $page;
+
+  $view_type = $page['chronology']['view'];
   if ($view_type==CAL_VIEW_CALENDAR)
   {
-    if ( count($this->date_components)==0 )
+    if ( count($page['chronology_date'])==0 )
     {//case A: no year given - display all years+months
       if ($this->build_global_calendar())
@@ -82 +79 @@
     }
 
-    if ( count($this->date_components)==1 )
+    if ( count($page['chronology_date'])==1 )
     {//case B: year given - display all days in given year
       if ($this->build_year_calendar())
@@ -91 +88 @@
     }
 
-    if ( count($this->date_components)==2 )
+    if ( count($page['chronology_date'])==2 )
     {//case C: year+month given - display a nice month calendar
       $this->build_month_calendar();
@@ -101 +98 @@
   }
 
-  if ($view_type==CAL_VIEW_LIST or count($this->date_components)==3)
+  if ($view_type==CAL_VIEW_LIST or count($page['chronology_date'])==3)
   {
     $has_nav_bar = false;
-    if ( count($this->date_components)==0 )
+    if ( count($page['chronology_date'])==0 )
     {
       $this->build_nav_bar(CYEAR); // years
     }
-    if ( count($this->date_components)==1)
+    if ( count($page['chronology_date'])==1)
     {
       $this->build_nav_bar(CMONTH); // month
     }
-    if ( count($this->date_components)==2 )
+    if ( count($page['chronology_date'])==2 )
     {
       $day_labels = range( 1, $this->get_all_days_in_month(
-              $this->date_components[CYEAR] ,$this->date_components[CMONTH] ) );
+              $page['chronology_date'][CYEAR] ,$page['chronology_date'][CMONTH] ) );
       array_unshift($day_labels, 0);
       unset( $day_labels[0] );
@@ -134 +131 @@
 function get_date_where($max_levels=3)
 {
-  $date = $this->date_components;
+  global $page;
+  $date = $page['chronology_date'];
   while (count($date)>$max_levels)
   {
@@ -219 +217 @@
 function build_global_calendar()
 {
-  assert( count($this->date_components) == 0 );
+  global $page;
+  assert( count($page['chronology_date']) == 0 );
   $query='SELECT DISTINCT(DATE_FORMAT('.$this->date_field.',"%Y%m")) as period,
             COUNT( DISTINCT(id) ) as count';
@@ -245 +244 @@
   {// only one year exists so bail out to year view
     list($y) = array_keys($items);
-    $this->date_components[CYEAR] = $y;
+    $page['chronology_date'][CYEAR] = $y;
     return false;
   }
@@ -252 +251 @@
   foreach ( $items as $year=>$year_data)
   {
-    $url_base = $this->url_base.$year;
-
-    $nav_bar = '<span class="calCalHead"><a href="'.$url_base.'">'.$year.'</a>';
+    $chronology_date = array( $year );
+    $url = duplicate_index_url( array('chronology_date'=>$chronology_date) );
+
+    $nav_bar = '<span class="calCalHead"><a href="'.$url.'">'.$year.'</a>';
     $nav_bar .= ' ('.$year_data['nb_images'].')';
     $nav_bar .= '</span><br>';
 
-    $url_base .= '-';
-    $nav_bar .= $this->get_nav_bar_from_items( $url_base,
+    $nav_bar .= $this->get_nav_bar_from_items( $chronology_date,
             $year_data['children'], null, 'calCal', false, false, $lang['month'] );
 
@@ -271 +270 @@
 function build_year_calendar()
 {
-  assert( count($this->date_components) == 1 );
+  global $page;
+  assert( count($page['chronology_date']) == 1 );
   $query='SELECT DISTINCT(DATE_FORMAT('.$this->date_field.',"%m%d")) as period,
             COUNT( DISTINCT(id) ) as count';
@@ -295 +295 @@
   { // only one month exists so bail out to month view
     list($m) = array_keys($items);
-    $this->date_components[CMONTH] = $m;
+    $page['chronology_date'][CMONTH] = $m;
     return false;
   }
@@ -301 +301 @@
   foreach ( $items as $month=>$month_data)
   {
-    $url_base = $this->url_base.$this->date_components[CYEAR].'-'.$month;
-
-    $nav_bar = '<span class="calCalHead"><a href="'.$url_base.'">';
+    $chronology_date = array( $page['chronology_date'][CYEAR], $month );
+    $url = duplicate_index_url( array('chronology_date'=>$chronology_date) );
+
+    $nav_bar = '<span class="calCalHead"><a href="'.$url.'">';
     $nav_bar .= $lang['month'][$month].'</a>';
     $nav_bar .= ' ('.$month_data['nb_images'].')';
     $nav_bar .= '</span><br>';
 
-    $url_base .= '-';
-    $nav_bar .= $this->get_nav_bar_from_items( $url_base,
+    $nav_bar .= $this->get_nav_bar_from_items( $chronology_date,
                      $month_data['children'], null, 'calCal', false );
 
@@ -322 +322 @@
 function build_month_calendar()
 {
+  global $page;
   $query='SELECT DISTINCT(DAYOFMONTH('.$this->date_field.')) as period,
             COUNT( DISTINCT(id) ) as count';
   $query.= $this->inner_sql;
-  $query.= $this->get_date_where($this->date_components);
+  $query.= $this->get_date_where();
   $query.= '
   GROUP BY period';
@@ -338 +339 @@
   foreach ( $items as $day=>$data)
   {
-    $this->date_components[CDAY]=$day;
+    $page['chronology_date'][CDAY]=$day;
     $query = '
 SELECT file,tn_ext,path, width, height, DAYOFWEEK('.$this->date_field.')-1 as dow';
@@ -346 +347 @@
   ORDER BY RAND()
   LIMIT 0,1';
-    unset ( $this->date_components[CDAY] );
+    unset ( $page['chronology_date'][CDAY] );
 
     $row = mysql_fetch_array(pwg_query($query));
@@ -417 +418 @@
       $template->assign_block_vars('calendar.thumbnails.row.col.blank', array());
     }
-    for ($day=1; $day<=$this->get_all_days_in_month(
-              $this->date_components[CYEAR] ,$this->date_components[CMONTH]); $day++)
+    for ( $day = 1;
+          $day <= $this->get_all_days_in_month(
+            $page['chronology_date'][CYEAR], $page['chronology_date'][CMONTH]
+              );
+          $day++)
     {
       $dow = ($first_day_dow + $day-1)%7;
@@ -487 +491 @@
           $css_style.='top:'.round(-$pos_top).'px;';
         }
-        $url = $this->url_base.
-              $this->date_components[CYEAR].'-'.
-              $this->date_components[CMONTH].'-'.$day;
+        $url = duplicate_index_url(
+            array(
+              'chronology_date' =>
+                array(
+                  $page['chronology_date'][CYEAR],
+                  $page['chronology_date'][CMONTH],
+                  $day
+                )
+            )
+          );
         $alt = $wday_labels[$dow] . ' ' . $day.
                ' ('.$items[$day]['nb_images'].')';
@@ -520 +531 @@
     foreach ( $items as $day=>$data)
     {
-      $url = $this->url_base.
-            $this->date_components[CYEAR].'-'.
-            $this->date_components[CMONTH].'-'.$day;
+      $url = duplicate_index_url(
+          array(
+            'chronology_date' =>
+              array(
+                $page['chronology_date'][CYEAR],
+                $page['chronology_date'][CMONTH],
+                $day
+              )
+          )
+        );
 
       $thumbnail_title = $lang['day'][$data['dow']] . ' ' . $day;

trunk/include/calendar_weekly.class.php

@@ -39 +39 @@
   /**
    * Initialize the calendar
-   * @param string date_field db column on which this calendar works
    * @param string inner_sql used for queries (INNER JOIN or normal)
-   * @param array date_components
    */
-  function initialize($date_field, $inner_sql, $date_components)
+  function initialize($inner_sql)
   {
-    parent::initialize($date_field, $inner_sql, $date_components);
+    parent::initialize($inner_sql);
     global $lang;
     $week_no_labels=array();
@@ -80 +78 @@
  * @return boolean false to indicate that thumbnails where not included here
  */
-function generate_category_content($url_base, $view_type)
+function generate_category_content()
 {
-  global $conf;
+  global $conf, $page;
 
-  $this->url_base = $url_base;
-
-  assert($view_type==CAL_VIEW_LIST);
-
-  if ( count($this->date_components)==0 )
+  if ( count($page['chronology_date'])==0 )
   {
     $this->build_nav_bar(CYEAR); // years
   }
-  if ( count($this->date_components)==1 )
+  if ( count($page['chronology_date'])==1 )
   {
     $this->build_nav_bar(CWEEK, array()); // week nav bar 1-53
   }
-  if ( count($this->date_components)==2 )
+  if ( count($page['chronology_date'])==2 )
   {
     $this->build_nav_bar(CDAY); // days nav bar Mon-Sun
@@ -113 +107 @@
 function get_date_where($max_levels=3)
 {
-  $date = $this->date_components;
+  global $page;
+  $date = $page['chronology_date'];
   while (count($date)>$max_levels)
   {

trunk/include/functions.inc.php

@@ -224 +224 @@
   $height = $original_height;
   $is_original_size = true;
-                
+
   if ( $max_width != "" )
   {
@@ -250 +250 @@
     {
       if ( $ratioWidth < $ratioHeight )
-      { 
+      {
         $width = floor( $original_width / $ratioHeight );
         $height = $max_height;
       }
       else
-      { 
-        $width = $max_width; 
+      {
+        $width = $max_width;
         $height = floor( $original_height / $ratioWidth );
       }
@@ -331 +331 @@
                              $remaining );
   $return_string.= $treatment;
-                
+
   return $return_string;
 }
@@ -341 +341 @@
   // FIXME : with new advanced search, this function needs a rewrite
   return $string;
-  
+
   $words = explode( ',', $search );
   $style = 'background-color:white;color:red;';
@@ -360 +360 @@
     $login = ($user['id'] == $conf['guest_id'])
       ? 'guest' : addslashes($user['username']);
-    
+
     $query = '
 INSERT INTO '.HISTORY_TABLE.'
@@ -388 +388 @@
 
   list($year,$month,$day,$hour,$minute,$second) = array(0,0,0,0,0,0);
-  
+
   switch ( $type )
   {
@@ -433 +433 @@
 {
   global $conf,$page,$debug,$t2;
-  
+
   $start = get_moment();
   $result = mysql_query($query) or my_error($query."\n");
-  
+
   $time = get_moment() - $start;
 
@@ -444 +444 @@
     $page['queries_time'] = 0;
   }
-  
+
   $page['count_queries']++;
   $page['queries_time']+= $time;
-  
+
   if ($conf['show_queries'])
   {
@@ -460 +460 @@
     $output.= number_format( ($time+$start-$t2), 3, '.', ' ').' s)';
     $output.= "</pre>\n";
-    
+
     $debug .= $output;
   }
-  
+
   return $result;
 }
@@ -501 +501 @@
 
   include( PHPWG_ROOT_PATH.'include/page_header.php' );
-  
+
   $template->set_filenames( array( 'redirect' => 'redirect.tpl' ) );
   $template->parse('redirect');
-  
+
   include( PHPWG_ROOT_PATH.'include/page_tail.php' );
 
@@ -519 +519 @@
 {
   $query_string = '';
-  
+
   $str = $_SERVER['QUERY_STRING'];
   parse_str($str, $vars);
-  
+
   $is_first = true;
   foreach ($vars as $key => $value)
@@ -554 +554 @@
 
   $template_dir = PHPWG_ROOT_PATH.'template';
-  
+
   foreach (get_dirs($template_dir) as $template)
   {
@@ -596 +596 @@
     $src.= strtolower(get_extension($path)).'.png';
   }
-  
+
   return $src;
 }
@@ -623 +623 @@
 {
   $array = array();
-  
+
   $result = pwg_query($query);
   while ($row = mysql_fetch_array($result))
@@ -642 +642 @@
 {
   global $template;
-  
+
   $template->assign_block_vars(
     $blockname, array('SELECTED' => '', 'VALUE' => 0, 'OPTION' => '--'));
-  
+
   for ($i = 1; $i <= 31; $i++)
   {
@@ -669 +669 @@
 {
   global $template, $lang;
-  
+
   $template->assign_block_vars(
     $blockname, array('SELECTED' => '',
@@ -698 +698 @@
 {
   global $user;
-  
+
   include_once(PHPWG_ROOT_PATH.'admin/include/functions.php');
-  
+
   $query = '
 SELECT element_id
@@ -750 +750 @@
     echo '[l10n] language key "'.$key.'" is not defined<br />';
   }
-  
+
   return isset($lang[$key]) ? $lang[$key] : $key;
 }
@@ -798 +798 @@
     die('Search id must be an integer');
   }
-  
+
   $query = '
 SELECT rules
@@ -805 +805 @@
 ;';
   list($serialized_rules) = mysql_fetch_row(pwg_query($query));
-  
+
   return unserialize($serialized_rules);
 }
@@ -821 +821 @@
 {
   $search = get_search_array($search_id);
-  
+
   // SQL where clauses are stored in $clauses array during query
   // construction
   $clauses = array();
-  
+
   foreach (array('file','name','comment','keywords','author') as $textfield)
   {
@@ -848 +848 @@
     }
   }
-  
+
   if (isset($search['fields']['allwords']))
   {
@@ -876 +876 @@
         );
     }
-    
+
     array_walk(
       $word_clauses,
       create_function('&$s','$s="(".$s.")";')
       );
-    
+
     array_push(
       $clauses,
@@ -893 +893 @@
       );
   }
-  
+
   foreach (array('date_available', 'date_creation') as $datefield)
   {
@@ -903 +903 @@
         );
     }
-    
+
     foreach (array('after','before') as $suffix)
     {
       $key = $datefield.'-'.$suffix;
-      
+
       if (isset($search['fields'][$key]))
       {
         array_push(
           $clauses,
-          
+
           $datefield.
           ($suffix == 'after'             ? ' >' : ' <').
           ($search['fields'][$key]['inc'] ? '='  : '').
           " '".$search['fields'][$key]['date']."'"
-          
+
           );
       }
     }
   }
-  
+
   if (isset($search['fields']['cat']))
   {
@@ -934 +934 @@
       $cat_ids = $search['fields']['cat']['words'];
     }
-    
+
     $local_clause = 'category_id IN ('.implode(',', $cat_ids).')';
     array_push($clauses, $local_clause);
   }
-  
+
   // adds brackets around where clauses
   $clauses = prepend_append_array_items($clauses, '(', ')');
-  
+
   $where_separator =
     implode(
@@ -947 +947 @@
       $clauses
       );
-  
+
   $search_clause = $where_separator;
-  
+
   if (isset($forbidden))
   {
@@ -987 +987 @@
 
   $available_upgrade_ids = array();
-  
+
   if ($contents = opendir($upgrades_path))
   {
@@ -1016 +1016 @@
     .'/'.make_section_in_URL($params)
     ;
-  
-  if (isset($params['start']) and $params['start'] > 0)
-  {
-    $url.= '/start-'.$params['start'];
-  }
+
+  $url = add_well_known_params_in_url($url, $params);
 
   return $url;
@@ -1107 +1104 @@
     die('make_picture_URL: image_id is a required parameter');
   }
-  
+
   $url =
     PHPWG_ROOT_PATH.'picture.php?'
@@ -1114 +1111 @@
     ;
 
-  // first comment to start on
+  $url = add_well_known_params_in_url($url, $params);
+  return $url;
+}
+
+/**
+ *adds to the url the chronology and start parameters
+*/
+function add_well_known_params_in_url($url, $params)
+{
+  if ( isset($params['chronology']) )
+  {
+    $url .= '/'. $params['chronology']['field'];
+    $url .= '-'. $params['chronology']['style'];
+    if ( isset($params['chronology']['view']) )
+    {
+      $url .= '-'. $params['chronology']['view'];
+    }
+    if ( isset($params['chronology_date']) )
+    {
+      $url .= '-'. implode('-', $params['chronology_date'] );
+    }
+  }
+
   if (isset($params['start']) and $params['start'] > 0)
   {
     $url.= '/start-'.$params['start'];
   }
-
   return $url;
 }
@@ -1135 +1153 @@
 {
   $section_string = '';
-  
+
   if (!isset($params['section']))
   {
@@ -1160 +1178 @@
     $params['section'] = 'categories';
   }
-  
+
   switch($params['section'])
   {
@@ -1173 +1191 @@
         $section_string.= 'category/'.$params['category'];
       }
-      
+
       break;
     }
@@ -1189 +1207 @@
         $section_string.= '/'.$tag;
       }
-      
+
       break;
     }
@@ -1198 +1216 @@
         die('make_section_in_URL: require a search identifier');
       }
-      
+
       $section_string.= 'search/'.$params['search'];
 
@@ -1211 +1229 @@
 
       $section_string.= 'list/'.implode(',', $params['list']);
-      
+
       break;
     }

trunk/include/functions_calendar.inc.php

@@ -25 +25 @@
 // +-----------------------------------------------------------------------+
 
-define('CAL_VIEW_LIST',     'l');
-define('CAL_VIEW_CALENDAR', 'c');
-
-function get_calendar_parameter($options, &$parameters )
-{
-  if ( count($parameters) and isset($options[$parameters[0]]) )
-  {
-    return array_shift($parameters);
-  }
-  else
-  {
-    foreach ($options as $option => $data)
-    {
-       if ( empty( $data['default_link'] ) )
-       {
-         break;
-       }
-    }
-    return $option;
-  }
-}
+define('CAL_VIEW_LIST',     'list');
+define('CAL_VIEW_CALENDAR', 'calendar');
 
 function initialize_calendar()
@@ -54 +35 @@
   $inner_sql = ' FROM ' . IMAGES_TABLE;
 
-  if (!isset($page['cat']) or is_numeric($page['cat']))
+  if (!isset($page['category']) or is_numeric($page['category']))
   { // we will regenerate the items by including subcats elements
     $page['cat_nb_images'] = 0;
@@ -61 +42 @@
 INNER JOIN '.IMAGE_CATEGORY_TABLE.' ON id = image_id';
 
-    if (isset($page['cat']) and is_numeric($page['cat']))
+    if (isset($page['category']) and is_numeric($page['category']))
     {
       $sub_ids = array_diff(
-        get_subcat_ids(array($page['cat'])),
+        get_subcat_ids(array($page['category'])),
         explode(',', $user['forbidden_categories'])
         );
@@ -93 +74 @@
 //-------------------------------------- initialize the calendar parameters ---
   pwg_debug('start initialize_calendar');
-  // the parameters look like (FIELD)?(STYLE)?(VIEW)?(DATE COMPONENTS)?
-  // FIELD = (created-|posted-)
-  // STYLE = (m-|w-)
-  // VIEW  = (l-|c-)
-  // DATE COMPONENTS= YEAR(-MONTH/WEEK)?(-DAY)?
 
   $fields = array(
     // Created
     'created' => array(
-      'default_link'   => 'created-',
       'label'          => l10n('Creation date'),
-      'db_field'       => 'date_creation',
       ),
     // Posted
     'posted' => array(
-      'default_link'   => 'posted-',
       'label'          => l10n('Post date'),
-      'db_field'       => 'date_available',
       ),
     );
@@ -117 +89 @@
     // Monthly style
     'monthly' => array(
-      'default_link'   => '',
       'include'        => 'calendar_monthly.class.php',
       'view_calendar'  => true,
@@ -123 +94 @@
     // Weekly style
     'weekly' => array(
-      'default_link'   => 'weekly-',
       'include'        => 'calendar_weekly.class.php',
       'view_calendar'  => false,
@@ -129 +99 @@
     );
 
-  $views = array(
-    // list view
-    CAL_VIEW_LIST => array(
-      'default_link'   => '',
-      ),
-    // calendar view
-    CAL_VIEW_CALENDAR => array(
-      'default_link'   => CAL_VIEW_CALENDAR.'-',
-      ),
-    );
-
-  $requested = explode('-', $_GET['calendar']);
+  $views = array(CAL_VIEW_LIST,CAL_VIEW_CALENDAR);
 
   // Retrieve calendar field
-  $cal_field = get_calendar_parameter($fields, $requested);
+  if ( !isset( $fields[ $page['chronology']['field'] ] ) )
+  {
+    die('bad field');
+  }
 
   // Retrieve style
-  $cal_style = get_calendar_parameter($styles, $requested);
+  if ( !isset( $styles[ $page['chronology']['style'] ] ) )
+  {
+    $page['chronology']['style'] = 'monthly';
+  }
+  $cal_style = $page['chronology']['style'];
   include(PHPWG_ROOT_PATH.'include/'. $styles[$cal_style]['include']);
   $calendar = new Calendar();
 
   // Retrieve view
-  $cal_view = get_calendar_parameter($views, $requested);
-  if ( CAL_VIEW_CALENDAR==$cal_view and !$styles[$cal_style]['view_calendar'] )
-  {
-    $cal_view=CAL_VIEW_LIST;
-  }
+
+  if ( !isset($page['chronology']['view']) or
+       !in_array( $page['chronology']['view'], $views ) )
+  {
+    $page['chronology']['view'] = CAL_VIEW_LIST;
+  }
+
+  if ( CAL_VIEW_CALENDAR==$page['chronology']['view'] and
+        !$styles[$cal_style]['view_calendar'] )
+  {
+
+    $page['chronology']['view'] = CAL_VIEW_LIST;
+  }
+  $cal_view = $page['chronology']['view'];
 
   // perform a sanity check on $requested
-  while (count($requested) > 3)
-  {
-    array_pop($requested);
+  if (!isset($page['chronology_date']))
+  {
+    $page['chronology_date'] = array();
+  }
+  while ( count($page['chronology_date']) > 3)
+  {
+    array_pop($page['chronology_date']);
   }
 
   $any_count = 0;
-  for ($i = 0; $i < count($requested); $i++)
-  {
-    if ($requested[$i] == 'any')
+  for ($i = 0; $i < count($page['chronology_date']); $i++)
+  {
+    if ($page['chronology_date'][$i] == 'any')
     {
       if ($cal_view == CAL_VIEW_CALENDAR)
       {// we dont allow any in calendar view
-        while ($i < count($requested))
+        while ($i < count($page['chronology_date']))
         {
-          array_pop($requested);
+          array_pop($page['chronology_date']);
         }
         break;
@@ -178 +157 @@
       $any_count++;
     }
-    elseif ($requested[$i] == '')
-    {
-      while ($i < count($requested))
+    elseif ($page['chronology_date'][$i] == '')
+    {
+      while ($i < count($page['chronology_date']))
       {
-        array_pop($requested);
+        array_pop($page['chronology_date']);
       }
     }
     else
     {
-      $requested[$i] = (int)$requested[$i];
+      $page['chronology_date'][$i] = (int)$page['chronology_date'][$i];
     }
   }
   if ($any_count == 3)
   {
-    array_pop($requested);
-  }
-
-  $calendar->initialize($fields[$cal_field]['db_field'], $inner_sql, $requested);
+    array_pop($page['chronology_date']);
+  }
+
+  $calendar->initialize($inner_sql);
 
   //echo ('<pre>'. var_export($calendar, true) . '</pre>');
 
-  $url_base = get_query_string_diff(array('start', 'calendar'));
+/*  $url_base = get_query_string_diff(array('start', 'calendar'));
   $url_base =
     PHPWG_ROOT_PATH.'category.php'
@@ -205 +184 @@
     .(empty($url_base) ? '?' : '&')
     .'calendar='.$cal_field.'-'
-    ;
+    ;*/
   $must_show_list = true; // true until calendar generates its own display
   if (basename($_SERVER["PHP_SELF"]) == 'category.php')
@@ -211 +190 @@
     $template->assign_block_vars('calendar', array());
 
-    if ($calendar->generate_category_content(
-          $url_base.$cal_style.'-'.$cal_view.'-',
-          $cal_view
-          )
-       )
+    if ($calendar->generate_category_content())
     {
       unset(
@@ -229 +204 @@
     foreach ($styles as $style => $style_data)
     {
-      foreach ($views as $view => $view_data)
+      foreach ($views as $view)
       {
         if ( $style_data['view_calendar'] or $view != CAL_VIEW_CALENDAR)
         {
           $selected = '';
-          $url = $url_base.$style.'-'.$view;
-          if ($style==$cal_style)
+          $chronology = $page['chronology'];
+          $chronology['style'] = $style;
+          $chronology['view'] = $view;
+
+          if ($style!=$cal_style)
           {
-            $url .= '-'.implode('-', $calendar->date_components);
-            if ( $view==$cal_view )
+            $chronology_date = array();
+            if ( isset($page['chronology_date'][0]) )
             {
-              $selected = 'SELECTED';
+              array_push($chronology_date, $page['chronology_date'][0]);
             }
           }
           else
           {
-            if (isset($calendar->date_components[0]))
-            {
-              $url .= '-' . $calendar->date_components[0];
-            }
+            $chronology_date = $page['chronology_date'];
           }
+          $url = duplicate_index_url(
+              array(
+                'chronology' => $chronology,
+                'chronology_date' => $chronology_date,
+                )
+             );
+
+          if ($style==$cal_style and $view==$cal_view )
+          {
+            $selected = 'SELECTED';
+          }
+
           $template->assign_block_vars(
             'calendar.views.view',
@@ -261 +248 @@
       }
     }
-    $calendar_title =
-        '<a href="'.$url_base.$cal_style.'-'.$cal_view.'">'
-        .$fields[$cal_field]['label'].'</a>';
+    $url = duplicate_index_url(
+              array('chronology_date'=>array()), array('start')
+            );
+    $calendar_title = '<a href="'.$url.'">'
+        .$fields[$chronology['field']]['label'].'</a>';
     $calendar_title.= $calendar->get_display_name();
     //this should be an assign_block_vars, but I need to assign 'calendar'

trunk/include/section_init.inc.php

@@ -79 +79 @@
       }
       $page['image_id'] = $matches[1];
-      
-      $next_token++;
-    }
-    
+
+      $next_token++;
+    }
+
     if (0 === strpos($tokens[$next_token], 'cat'))
     {
       $page['section'] = 'categories';
       $next_token++;
-      
+
       if (isset($tokens[$next_token])
-          and preg_match('/(\d+)/', $tokens[$next_token], $matches))
+          and preg_match('/^(\d+)/', $tokens[$next_token], $matches))
       {
         $page['category'] = $matches[1];
@@ -99 +99 @@
       $page['section'] = 'tags';
       $page['tags'] = array();
-      
-      $next_token++;
-      
+
+      $next_token++;
+
       for ($i = $next_token; ; $i++)
       {
@@ -108 +108 @@
           break;
         }
-        
+
         preg_match('/^(\d+)/', $tokens[$i], $matches);
         if (!isset($matches[1]))
@@ -123 +123 @@
         array_push($page['tags'], $matches[1]);
       }
-      
+
       $next_token = $i;
     }
@@ -155 +155 @@
       $page['section'] = 'search';
       $next_token++;
-      
+
       preg_match('/(\d+)/', $tokens[$next_token], $matches);
       if (!isset($matches[1]))
@@ -185 +185 @@
       $next_token++;
     }
-    
+
     for ($i = $next_token; ; $i++)
     {
@@ -192 +192 @@
         break;
       }
-      
+
       if (preg_match('/^start-(\d+)/', $tokens[$i], $matches))
       {
@@ -198 +198 @@
       }
 
-      if (preg_match('/^calendar-(.+)$/', $tokens[$i], $matches))
-      {
-        // TODO: decide with rvelices how we name calendar/chronology is the
-        // URL
-        $_GET['calendar'] = $matches[1];
+      if (preg_match('/^posted|created/', $tokens[$i] ))
+      {
+        $chronology_tokens = explode('-', $tokens[$i] );
+        $page['chronology']['field'] = $chronology_tokens[0];
+        array_shift($chronology_tokens);
+        $page['chronology']['style'] = $chronology_tokens[0];
+        array_shift($chronology_tokens);
+        if ( count($chronology_tokens)>0 )
+        {
+          if ('list'==$chronology_tokens[0] or
+              'calendar'==$chronology_tokens[0])
+          {
+            $page['chronology']['view'] = $chronology_tokens[0];
+            array_shift($chronology_tokens);
+          }
+          $page['chronology_date'] = $chronology_tokens;
+        }
       }
     }
@@ -220 +232 @@
   $conf['order_by'] = str_replace(
     'ORDER BY ',
-    'ORDER BY '.$orders[ $_COOKIE['pwg_image_order'] ][1].',', 
+    'ORDER BY '.$orders[ $_COOKIE['pwg_image_order'] ][1].',',
     $conf['order_by']
     );
@@ -234 +246 @@
   {
     $result = get_cat_info($page['category']);
-    
+
     $page = array_merge(
       $page,
@@ -247 +259 @@
         'cat_id_uppercat'  => $result['id_uppercat'],
         'uppercats'        => $result['uppercats'],
-        
+
         'title' => get_cat_display_name($result['name'], '', false),
         )
       );
-    
+
     if (!isset($_GET['calendar']))
     {
@@ -262 +274 @@
 ;';
       $page['items'] = array_from_query($query, 'image_id');
-      
+
       $page['thumbnails_include'] =
         $result['nb_images'] > 0
@@ -388 +400 @@
   LIMIT 0, '.$conf['top_number'].'
 ;';
-    
+
     $page = array_merge(
       $page,
@@ -405 +417 @@
     $page['super_order_by'] = true;
     $conf['order_by'] = ' ORDER BY average_rate DESC, id ASC';
-    
+
     $query ='
 SELECT DISTINCT(id)
@@ -437 +449 @@
   '.$conf['order_by'].'
 ;';
-      
+
     $page = array_merge(
       $page,
@@ -447 +459 @@
       );
   }
-  
+
   if (!isset($page['cat_nb_images']))
   {
@@ -458 +470 @@
 // +-----------------------------------------------------------------------+
 
-if (isset($_GET['calendar']))
+if (isset($page['chronology']))
 {
   include_once( PHPWG_ROOT_PATH.'include/functions_calendar.inc.php' );

trunk/picture.php

@@ -64 +64 @@
 if ($page['current_rank'] != $page['first_rank'])
 {
-  // "go to first picture of this section" link is displayed only if the
-  // displayed item is not the first.
-  $template->assign_block_vars(
-    'first',
-    array(
-      'U_IMG' => duplicate_picture_URL(
-        // redefinitions
-        array(
-          'image_id' => $page['items'][ $page['first_rank'] ],
-          ),
-        // removes
-        array()
-        )
-      )
-    );
-
-  // caching previous item : readability purpose
+  // caching first & previous item : readability purpose
   $page['previous_item'] = $page['items'][ $page['current_rank'] - 1 ];
+  $page['first_item'] = $page['items'][ $page['first_rank'] ];
 }
 
 if ($page['current_rank'] != $page['last_rank'])
 {
-  // "go to last picture of this section" link is displayed only if the
-  // displayed item is not the last.
-  $template->assign_block_vars(
-    'last',
-    array(
-      'U_IMG' => duplicate_picture_URL(
-        // redefinitions
-        array(
-          'image_id' => $page['items'][ $page['last_rank'] ],
-          ),
-        // removes
-        array()
-        )
-      )
-    );
-
-  // caching next item : readability purpose
+  // caching next & last item : readability purpose
   $page['next_item'] = $page['items'][ $page['current_rank'] + 1 ];
+  $page['last_item'] = $page['items'][ $page['last_rank'] ];
 }
 
@@ -145 +115 @@
 
       redirect($url_self);
-      
+
       break;
     }
@@ -165 +135 @@
         redirect($url_self);
       }
-      
+
       break;
     }
@@ -179 +149 @@
         pwg_query($query);
       }
-      
+
       redirect($url_self);
-  
+
       break;
     }
@@ -244 +214 @@
 }
 usort($related_categories, 'global_rank_compare');
-//------------------------------------- prev, current & next picture management
+//-------------------------first, prev, current, next & last picture management
 $picture = array();
 
@@ -251 +221 @@
 {
   array_push($ids, $page['previous_item']);
+  array_push($ids, $page['first_item']);
 }
 if (isset($page['next_item']))
 {
   array_push($ids, $page['next_item']);
+  array_push($ids, $page['last_item']);
 }
 
@@ -269 +241 @@
   if (isset($page['previous_item']) and $row['id'] == $page['previous_item'])
   {
-    $i = 'prev';
+    $i = 'previous';
   }
   else if (isset($page['next_item']) and $row['id'] == $page['next_item'])
   {
     $i = 'next';
+  }
+  else if (isset($page['first_item']) and $row['id'] == $page['first_item'])
+  {
+    $i = 'first';
+  }
+  else if (isset($page['last_item']) and $row['id'] == $page['last_item'])
+  {
+    $i = 'last';
   }
   else
@@ -351 +331 @@
       )
     );
+
+  if ('previous'==$i and $page['previous_item']==$page['first_item'])
+  {
+    $picture['first'] = $picture[$i];
+  }
+  if ('next'==$i and $page['next_item']==$page['last_item'])
+  {
+    $picture['last'] = $picture[$i];
+  }
 }
 
@@ -428 +417 @@
 $page['body_id'] = 'thePicturePage';
 //------------------------------------------------------- navigation management
-if (isset($page['previous_item']))
-{
-  $template->assign_block_vars(
-    'previous',
-    array(
-      'TITLE_IMG' => $picture['prev']['name'],
-      'IMG' => $picture['prev']['thumbnail'],
-      'U_IMG' => $picture['prev']['url'],
-      'U_IMG_SRC' => $picture['prev']['src']
-      )
-    );
-}
-
-if (isset($page['next_item']))
-{
-  $template->assign_block_vars(
-    'next',
-    array(
-      'TITLE_IMG' => $picture['next']['name'],
-      'IMG' => $picture['next']['thumbnail'],
-      'U_IMG' => $picture['next']['url'],
-      'U_IMG_SRC' => $picture['next']['src'] // allow navigator to preload
-      )
-    );
+foreach ( array('first','previous','next','last') as $which_image )
+{
+  if (isset($picture[$which_image]))
+  {
+    $template->assign_block_vars(
+      $which_image,
+      array(
+        'TITLE_IMG' => $picture[$which_image]['name'],
+        'IMG' => $picture[$which_image]['thumbnail'],
+        'U_IMG' => $picture[$which_image]['url'],
+        'U_IMG_SRC' => $picture[$which_image]['src']
+        )
+      );
+  }
 }
 
@@ -520 +499 @@
 {
   $uuid = uniqid(rand());
-  
+
   $template->assign_block_vars(
     'high',
@@ -528 +507 @@
       )
     );
-  
+
   $template->assign_block_vars(
     'download',
@@ -572 +551 @@
   $result = pwg_query($query);
   $row = mysql_fetch_array($result);
-  
+
   if ($row['nb_fav'] == 0)
   {
@@ -642 +621 @@
 {
   $val = format_date($picture['current']['date_creation']);
-  $infos['INFO_CREATION_DATE'] = '<a href="'.
-       PHPWG_ROOT_PATH.'category.php?calendar=created-c-'.
-       $picture['current']['date_creation'].'">'.$val.'</a>';
+  $url = make_index_URL(
+          array(
+            'chronology' =>
+              array(
+                'field'=>'created',
+                'style'=>'monthly',
+                'view'=>'list',
+              ),
+             'chronology_date' => explode('-', $picture['current']['date_creation'])
+           )
+         );
+  $infos['INFO_CREATION_DATE'] = '<a href="'.$url.'">'.$val.'</a>';
 }
 else
@@ -653 +641 @@
 // date of availability
 $val = format_date($picture['current']['date_available'], 'mysql_datetime');
-$infos['INFO_POSTED_DATE'] = '<a href="'.
-   PHPWG_ROOT_PATH.'category.php?calendar=posted-c-'.
-   substr($picture['current']['date_available'],0,10).'">'.$val.'</a>';
+$url = make_index_URL(
+        array(
+          'chronology' =>
+            array(
+              'field'=>'posted',
+              'style'=>'monthly',
+              'view'=>'list',
+            ),
+           'chronology_date' => explode('-', substr($picture['current']['date_available'],0,10))
+         )
+       );
+$infos['INFO_POSTED_DATE'] = '<a href="'.$url.'">'.$val.'</a>';
 
 // size in pixels