Changeset 11075

Timestamp:

05/27/11 17:56:35 (2 years ago)

Author:

Mattias

Message:

- image.php
created
- maintain.inc.php:
?> tag added
"desc" changed in "descr" (in a query)
bug commented away in plugin_activate()
(hence the warning for our plugin i guess)
- main.inc.php
added comment
included image.php

Location:

extensions/Copyrights

Files:

• main.inc.php (modified) (4 diffs)
• maintain.inc.php (modified) (4 diffs)

extensions/Copyrights/main.inc.php

@@ -1 +1 @@
 <?php
 /*
-Plugin Name: Copyrights
+Plugin Name: Copyrights_TEST
 Version: Alpha
 Description: Create copyrights and assign them to your photos.
@@ -32 +32 @@
 if (!defined('PHPWG_ROOT_PATH')) die('Hacking attempt!');
 
-define('COPYRIGHTS_PATH',
-    PHPWG_PLUGINS_PATH.basename(dirname(__FILE__)) . '/'); // The plugin path
+define('COPYRIGHTS_PATH', PHPWG_PLUGINS_PATH.basename(dirname(__FILE__)) . '/'); // The plugin path
 define('COPYRIGHTS_WEB_PATH', get_root_url().'admin.php?page=plugin-copyrights');
+// Whats the difference between "COPYRIGHTS_PATH" and "COPYRIGHTS_WEB_PATH" ???
 
 global $prefixeTable;
@@ -42 +42 @@
 include_once(COPYRIGHTS_PATH . 'include/functions.inc.php');
 
-/* Plugin admin */
+
+/* +-----------------------------------------------------------------------+
+ * | Plugin admin                                                          |
+ * +-----------------------------------------------------------------------+ */
+
+
 add_event_handler('get_admin_plugin_menu_links', 'copyrights_admin_menu');
 function copyrights_admin_menu($menu) {
@@ -54 +59 @@
   return $menu;
 }
+
+
+/* +-----------------------------------------------------------------------+
+ * | Plugin image                                                          |
+ * +-----------------------------------------------------------------------+ */
+
+
+//if (script_basename() == 'picture') // Why should i want this "if" here?
+include_once(dirname(__FILE__).'/image.php');
+
+
+/* +-----------------------------------------------------------------------+
+ * | Plugin batchmanager                                                   |
+ * +-----------------------------------------------------------------------+ */
+
+
+// @Johan: Misschien een goed idee om dit ook in een apart php scriptje te zetten, voor de overzichtelijkheid.
+// En om deze reden (Citaat uit de piwigo docs http://piwigo.org/doc/doku.php?id=en:plugins):
+// Code size
+// When PWG loads the plugins, it will include every main.inc.php.
+// Don't put in your main.inc.php 3000 lines of code just to add a page on the administration menu.
+// Split you main.inc.php in several files and feel free to add include_once inside functions defined in main.inc.php as much as you want.
+
 
 // Add copyrights drop down menu to the batch manager

extensions/Copyrights/maintain.inc.php

@@ -29 +29 @@
       name varchar(255) UNIQUE NOT NULL,
       url varchar(255) NOT NULL,
-      desc text DEFAULT NULL,
+      descr text DEFAULT NULL,
       visible bool DEFAULT 0,
       PRIMARY KEY (cr_id)
@@ -46 +46 @@
 
 function plugin_activate() {
-  global $prefixeTable;
+  /*global $prefixeTable;
 
   $query = "
@@ -55 +55 @@
   if (0 == $counter) {
     copyrights_create_default();
-  }
+  }*/
 }
 
@@ -143 +143 @@
   );
 }
+
+?>