Changeset 12747 for branches/2.3/include/functions_user.inc.php

Timestamp:

Dec 16, 2011, 2:52:40 PM (12 years ago)

Author:

plg

Message:

bug 2534 fixed: clean (as clean as possible with MySQL+MyISAM) handle of
concurrency on user cache refresh. No more error when regenerating several
thumbnails at once.

File:

• branches/2.3/include/functions_user.inc.php (modified) (3 diffs)

branches/2.3/include/functions_user.inc.php

@@ -447 +447 @@
       pwg_query($query);
 
+      // Due to concurrency issues, we ask MySQL to ignore errors on
+      // insert. This may happen when cache needs refresh and that Piwigo is
+      // called "very simultaneously".
       mass_inserts
       (
@@ -455 +458 @@
           'date_last', 'max_date_last', 'nb_images', 'count_images', 'count_categories'
         ),
-        $user_cache_cats
+        $user_cache_cats,
+        array('ignore' => true)
       );
 
@@ -465 +469 @@
       pwg_query($query);
 
+      // for the same reason as user_cache_categories, we ignore error on
+      // this insert
       $query = '
-INSERT INTO '.USER_CACHE_TABLE.'
+INSERT IGNORE INTO '.USER_CACHE_TABLE.'
   (user_id, need_update, cache_update_time, forbidden_categories, nb_total_images,
     image_access_type, image_access_list)