Changeset 1288

Timestamp:

Apr 28, 2006, 7:12:25 AM (18 years ago)

Author:

rvelices

Message:

merge -r1287 from branch-1_6 to trunk
bug 349: Nicer display messages instead of "die" when urls cannot be
solved (also set 404 status code for bots)

Location:

trunk

Files:

• category.php (modified) (2 diffs)
• include/functions_category.inc.php (modified) (1 diff)
• include/functions_html.inc.php (modified) (1 diff)
• include/section_init.inc.php (modified) (2 diffs)
• picture.php (modified) (1 diff)

trunk/category.php

@@ -40 +40 @@
     $url_params['section'] = 'categories';
     $url_params['category'] = $_GET['cat'];
+    $result = get_cat_info($url_params['category']);
+    if ( !empty($result) )
+      $url_params['cat_name'] = $result['name'];
   }
   elseif ( in_array($_GET['cat'],
@@ -48 +51 @@
     $url_params['section'] = $_GET['cat'];
   }
+  else
+  {
+    page_not_found('');
+  }
 }
 

trunk/include/functions_category.inc.php

@@ -119 +119 @@
 ;';
   $row = mysql_fetch_array(pwg_query($query));
+  if (empty($row))
+    return null;
 
   $cat = array();

trunk/include/functions_html.inc.php

@@ -592 +592 @@
   }
 }
+
+/**
+ * exits the current script with 404 code when a page cannot be found
+ * @param string msg a message to display
+ * @param string alternate_url redirect to this url
+ */
+function page_not_found($msg, $alternate_url=null)
+{
+  header('HTTP/1.1 404 Not found');
+  header('Status: 404 Not found');
+  if ($alternate_url==null)
+    $alternate_url = make_index_url();
+  redirect( $alternate_url,
+    '<div style="text-align:left; margin-left:5em;margin-bottom:5em;">
+<h1 style="text-align:left; font-size:36px;">Page not found</h1><br/>'
+.$msg.'</div>',
+    5 );
+}
 ?>

trunk/include/section_init.inc.php

@@ -198 +198 @@
   if ( empty($page['tags']) )
   {
-    die('Fatal: no existing tag');
+    page_not_found('Requested tag does not exist', get_root_url().'tags.php' );
   }
 }
@@ -317 +317 @@
   {
     $result = get_cat_info($page['category']);
+    if (empty($result))
+    {
+      page_not_found('Requested category does not exist' );
+    }
 
     $page = array_merge(

trunk/picture.php

@@ -43 +43 @@
 if (!in_array($page['image_id'], $page['items']))
 {
-  die('Fatal: this picture does not belong to this section');
+  page_not_found('The requested image does not belong to this image set',
+      duplicate_index_url() );
 }