Changeset 14143 for trunk/include/derivative.inc.php

Timestamp:

Apr 14, 2012, 6:52:20 AM (12 years ago)

Author:

rvelices

Message:

bug 2615 php notice in calendar amd web service
multisize improve handling of cases where the original is smaller than a requested derivative, but rotation/watermarking is required

File:

• trunk/include/derivative.inc.php (modified) (3 diffs)

trunk/include/derivative.inc.php

@@ -27 +27 @@
   public $id;
   public $rel_path;
+  public $rotation = 0;
 
   private $size=null;
@@ -59 +60 @@
       $height = $infos['height'];
 
+      $this->rotation = intval($infos['rotation']) % 4;
       // 1 or 5 =>  90 clockwise
       // 3 or 7 => 270 clockwise
-      if ($infos['rotation'] % 2 != 0)
+      if ($this->rotation % 2)
       {
         $width = $infos['height'];
@@ -174 +176 @@
     if ( $src->has_size() && $params->is_identity( $src->get_size() ) )
     {
-      // todo - what if we have a watermark maybe return a smaller size?
-      $params = null;
-      $rel_path = $rel_url = $src->rel_path;
-      return;
+      if (!$params->use_watermark && !$src->rotation)
+      {
+        $params = null;
+        $rel_path = $rel_url = $src->rel_path;
+        return;
+      }
+      $defined_types = array_keys(ImageStdParams::get_defined_type_map());
+      for ($i=0; $i<count($defined_types); $i++)
+      {
+        if ($defined_types[$i] == $params->type)
+        {
+          for ($i--; $i>=0; $i--)
+          {
+            $smaller = ImageStdParams::get_by_type($defined_types[$i]);
+            if ($smaller->sizing->max_crop==$params->sizing->max_crop && $smaller->is_identity( $src->get_size() ))
+            {
+              $params = $smaller;
+              self::build($src, $params, $rel_path, $rel_url, $is_cached);
+              return;
+            }
+          }
+          break;
+        }
+      }
     }