Changeset 1733 for trunk/admin/stats.php

Timestamp:

Jan 18, 2007, 10:05:39 AM (17 years ago)

Author:

plg

Message:

Bug fixed: infinite loop in history statistics summary when no data to
display.

File:

• trunk/admin/stats.php (modified) (2 diffs)

trunk/admin/stats.php

@@ -438 +438 @@
 }
 
-if (!isset($min_x) and !isset($max_x))
+if (!isset($min_x) and !isset($max_x) and count($datas) > 0)
 {
   $min_x = min(array_keys($datas));
@@ -444 +444 @@
 }
 
-for ($i = $min_x; $i <= $max_x; $i++)
-{
-  if (!isset($datas[$i]))
-  {
-    $datas[$i] = 0;
-  }
-
-  $url = null;
-
-  if (isset($page['day']))
-  {
-    $value = $i.' '.l10n('hour');
-  }
-  else if (isset($page['month']))
-  {
-    $url =
-      PHPWG_ROOT_PATH.'admin.php'
-      .'?page=stats'
-      .'&amp;year='.$page['year']
-      .'&amp;month='.$page['month']
-      .'&amp;day='.$i
-      ;
-
-    $time = mktime(12, 0, 0, $page['month'], $i, $page['year']);
+if (count($datas) > 0)
+{
+  for ($i = $min_x; $i <= $max_x; $i++)
+  {
+    if (!isset($datas[$i]))
+    {
+      $datas[$i] = 0;
+    }
+  
+    $url = null;
+  
+    if (isset($page['day']))
+    {
+      $value = $i.' '.l10n('hour');
+    }
+    else if (isset($page['month']))
+    {
+      $url =
+        PHPWG_ROOT_PATH.'admin.php'
+        .'?page=stats'
+        .'&amp;year='.$page['year']
+        .'&amp;month='.$page['month']
+        .'&amp;day='.$i
+        ;
+  
+      $time = mktime(12, 0, 0, $page['month'], $i, $page['year']);
+      
+      $value = $i.' ('.$lang['day'][date('w', $time)].')';
+    }
+    else if (isset($page['year']))
+    {
+      $url =
+        PHPWG_ROOT_PATH.'admin.php'
+        .'?page=stats'
+        .'&amp;year='.$page['year']
+        .'&amp;month='.$i
+        ;
+      
+      $value = $lang['month'][$i];
+    }
+    else
+    {
+      // at least the year is defined
+      $url =
+        PHPWG_ROOT_PATH.'admin.php'
+        .'?page=stats'
+        .'&amp;year='.$i
+        ;
+      
+      $value = $i;
+    }
+  
+    if ($datas[$i] != 0 and isset($url))
+    {
+      $value = '<a href="'.$url.'">'.$value.'</a>';
+    }
     
-    $value = $i.' ('.$lang['day'][date('w', $time)].')';
-  }
-  else if (isset($page['year']))
-  {
-    $url =
-      PHPWG_ROOT_PATH.'admin.php'
-      .'?page=stats'
-      .'&amp;year='.$page['year']
-      .'&amp;month='.$i
-      ;
-    
-    $value = $lang['month'][$i];
-  }
-  else
-  {
-    // at least the year is defined
-    $url =
-      PHPWG_ROOT_PATH.'admin.php'
-      .'?page=stats'
-      .'&amp;year='.$i
-      ;
-    
-    $value = $i;
-  }
-
-  if ($datas[$i] != 0 and isset($url))
-  {
-    $value = '<a href="'.$url.'">'.$value.'</a>';
-  }
-  
-  $template->assign_block_vars(
-    'statrow',
-    array(
-      'VALUE' => $value,
-      'PAGES' => $datas[$i],
-      'WIDTH' => ceil(($datas[$i] * $max_width) / $max_pages ),
-      )
-    );
+    $template->assign_block_vars(
+      'statrow',
+      array(
+        'VALUE' => $value,
+        'PAGES' => $datas[$i],
+        'WIDTH' => ceil(($datas[$i] * $max_width) / $max_pages ),
+        )
+      );
+  }
 }