Changeset 17981 for branches/2.4

Timestamp:

Sep 18, 2012, 1:45:51 PM (12 years ago)

Author:

plg

Message:

merge r17424 from trunk to branch 2.4

bug 2716: modifying a photo reset it's rank
modify associate_images_to_categories() and move_images_to_categories() to preserve ranks
please test before 2.4.4 ! :-D

File:

• branches/2.4/admin/include/functions.php (modified) (6 diffs)

branches/2.4/admin/include/functions.php

@@ -1489 +1489 @@
  * Associate a list of images to a list of categories.
  *
- * The function will not duplicate links
+ * The function will not duplicate links and will preserve ranks
  *
  * @param array images
@@ -1502 +1502 @@
     return false;
   }
-
-  $query = '
-DELETE
+  
+  // get existing associations
+  $query = '
+SELECT
+    image_id,
+    category_id
   FROM '.IMAGE_CATEGORY_TABLE.'
   WHERE image_id IN ('.implode(',', $images).')
     AND category_id IN ('.implode(',', $categories).')
 ;';
-  pwg_query($query);
-
+  $result = pwg_query($query);
+  
+  $existing = array();
+  while ($row = pwg_db_fetch_assoc($result))
+  {
+    $existing[ $row['category_id'] ][] = $row['image_id'];
+  }
+
+  // get max rank of each categories
   $query = '
 SELECT
@@ -1527 +1537 @@
     );
 
+  // associate only not already associated images
   $inserts = array();
   foreach ($categories as $category_id)
@@ -1534 +1545 @@
       $current_rank_of[$category_id] = 0;
     }
+    if (!isset($existing[$category_id]))
+    {
+      $existing[$category_id] = array();
+    }
 
     foreach ($images as $image_id)
     {
-      $rank = ++$current_rank_of[$category_id];
-
-      array_push(
-        $inserts,
-        array(
-          'image_id' => $image_id,
-          'category_id' => $category_id,
-          'rank' => $rank,
-          )
-        );
-    }
-  }
-
-  mass_inserts(
-    IMAGE_CATEGORY_TABLE,
-    array_keys($inserts[0]),
-    $inserts
-    );
-
-  update_category($categories);
-}
-
-/**
- * Disssociate images from all categories except their storage category and
+      if (!in_array($image_id, $existing[$category_id]))
+      {
+        $rank = ++$current_rank_of[$category_id];
+
+        array_push(
+          $inserts,
+          array(
+            'image_id' => $image_id,
+            'category_id' => $category_id,
+            'rank' => $rank,
+            )
+          );
+      }
+    }
+  }
+
+  if (count($inserts))
+  {
+    mass_inserts(
+      IMAGE_CATEGORY_TABLE,
+      array_keys($inserts[0]),
+      $inserts
+      );
+
+    update_category($categories);
+  }
+}
+
+/**
+ * Dissociate images from all old categories except their storage category and
  * associate to new categories.
+ *
+ * This function will preserve ranks
  *
  * @param array images
@@ -1574 +1597 @@
   }
 
-  // let's first break links with all albums but their "storage album"
+  // let's first break links with all old albums but their "storage album"
   $query = '
 DELETE '.IMAGE_CATEGORY_TABLE.'.*
@@ -1580 +1603 @@
     JOIN '.IMAGES_TABLE.' ON image_id=id
   WHERE id IN ('.implode(',', $images).')
+    '.((is_array($categories) and count($categories)>0) ? 'AND category_id NOT IN ('.implode(',', $categories).')' : null).'
     AND (storage_category_id IS NULL OR storage_category_id != category_id)
 ;';