Changeset 1852 for trunk/admin/include

Timestamp:

Feb 23, 2007, 2:18:34 PM (17 years ago)

Author:

rvelices

Message:

Plugins:

• display author and and author url (if present) on plugin admin page
• uniformized versions/authors... for all plugins in svn
• security fix (html escape name, version, uri, author... to avoid javascript injection which could automatically simulate click on Install)
• added confirmation for install/uninstall plugins

Web services:

• web service explorer now caches method details in order to avoid unnecessary web calls
• web service explorer can now send parameters as arrays
• web service explorer uses now prototype.js version 1.5
• small improvements

• added and use function bad_request (sends http status code 400)

File:

• trunk/admin/include/functions_plugins.inc.php (modified) (1 diff)

trunk/admin/include/functions_plugins.inc.php

@@ -42 +42 @@
           )
       {
-        $plugin = array('name'=>$file, 'version'=>'0', 'uri'=>'', 'description'=>'');
+        $plugin = array(
+            'name'=>$file,
+            'version'=>'0',
+            'uri'=>'',
+            'description'=>'',
+            'author'=>'',
+          );
         $plg_data = implode( '', file($path.'/main.inc.php') );
 
-        if ( preg_match("|Plugin Name: (.*)|i", $plg_data, $val) )
+        if ( preg_match("|Plugin Name: (.*)|", $plg_data, $val) )
         {
           $plugin['name'] = trim( $val[1] );
         }
-        if (preg_match("|Version: (.*)|i", $plg_data, $val))
+        if (preg_match("|Version: (.*)|", $plg_data, $val))
         {
           $plugin['version'] = trim($val[1]);
         }
-        if ( preg_match("|Plugin URI: (.*)|i", $plg_data, $val) )
+        if ( preg_match("|Plugin URI: (.*)|", $plg_data, $val) )
         {
-          $plugin['uri'] = $val[1];
+          $plugin['uri'] = trim($val[1]);
         }
-        if ( preg_match("|Description: (.*)|i", $plg_data, $val) )
+        if ( preg_match("|Description: (.*)|", $plg_data, $val) )
         {
           $plugin['description'] = trim($val[1]);
         }
+        if ( preg_match("|Author: (.*)|", $plg_data, $val) )
+        {
+          $plugin['author'] = trim($val[1]);
+        }
+        if ( preg_match("|Author URI: (.*)|", $plg_data, $val) )
+        {
+          $plugin['author uri'] = trim($val[1]);
+        }
+        // IMPORTANT SECURITY !
+        $plugin = array_map('htmlspecialchars', $plugin);
         $plugins[$file] = $plugin;
       }