Changeset 23488 for extensions/plugin_lang_analysis

Timestamp:

Jun 24, 2013, 1:23:50 AM (11 years ago)

Author:

mistic100

Message:

display unused strings as useless

Location:

extensions/plugin_lang_analysis

Files:

• admin.php (modified) (1 diff)
• main.inc.php (modified) (1 diff)
• template/analysis.tpl (modified) (3 diffs)

extensions/plugin_lang_analysis/admin.php

@@ -205 +205 @@
   unset($string_data);
   
+  // unused strings
+  $unused = array();
+  foreach ($language_files as $name => $path)
+  {
+    $unused = array_merge($unused, array_diff_key($lang_plugin[ $name ], $strings));
+  }
+  
+  foreach ($unused as $string => $translation)
+  {
+    $string_data = array(
+      'files' => array(),
+      'in_common' => array_key_exists($string, $lang_common),
+      'in_admin' => array_key_exists($string, $lang_admin),
+      'in_plugin' => array(),
+      'stat' => 'useless',
+      'is_admin' => false,
+      'warning' => array(l10n('This string is not used anywhere in the plugin')),
+      );
+      
+    foreach ($language_files as $name => $path)
+    {
+      if (array_key_exists($string, $lang_plugin[$name])) $string_data['in_plugin'][] = $name;
+    }
+    
+    $strings[ $string ] = $string_data;
+  }
+  
   uksort($strings, 'strnatcasecmp'); // natural sort
   $counts['total'] = array_sum($counts);

extensions/plugin_lang_analysis/main.inc.php

@@ -21 +21 @@
 define('PLA_PATH' , PHPWG_PLUGINS_PATH . PLA_ID . '/');
 define('PLA_ADMIN', get_root_url() . 'admin.php?page=plugin-' . PLA_ID);
-define('PLA_DATA', $conf['data_location'] . PLA_ID . '/');
+define('PLA_DATA',  $conf['data_location'] . PLA_ID . '/');
 
 add_event_handler('loc_begin_admin', 'pla_begin_admin');

extensions/plugin_lang_analysis/template/analysis.tpl

@@ -88 +88 @@
       <td>
         {$string|htmlspecialchars}
-        {if isset($data.warnings)}<span class="iconpla-attention-circled tiptip" title="{'<br>'|@implode:$data.warning}"></span>{/if}
+        {if isset($data.warnings)}<span class="iconpla-attention-circled tiptip" title="{'<br>'|@implode:$data.warnings}"></span>{/if}
       </td>
       {if $data.is_admin}<td class="text-admin">{'Admin'|@translate}</td>
@@ -111 +111 @@
         <td></td>
       </tr>
+    {foreachelse}
+      <tr class="file string-{$data.stat} useless">
+        <td></td>
+        <td><i>{'Unused'|@translate}</i></td>
+        {'<td></td>'|str_repeat:(3+$PLA_LANG_FILES|@count)}
+      </tr>
     {/foreach} {* <!-- end file --> *}
   {/foreach} {* <!-- end string --> *}
@@ -119 +125 @@
       <th></th>
       <th>{'%d strings : %d missing and %d useless.'|@translate|sprintf:$PLA_COUNTS.total:$PLA_COUNTS.missing:$PLA_COUNTS.useless}</th>
-      <th></th>
-    {foreach from=$PLA_LANG_FILES item=path key=lang_file}
-      <th></th>
-    {/foreach}
-      <th></th>
-      <th></th>
+      {'<th></th>'|str_repeat:(3+$PLA_LANG_FILES|@count)}
     </tr>
   </tfoot>