Changeset 25018 for trunk/admin/cat_list.php

Timestamp:

Oct 19, 2013, 7:43:04 PM (11 years ago)

Author:

mistic100

Message:

remove all array_push (50% slower than []) + some changes missing for feature:2978

File:

• trunk/admin/cat_list.php (modified) (5 diffs)

trunk/admin/cat_list.php

@@ -79 +79 @@
     }
     
-    array_push($datas, array('id' => $id, 'rank' => $current_rank));
+    $datas[] = array('id' => $id, 'rank' => $current_rank);
   }
   $fields = array('primary' => array('id'), 'update' => array('rank'));
@@ -134 +134 @@
   if (isset($output_create['error']))
   {
-    array_push($page['errors'], $output_create['error']);
+    $page['errors'][] = $output_create['error'];
   }
   else
   {
-    array_push($page['infos'], $output_create['info']);
+    $page['infos'][] = $output_create['info'];
   }
 }
@@ -147 +147 @@
   save_categories_order(array_keys($_POST['catOrd']));
 
-  array_push(
-    $page['infos'],
-    l10n('Album manual order was saved')
-    );
+  $page['infos'][] = l10n('Album manual order was saved');
 }
 else if (isset($_POST['submitAutoOrder']))
@@ -179 +176 @@
   while ($row = pwg_db_fetch_assoc($result))
   {
-    array_push(
-      $categories,
-      array(
-        'id' => $row['id'],
-        'id_uppercat' => $row['id_uppercat'],
-        )
+    $categories[] = array(
+      'id' => $row['id'],
+      'id_uppercat' => $row['id_uppercat'],
       );
-    array_push(
-      $names,
-      $row['name']
-      );
+    $names[] = $row['name'];
   }
 
@@ -200 +191 @@
   save_categories_order($categories);
 
-  array_push(
-    $page['infos'],
-    l10n('Albums automatically sorted')
-    );
+  $page['infos'][] = l10n('Albums automatically sorted');
 }