Changeset 25793

Timestamp:

Dec 5, 2013, 9:53:18 PM (10 years ago)

Author:

rvelices

Message:

fix 1 pixel rounding errors when generating multi size from another multi size

File:

• trunk/i.php (modified) (3 diffs)

trunk/i.php

@@ -285 +285 @@
 {
   global $page;
-  $original_size = null;
-  if (isset($page['original_size']))
-  {
-    $original_size = $page['original_size'];
-    if ($page['rotation_angle']==90 || $page['rotation_angle']==270)
-    {
-      $tmp = $original_size[0];
-      $original_size[0] = $original_size[1];
-      $original_size[1] = $tmp;
-    }
-  }
+  if (!isset($page['original_size']))
+    return false;
+
+  $original_size = $page['original_size'];
+  if ($page['rotation_angle']==90 || $page['rotation_angle']==270)
+  {
+    $tmp = $original_size[0];
+    $original_size[0] = $original_size[1];
+    $original_size[1] = $tmp;
+  }
+  $dsize = $params->compute_final_size($original_size);
 
   $use_watermark = $params->use_watermark;
   if ($use_watermark)
   {
-    if (!isset($original_size))
-      return false; // cannot really know if a watermark is required
-    $dsize = $params->compute_final_size($original_size);
     $use_watermark = $params->will_watermark($dsize);
   }
@@ -315 +312 @@
     if ($candidate->max_width() < $params->max_width() || $candidate->max_height() < $params->max_height())
       continue;
+    $candidate_size = $candidate->compute_final_size($original_size);
+    if ($dsize != $params->compute_final_size($candidate_size))
+      continue;
+
     if ($params->sizing->max_crop==0)
     {
@@ -324 +325 @@
       if ($candidate->sizing->max_crop!=0)
         continue; // this could be optimized
-      if (!isset($original_size))
-        continue;
-      $candidate_size = $candidate->compute_final_size($original_size);
       if ($candidate_size[0] < $params->sizing->min_size[0] || $candidate_size[1] < $params->sizing->min_size[1] )
         continue;