Changeset 2757 for trunk/include/ws_functions.inc.php

Timestamp:

Oct 16, 2008, 2:38:26 AM (16 years ago)

Author:

rvelices

Message:

merge 2755 and 2756 from branch 2.0 to trunk

• 2755 fix vulnerability ​http://www.milw0rm.com/exploits/6755
• 2756 security paranoia: protect session/remember me cookies from XSS attacks (works only if php>=5.2 and with IE/FF maybe others)

File:

• trunk/include/ws_functions.inc.php (modified) (4 diffs)

trunk/include/ws_functions.inc.php

@@ -1188 +1188 @@
 function ws_session_logout($params, &$service)
 {
-  global $user, $conf;
   if (!is_a_guest())
   {
-    $_SESSION = array();
-    session_unset();
-    session_destroy();
-    setcookie(session_name(),'',0,
-        ini_get('session.cookie_path'),
-        ini_get('session.cookie_domain')
-      );
-    setcookie($conf['remember_me_name'], '', 0, cookie_path());
+    logout_user();
   }
   return true;
@@ -1436 +1428 @@
 
   invalidate_user_cache();
-  
+
   return $creation_output;
 }
@@ -1474 +1466 @@
     PREG_SPLIT_NO_EMPTY
     );
-  
+
   $query = '
 SELECT
@@ -1480 +1472 @@
     md5sum
   FROM '.IMAGES_TABLE.'
-  WHERE md5sum IN (\''.implode("','", $md5sums).'\')  
+  WHERE md5sum IN (\''.implode("','", $md5sums).'\')
 ;';
   $id_of_md5 = simple_hash_from_query($query, 'md5sum', 'id');
 
   $result = array();
-  
+
   foreach ($md5sums as $md5sum)
   {