Changeset 2838

Timestamp:

11/07/08 14:54:35 (5 years ago)

Author:

patdenice

Message:

- improve 1.3.1 upgrade (automatic write in mysql.inc.php).
- translate 1.3.1 upgrade informations messages.
- security fix in upgrade login.

Location:

trunk

Files:

• admin/include/functions_upgrade.php (modified) (2 diffs)
• install/upgrade_1.3.1.php (modified) (1 diff)
• language/de_DE/upgrade.lang.php (modified) (1 diff)
• language/en_UK/upgrade.lang.php (modified) (1 diff)
• language/es_ES/upgrade.lang.php (modified) (1 diff)
• language/fr_FR/upgrade.lang.php (modified) (1 diff)
• language/it_IT/upgrade.lang.php (modified) (1 diff)
• language/nl_NL/upgrade.lang.php (modified) (1 diff)

trunk/admin/include/functions_upgrade.php

@@ -137 +137 @@
   global $conf, $page;
 
+  if(!get_magic_quotes_gpc())
+  {
+    $username = mysql_real_escape_string($username);
+  }
+
   if (version_compare($current_release, '1.5.0', '<'))
   {
     $query = '
 SELECT password, status
-FROM '.PREFIX_TABLE.'users
+FROM '.USERS_TABLE.'
 WHERE username = "'.$username.'"
 ;';
@@ -150 +155 @@
 SELECT u.password, ui.status
 FROM '.$conf['users_table'].' AS u
-INNER JOIN '.PREFIX_TABLE.'user_infos AS ui
-ON u.id = ui.user_id
+INNER JOIN '.USER_INFOS_TABLE.' AS ui
+ON u.'.$conf['user_fields']['id'].'=ui.user_id
 WHERE '.$conf['user_fields']['username'].'="'.$username.'"
 ;';

trunk/install/upgrade_1.3.1.php

@@ -579 +579 @@
 }
 
+// load the config file
+$config_file = PHPWG_ROOT_PATH.'include/mysql.inc.php';
+$config_file_contents = @file_get_contents($config_file);
+if ($config_file_contents === false)
+{
+  die('CANNOT LOAD '.$config_file);
+}
+$php_end_tag = strrpos($config_file_contents, '?'.'>');
+if ($php_end_tag === false)
+{
+  die('CANNOT FIND PHP END TAG IN '.$config_file);
+}
+if (!is_writable($config_file))
+{
+  die('FILE NOT WRITABLE '.$config_file);
+}
+
+// Insert define('PHPWG_INSTALLED', true); in mysql.inc.php
+$config_file_contents =
+    substr($config_file_contents, 0, $php_end_tag).'
+define(\'PHPWG_INSTALLED\', true);
+'.substr($config_file_contents, $php_end_tag);
+
+$fp = @fopen( $config_file, 'w' );
+@fputs($fp, $config_file_contents, strlen($config_file_contents));
+@fclose($fp);
+
+// Send infos
 $page['infos'] = array_merge(
   $page['infos'],
   array(
-    'all sub-categories of private categories become private',
-
-    'user permissions and group permissions have been erased',
-
-    'only thumbnails prefix and webmaster mail address have been saved from
-previous configuration',
-
-    'in include/mysql.inc.php, before
-<pre style="background-color:lightgray">?&gt;</pre>
-insert
-<pre style="background-color:lightgray">define(\'PHPWG_INSTALLED\', true);</pre>'
+    l10n('all sub-categories of private categories become private'),
+    l10n('user permissions and group permissions have been erased'),
+    l10n('only thumbnails prefix and webmaster mail saved')
     )
   );
-
 
 // now we upgrade from 1.4.0

trunk/language/de_DE/upgrade.lang.php

@@ -38 +38 @@
 $lang['You do not have access rights to run upgrade'] = 'You do not have access rights to run upgrade';
 
+// Upgrade informations from upgrade_1.3.1.php
+$lang['all sub-categories of private categories become private'] = 'All sub-categories of private categories become private';
+$lang['user permissions and group permissions have been erased'] = 'User permissions and group permissions have been erased';
+$lang['only thumbnails prefix and webmaster mail saved'] = 'Only thumbnails prefix and webmaster mail address have been saved from previous configuration';
+
 ?>

trunk/language/en_UK/upgrade.lang.php

@@ -37 +37 @@
 $lang['You do not have access rights to run upgrade'] = 'You do not have access rights to run upgrade';
 
+// Upgrade infoformations from upgrade_1.3.1.php
+$lang['all sub-categories of private categories become private'] = 'All sub-categories of private categories become private';
+$lang['user permissions and group permissions have been erased'] = 'User permissions and group permissions have been erased';
+$lang['only thumbnails prefix and webmaster mail saved'] = 'Only thumbnails prefix and webmaster mail address have been saved from previous configuration';
+
 ?>

trunk/language/es_ES/upgrade.lang.php

@@ -37 +37 @@
 /*TODO*/$lang['You do not have access rights to run upgrade'] = 'You do not have access rights to run upgrade';
 
+// Upgrade informations from upgrade_1.3.1.php
+/*TODO*/$lang['all sub-categories of private categories become private'] = 'All sub-categories of private categories become private';
+/*TODO*/$lang['user permissions and group permissions have been erased'] = 'User permissions and group permissions have been erased';
+/*TODO*/$lang['only thumbnails prefix and webmaster mail saved'] = 'Only thumbnails prefix and webmaster mail address have been saved from previous configuration';
+
 ?>

trunk/language/fr_FR/upgrade.lang.php

@@ -38 +38 @@
 $lang['You do not have access rights to run upgrade'] = 'Vous n\'avez pas les droits necessaires pour lancer la mise à jour.';
 
+// Upgrade informations from upgrade_1.3.1.php
+$lang['all sub-categories of private categories become private'] = 'Toutes les sous-catégories de catégories privées deviennent privées';
+$lang['user permissions and group permissions have been erased'] = 'Les permissions des utilisateurs et des groupes ont été effacées';
+$lang['only thumbnails prefix and webmaster mail saved'] = 'Seuls le préfixe des miniatures et l\'adresse email du webmestre ont étés sauvegardés de la configuration précédente';
+
 ?>

trunk/language/it_IT/upgrade.lang.php

@@ -39 +39 @@
 $lang['You do not have access rights to run upgrade'] = 'You do not have access rights to run upgrade';
 
+// Upgrade infoformations from upgrade_1.3.1.php
+$lang['all sub-categories of private categories become private'] = 'All sub-categories of private categories become private';
+$lang['user permissions and group permissions have been erased'] = 'User permissions and group permissions have been erased';
+$lang['only thumbnails prefix and webmaster mail saved'] = 'Only thumbnails prefix and webmaster mail address have been saved from previous configuration';
+
 ?>

trunk/language/nl_NL/upgrade.lang.php

@@ -39 +39 @@
 $lang['You do not have access rights to run upgrade'] = 'You do not have access rights to run upgrade';
 
+// Upgrade infoformations from upgrade_1.3.1.php
+$lang['all sub-categories of private categories become private'] = 'All sub-categories of private categories become private';
+$lang['user permissions and group permissions have been erased'] = 'User permissions and group permissions have been erased';
+$lang['only thumbnails prefix and webmaster mail saved'] = 'Only thumbnails prefix and webmaster mail address have been saved from previous configuration';
+
 ?>