Changeset 28459

Timestamp:

May 13, 2014, 10:09:04 PM (10 years ago)

Author:

rvelices

Message:

bug 3056: quick search - cache results for 5 minutes + comments + small fix

Location:

trunk

Files:

• admin/batch_manager.php (modified) (1 diff)
• include/functions_search.inc.php (modified) (5 diffs)

trunk/admin/batch_manager.php

@@ -395 +395 @@
 {
   include_once( PHPWG_ROOT_PATH .'include/functions_search.inc.php' );
-  $res = get_quick_search_results($_SESSION['bulk_manager_filter']['search']['q'], array('permissions'=>false));
+  $res = get_quick_search_results_no_cache($_SESSION['bulk_manager_filter']['search']['q'], array('permissions'=>false));
   $filter_sets[] = $res['items'];
 }

trunk/include/functions_search.inc.php

@@ -266 +266 @@
 define('QST_BREAK',          0x20);
 
+/**
+ * A search scope applies to a single token and restricts the search to a subset of searchable fields.
+ */
 class QSearchScope
 {
@@ -604 +607 @@
               break;
             }
-            if (strlen($crt_token) && isdigit(substr($crt_token,0,-1)) 
-              && $qi+1<strlen($q) && isdigit($q[$qi+1]))
+            if (strlen($crt_token) && preg_match('/[0-9]/', substr($crt_token,-1)) 
+              && $qi+1<strlen($q) && preg_match('/[0-9]/', $q[$qi+1]))
             {// dot between digits is not a separator e.g. F2.8
               $crt_token .= $ch;
@@ -704 +707 @@
   }
 
+  /**
+  * Applies recursively a search scope to all sub single tokens. We allow 'tag:(John Bill)' but we cannot evaluate 
+  * scopes on expressions so we rewrite as '(tag:John tag:Bill)'
+  */
   private function apply_scope(QSearchScope $scope)
   {
@@ -1062 +1069 @@
 }
 
+
 /**
  * Returns the search results corresponding to a quick/query search.
@@ -1083 +1091 @@
 function get_quick_search_results($q, $options)
 {
+  global $persistent_cache, $conf, $user;
+
+  $cache_key = $persistent_cache->make_key( array(
+    strtolower($q),
+    $conf['order_by'],
+    $user['id'],$user['cache_update_time'], 
+    isset($options['permissions']) ? (boolean)$options['permissions'] : true,
+    isset($options['images_where']) ? $options['images_where'] : '',
+    ) );
+  if ($persistent_cache->get($cache_key, $res))
+  {
+    return $res;
+  }
+
+  $res = get_quick_search_results_no_cache($q, $options);
+
+  $persistent_cache->set($cache_key, $res, 300);
+  return $res;
+}
+
+/**
+ * @see get_quick_search_results but without result caching
+ */
+function get_quick_search_results_no_cache($q, $options)
+{
   global $conf;
   //@TODO: maybe cache for 10 minutes the result set to avoid many expensive sql calls when navigating the pictures