Changeset 28992 for trunk

Timestamp:

Jul 7, 2014, 10:39:29 PM (10 years ago)

Author:

rvelices

Message:

bug 3056 quick search - small fixes & improvements

• scopes are case insesitive date:2013 and Date:2013 are the same thing
• use strict comparison in scopes when required e.g. date:<2013 is not matching year 2013
• allow scopes (in plugins) to overwrite behaviour of space characters ...

File:

• trunk/include/functions_search.inc.php (modified) (12 diffs)

trunk/include/functions_search.inc.php

@@ -296 +296 @@
     return true;
   }
+  
+  function process_char(&$ch, &$crt_token)
+  {
+    return false;
+  }
 }
 
@@ -310 +315 @@
   {
     $str = $token->term;
+    $strict = array(0,0);
     if ( ($pos = strpos($str, '..')) !== false)
       $range = array( substr($str,0,$pos), substr($str, $pos+2));
     elseif ('>' == @$str[0])// ratio:>1
+    {
       $range = array( substr($str,1), '');
+      $strict[0] = 1;
+    }
     elseif ('<' == @$str[0]) // size:<5mp
+    {
       $range = array('', substr($str,1));
+      $strict[1] = 1;
+    }
     elseif( ($token->modifier & QST_WILDCARD_BEGIN) )
       $range = array('', $str);
@@ -350 +362 @@
       if (is_numeric($val))
       {
-        if ($i)
+        if ($i ^ $strict[$i])
           $val += $this->epsilon;
         else
@@ -359 +371 @@
     if (!$this->nullable && $range[0]=='' && $range[1] == '')
       return false;
-    $token->scope_data = $range;
+    $token->scope_data = array( 'range'=>$range, 'strict'=>$strict );
     return true;
   }
@@ -366 +378 @@
   {
     $clauses = array();
-    if ($token->scope_data[0]!=='')
-      $clauses[] = $field.' >= ' .$token->scope_data[0].' ';
-    if ($token->scope_data[1]!=='')
-      $clauses[] = $field.' <= ' .$token->scope_data[1].' ';
+    if ($token->scope_data['range'][0]!=='')
+      $clauses[] = $field.' >'.($token->scope_data['strict'][0]?'':'=').$token->scope_data['range'][0].' ';
+    if ($token->scope_data['range'][1]!=='')
+      $clauses[] = $field.' <'.($token->scope_data['strict'][1]?'':'=').$token->scope_data['range'][1].' ';
 
     if (empty($clauses))
@@ -393 +405 @@
   {
     $str = $token->term;
+    $strict = array(0,0);
     if ( ($pos = strpos($str, '..')) !== false)
       $range = array( substr($str,0,$pos), substr($str, $pos+2));
     elseif ('>' == @$str[0])
+    {
       $range = array( substr($str,1), '');
+      $strict[0] = 1;
+    }
     elseif ('<' == @$str[0])
+    {
       $range = array('', substr($str,1));
+      $strict[1] = 1;
+    }
     elseif( ($token->modifier & QST_WILDCARD_BEGIN) )
       $range = array('', $str);
@@ -412 +431 @@
         array_shift($matches);
         if (!isset($matches[1]))
-          $matches[1] = !$i ? 1 : 12;
+          $matches[1] = ($i ^ $strict[$i]) ? 12 : 1;
         if (!isset($matches[2]))
-          $matches[2] = !$i ? 1 : 31;
-        $val = $matches;
+          $matches[2] = ($i ^ $strict[$i]) ? 31 : 1;
+        $val = implode('-', $matches);
+        if ($i ^ $strict[$i])
+          $val .= ' 23:59:59';
       }
       elseif (strlen($val))
@@ -432 +453 @@
     $clauses = array();
     if ($token->scope_data[0]!=='')
-      $clauses[] = $field.' >= \'' . implode('-',$token->scope_data[0]).'\'';
+      $clauses[] = $field.' >= \'' . $token->scope_data[0].'\'';
     if ($token->scope_data[1]!=='')
-      $clauses[] = $field.' <= \'' . implode('-',$token->scope_data[1]).' 23:59:59\'';
+      $clauses[] = $field.' <= \'' . $token->scope_data[1].'\'';
 
     if (empty($clauses))
@@ -579 +600 @@
             break;
           case ':':
-            $scope = @$root->scopes[$crt_token];
+            $scope = @$root->scopes[strtolower($crt_token)];
             if (!isset($scope) || isset($crt_scope))
             { // white space
@@ -621 +642 @@
             // else white space go on..
           default:
-            if (strpos(' ,.;!?', $ch)!==false)
-            { // white space
-              $this->push($crt_token, $crt_modifier, $crt_scope);
+            if (!$crt_scope || !$crt_scope->process_char($ch, $crt_token))
+            {
+              if (strpos(' ,.;!?', $ch)!==false)
+              { // white space
+                $this->push($crt_token, $crt_modifier, $crt_scope);
+              }
+              else
+                $crt_token .= $ch;
             }
-            else
-              $crt_token .= $ch;
             break;
         }
@@ -1118 +1142 @@
   $res = get_quick_search_results_no_cache($q, $options);
 
-  $persistent_cache->set($cache_key, $res, 300);
+  if ( count($res['items']) )
+  {// cache the results only if not empty - otherwise it is useless
+    $persistent_cache->set($cache_key, $res, 300);
+  }
   return $res;
 }
@@ -1128 +1155 @@
 {
   global $conf;
-  //@TODO: maybe cache for 10 minutes the result set to avoid many expensive sql calls when navigating the pictures
+
   $q = trim(stripslashes($q));
   $search_results =