Changeset 29074

Timestamp:

Jul 25, 2014, 11:10:49 AM (10 years ago)

Author:

plg

Message:

bug 3104: less rights for admins (compared to webmaster). Now an admin can't:

• delete a webmaster
• give webmaster/admin status to any user
• change status of a webmaster/admin

Location:

trunk

Files:

• admin/themes/default/template/user_list.tpl (modified) (2 diffs)
• admin/user_list.php (modified) (2 diffs)
• include/ws_functions/pwg.users.php (modified) (2 diffs)

trunk/admin/themes/default/template/user_list.tpl

@@ -34 +34 @@
   'true':"{'Yes'|translate}",
   'false':"{'No'|translate}",
+};
+
+var statusLabels = {
+{foreach from=$label_of_status key=status item=label}
+  '{$status}' : '{$label|escape:javascript}',
+{/foreach}
 };
 {/footer_script}
@@ -261 +267 @@
           user.email = user.email || '';
           
-          jQuery("#action select[name=status] option").each(function() {
-            if (user.status == jQuery(this).val()) {
-              user.statusLabel = jQuery(this).html();
-            }
-          });
+          user.statusLabel = statusLabels[user.status];
           
                       /* Render the underscore template */

trunk/admin/user_list.php

@@ -100 +100 @@
   );
 
+// an admin can't delete other admin/webmaster
+if ('admin' == $user['status'])
+{
+  $query = '
+SELECT
+    user_id
+  FROM '.USER_INFOS_TABLE.'
+  WHERE status IN (\'webmaster\', \'admin\')
+;';
+  $protected_users = array_merge($protected_users, query2array($query, null, 'user_id'));
+}
+
 $template->assign(
   array(
@@ -118 +130 @@
 foreach (get_enums(USER_INFOS_TABLE, 'status') as $status)
 {
-  // Only status <= can be assign
-  if (is_autorize_status(get_access_type_status($status)))
-  {
-    $pref_status_options[$status] = l10n('user_status_'.$status);
-  }
+  $label_of_status[$status] = l10n('user_status_'.$status);
 }
+
+$pref_status_options = $label_of_status;
+
+// a simple "admin" can set/remove statuses webmaster/admin
+if ('admin' == $user['status'])
+{
+  unset($pref_status_options['webmaster']);
+  unset($pref_status_options['admin']);
+}
+
+$template->assign('label_of_status', $label_of_status);
 $template->assign('pref_status_options', $pref_status_options);
 $template->assign('pref_status_selected', 'normal');

trunk/include/ws_functions/pwg.users.php

@@ -326 +326 @@
   include_once(PHPWG_ROOT_PATH.'admin/include/functions.php');
 
+  $protected_users = array(
+    $user['id'],
+    $conf['guest_id'],
+    $conf['default_user_id'],
+    $conf['webmaster_id'],
+    );
+
+  // an admin can't delete other admin/webmaster
+  if ('admin' == $user['status'])
+  {
+    $query = '
+SELECT
+    user_id
+  FROM '.USER_INFOS_TABLE.'
+  WHERE status IN (\'webmaster\', \'admin\')
+;';
+    $protected_users = array_merge($protected_users, query2array($query, null, 'user_id'));
+  }
+  
   // protect some users
-  $params['user_id'] = array_diff(
-    $params['user_id'],
-    array(
-      $user['id'],
-      $conf['guest_id'],
-      $conf['default_user_id'],
-      $conf['webmaster_id'],
-      )
-    );
-
+  $params['user_id'] = array_diff($params['user_id'], $protected_users);
+
+  $counter = 0;
+  
   foreach ($params['user_id'] as $user_id)
   {
     delete_user($user_id);
+    $counter++;
   }
 
   return l10n_dec(
     '%d user deleted', '%d users deleted',
-    count($params['user_id'])
+    $counter
     );
 }
@@ -419 +433 @@
   if (!empty($params['status']))
   {
-    if ( $params['status'] == 'webmaster' and !is_webmaster() )
-    {
-      return new PwgError(403, 'Only webmasters can grant "webmaster" status');
-    }
+    if (in_array($params['status'], array('webmaster', 'admin')) and !is_webmaster() )
+    {
+      return new PwgError(403, 'Only webmasters can grant "webmaster/admin" status');
+    }
+    
     if ( !in_array($params['status'], array('guest','generic','normal','admin','webmaster')) )
     {
       return new PwgError(WS_ERR_INVALID_PARAM, 'Invalid status');
+    }
+
+    $protected_users = array(
+      $user['id'],
+      $conf['guest_id'],
+      $conf['webmaster_id'],
+      );
+
+    // an admin can't change status of other admin/webmaster
+    if ('admin' == $user['status'])
+    {
+      $query = '
+SELECT
+    user_id
+  FROM '.USER_INFOS_TABLE.'
+  WHERE status IN (\'webmaster\', \'admin\')
+;';
+      $protected_users = array_merge($protected_users, query2array($query, null, 'user_id'));
     }
 
     // status update query is separated from the rest as not applying to the same
     // set of users (current, guest and webmaster can't be changed)
-    $params['user_id_for_status'] = array_diff(
-      $params['user_id'],
-      array(
-        $user['id'],
-        $conf['guest_id'],
-        $conf['webmaster_id'],
-        )
-      );
+    $params['user_id_for_status'] = array_diff($params['user_id'], $protected_users);
 
     $update_status = $params['status'];