Changeset 3372 for extensions/pLoader

Timestamp:

May 30, 2009, 10:48:30 AM (15 years ago)

Author:

ronosman

Message:

Refactor context menu item initialization.

File:

• extensions/pLoader/trunk/src/Uploader/GUI/wxFrameAUI.pm (modified) (10 diffs)

extensions/pLoader/trunk/src/Uploader/GUI/wxFrameAUI.pm

@@ -24 +24 @@
 use Wx::DND;
 use Wx qw/
+             wxITEM_NORMAL
              wxNullBitmap
              wxID_OK
@@ -340 +341 @@
           perspective
           current_imageviewer_index
+          imageviewer_mnu
+          tree_mnu
       /;
 __PACKAGE__->mk_accessors( @properties );
@@ -456 +459 @@
     $self->_set_setting_properties;
     $self->_initFrame;
-    $self->_InitEventHandlers;
+    $self->_initMenus;
+    $self->_initEventHandlers;
     $self->_initImgTypes;   
 
@@ -1293 +1297 @@
 
 
-
-sub _InitEventHandlers {
+sub _initMenus {
+    my ( $self ) = @_ ;
+
+    $self->_tree_mnu;
+    $self->_imageviewer_mnu;    
+}
+
+
+sub _tree_mnu {
+    my ( $self ) = @_;  
+
+    my $ctx_mnu = Wx::Menu->new;
+    
+    map {
+        $ctx_mnu->Append(
+            @$_[0..2], wxITEM_NORMAL
+        )->SetBitmap(Wx::Bitmap->new($_->[3],wxBITMAP_TYPE_PNG));
+    }
+    (
+        # workaround : first item does not show bitmap
+        [
+            0, 
+            "",
+            "",
+            '../res/mnu_folder_new.png',
+        ],
+        [
+            1+$ID_TREE_CTX_MENU, 
+            wxTheApp->branding->{'Add new category'},
+            sprintf(
+                "%s %s %s %s", 
+                gettext("Add a new"), 
+                wxTheApp->branding->{category},
+                gettext("to the currently selected"),
+                wxTheApp->branding->{category},
+            ),
+            '../res/mnu_folder_new.png',
+        ],
+        [
+            2+$ID_TREE_CTX_MENU, 
+            "Refresh",
+            sprintf(
+                "Refresh %s list.",
+                wxTheApp->branding->{category},
+            ),
+            '../res/mnu_refresh.png',
+        ],
+    );
+
+    $ctx_mnu->Delete(0);
+    $self->tree_mnu(
+         $ctx_mnu
+    );  
+}       
+
+sub _imageviewer_mnu {
+    my ( $self ) = @_;  
+
+    my $ctx_mnu = Wx::Menu->new;
+    
+    map {
+        $ctx_mnu->Append(
+            @$_[0..2]
+        )->SetBitmap(Wx::Bitmap->new($_->[3],wxBITMAP_TYPE_PNG));
+    }
+    (
+        # workaround : first item does not show bitmap
+        [
+            0, 
+            "",
+            "",
+            '../res/mnu_properties.png',
+        ],
+        [
+            1+$ID_IMAGEVIEWER_CTX_MENU, 
+            gettext("Properties"),
+            gettext("Modify photo properties"),
+            '../res/mnu_properties.png',
+        ],
+        [
+            2+$ID_IMAGEVIEWER_CTX_MENU, 
+            gettext("Preview"),
+            gettext("Display photo preview"),
+            '../res/mnu_preview.png',
+        ],
+    );
+        
+    $ctx_mnu->Delete(0);
+    $self->imageviewer_mnu(
+         $ctx_mnu
+    );  
+}
+
+sub _initEventHandlers {
     my ( $self ) = @_ ;
         
@@ -1304 +1400 @@
     Wx::Event::EVT_MENU( $self, 105, \&OnChooseLanguage );
     EVT_TREE_SEL_CHANGED( $self, $self->tree, \&OnTreeSelChanged );
-    EVT_TREE_ITEM_RIGHT_CLICK( $self->tree, $self->tree, \&OnTreeItemRightClick );
+    EVT_TREE_ITEM_RIGHT_CLICK( $self, $self->tree, \&OnTreeItemRightClick );
 
     EVT_LIST_END_LABEL_EDIT( $self, $self->imageviewer, \&OnImageViewerEndLabelEdit );
@@ -1363 +1459 @@
         }
     }
+
 }
 
@@ -1371 +1468 @@
     $self->imagelist->RemoveImageSelection;
     $self->imageviewer->Refresh;        
+
 }
 
@@ -1422 +1520 @@
     my( $self, $event ) = @_;
 
-    my $point = $event->GetPoint ;
-    my $ctx_mnu = Wx::Menu->new;
-    
-    map {
-        $ctx_mnu->Append(
-            @$_[0..2]
-        )->SetBitmap(Wx::Bitmap->new($_->[3],wxBITMAP_TYPE_PNG));
-    }
-    (
-        [
-            1+$ID_TREE_CTX_MENU, 
-            wxTheApp->branding->{'Add new category'},
-            sprintf(
-                "%s %s %s %s", 
-                gettext("Add a new"), 
-                wxTheApp->branding->{category},
-                gettext("to the currently selected"),
-                wxTheApp->branding->{category},
-            ),
-            '../res/mnu_folder_new.png',
-        ],
-        [
-            2+$ID_TREE_CTX_MENU, 
-            "Refresh",
-            sprintf(
-                "Refresh %s list.",
-                wxTheApp->branding->{category},
-            ),
-            '../res/mnu_refresh.png',
-        ],
-    );
-
-    $self->PopupMenu($ctx_mnu, wxDefaultPosition);
+
+    $self->PopupMenu($self->tree_mnu, wxDefaultPosition);
         
 }
@@ -1462 +1529 @@
     my( $self, $event ) = @_;
 
-    my $point = $event->GetPoint ;
-    my $ctx_mnu = Wx::Menu->new;
-    
-    map {
-        $ctx_mnu->Append(
-            @$_[0..2]
-        )->SetBitmap(Wx::Bitmap->new($_->[3],wxBITMAP_TYPE_PNG));
-    }
-    (
-        [
-            1+$ID_IMAGEVIEWER_CTX_MENU, 
-            gettext("Properties"),
-            gettext("Modify photo properties"),
-            '../res/mnu_properties.png',
-        ],
-        [
-            2+$ID_IMAGEVIEWER_CTX_MENU, 
-            gettext("Preview"),
-            gettext("Display photo preview"),
-            '../res/mnu_preview.png',
-        ],
-    );
-    
-    $self->PopupMenu($ctx_mnu, wxDefaultPosition);
+    
+    $self->PopupMenu($self->imageviewer_mnu, wxDefaultPosition);
         
         
@@ -1607 +1652 @@
     if(WXK_DELETE == $event->GetKeyCode){
         $self->OnRemoveImages();
+        
+        my $index = $self->current_imageviewer_index < $self->imageviewer->GetItemCount ?
+            $self->current_imageviewer_index : $self->current_imageviewer_index -1 ;
         $self->imageviewer->SelectItem(
-            $self->current_imageviewer_index
+            $index
         );
     }