Changeset 4221 for extensions/event_cats

Timestamp:

Nov 6, 2009, 2:13:30 PM (14 years ago)

Author:

LucMorizur

Message:

[Event Cats] Add comments

File:

• extensions/event_cats/include/evntcats_admin_funcs.inc.php (modified) (8 diffs)

extensions/event_cats/include/evntcats_admin_funcs.inc.php

@@ -219 +219 @@
   switch ($_POST['ec_act1']) {
     
+    // This "switch" command is a little bit tricky... it has been a pain to
+    // debug, and I wish to nobody to have to modify it :-\ !
+    // Its principle is that it manages checks for four occurrences of
+    // $_POST['ec_act1'] : 'create', 'modify_entry_submit',
+    // 'duplicate_entry_submit', and 'toggle_forced'. Some checks are mutual
+    // between different occurences, but never all checks of each occurrence
+    // of $_POST['ec_act1']. So tests are done with "if" statements to
+    // produce "break" statements when needed.
+    
     case 'create':
       
+      // Stops if given code or user type are incorrect
       if (
         !isset($_POST['ec_in_up_code']) or
@@ -240 +250 @@
     case 'modify_entry_submit':
       
+      // First checks for user type and/or value
       if (isset($_POST['ec_sel_user'])) {
         if ($_POST['ec_sel_user'] == 'new') {
@@ -264 +275 @@
     case 'duplicate_entry_submit':
       
+      // Checks of entry value validity
       if (
         !isset($_POST['ec_entry_sel']) or
@@ -269 +281 @@
       ) return ec_end1('ec_entry_sel', 'ec_bad_argument5');
       
+      // Other checks for user type and value
       if ($_POST['ec_act1'] == 'modify_entry_submit') if (
         !isset($_POST['ec_sel_user']) or (
@@ -282 +295 @@
     case 'toggle_forced':
       
+      // Establish default values for unchanged values
       $ec_code    = $ec_lists['ec_table'][$_POST['ec_entry_sel']]['code'];
       if ($action == 'ec_ok' and $ec_user_id == 'NULL')
@@ -306 +320 @@
     }
       
+      // Final check for entry value
       build_ec_duplicable_codes();
       if (!array_key_exists($_POST['ec_entry_sel'],
@@ -314 +329 @@
     default: ec_end1('ec_act1', 'ec_bad_argument1');
   }
+  // Pfew !
   
   if ($_POST['ec_act1'] != 'toggle_forced') {
@@ -430 +446 @@
     }
     else {
-      build_ec_lists();
+      build_ec_lists(); // Don't remember exactly why, but must be done here
       $forced = ($forced == 'false') ? '' : l10n('ec_cnfrm_forced');
       $page['infos'][] =