Changeset 5654

Timestamp:

04/05/10 00:50:12 (3 years ago)

Author:

plg

Message:

bug 1579: admins should see all user comments on picture.php, validated or not.

Files:

• trunk/include/picture_comment.inc.php (modified) (2 diffs)

trunk/include/picture_comment.inc.php

@@ -89 +89 @@
 if ($page['show_comments'])
 {
+  if ( !is_admin() )
+  {
+    $validated_clause = '  AND validated = \'true\'';
+  }
+  else
+  {
+    $validated_clause = '';
+  }
+
   // number of comments for this picture
   $query = '
-SELECT COUNT(*) AS nb_comments
+SELECT
+    COUNT(*) AS nb_comments
   FROM '.COMMENTS_TABLE.'
-  WHERE image_id='.$page['image_id']." AND validated = 'true'";
+  WHERE image_id = '.$page['image_id']
+  .$validated_clause.'
+;';
   $row = pwg_db_fetch_assoc( pwg_query( $query ) );
 
@@ -119 +131 @@
   if ($row['nb_comments'] > 0)
   {
-    if ( !is_admin() )
-    {
-      $validated_clause = '  AND validated = \'true\'';
-    }
-    else
-    {
-      $validated_clause = '';
-    }
-
     $query = '
-SELECT com.id,author,author_id,'.$conf['user_fields']['username'].' AS username,
-  date,image_id,content,validated
+SELECT
+    com.id,
+    author,
+    author_id,
+    '.$conf['user_fields']['username'].' AS username,
+    date,
+    image_id,
+    content,
+    validated
   FROM '.COMMENTS_TABLE.' AS com
   LEFT JOIN '.USERS_TABLE.' AS u
     ON u.'.$conf['user_fields']['id'].' = author_id
-  WHERE image_id = '.$page['image_id'].
-$validated_clause.'
+  WHERE image_id = '.$page['image_id'].'
+    '.$validated_clause.'
   ORDER BY date ASC
   LIMIT '.$conf['nb_comment_page'].' OFFSET '.$page['start'].'