Changeset 5985

Timestamp:

Apr 28, 2010, 6:11:07 PM (14 years ago)

Author:

plg

Message:

bug 860: display a more readable error when the _data directory is not writable

Location:

trunk/include

Files:

• functions_html.inc.php (modified) (2 diffs)
• template.class.php (modified) (1 diff)

trunk/include/functions_html.inc.php

@@ -362 +362 @@
  * @param string msg a message to display
  */
-function fatal_error($msg)
-{
+function fatal_error($msg, $title=null, $show_trace=true)
+{
+  if (empty($title))
+  {
+    $title = 'Piwigo encountered a non recoverable error';
+  }
+  
   $btrace_msg = '';
-  if (function_exists('debug_backtrace'))
+  if ($show_trace and function_exists('debug_backtrace'))
   {
     $bt = debug_backtrace();
@@ -378 +383 @@
 
   $display = "<meta http-equiv='Content-Type' content='text/html; charset=utf-8'>
-<h1>Piwigo encountered a non recoverable error</h1>
+<h1>$title</h1>
 <pre style='font-size:larger;background:white;color:red;padding:1em;margin:0;clear:both;display:block;width:auto;height:auto;overflow:auto'>
 <b>$msg</b>

trunk/include/template.class.php

@@ -53 +53 @@
     $this->smarty->force_compile = $conf['template_force_compile'];
 
+    if (!is_writable($conf['local_data_dir']))
+    {
+      load_language('admin.lang');
+      fatal_error(
+        sprintf(
+          l10n('Give write access (chmod 777) to "%s" directory at the root of your Piwigo installation'),
+          basename($conf['local_data_dir'])
+          ),
+        l10n('an error happened'),
+        false // show trace
+        );
+    }
     $compile_dir = $conf['local_data_dir'].'/templates_c';
     mkgetdir( $compile_dir );