Changeset 9583 for extensions/community/include/functions_community.inc.php

Timestamp:

Mar 9, 2011, 2:06:10 PM (13 years ago)

Author:

plg

Message:

bug fixed: invalidate_user_cache now also invalidates community user
permissions cache

bug fixed: community permissions cache was not refreshed when user connects,
I have added $_SESSIONcommunity_user_id to make sure the permissions are
related to the correct user

change: use a random key for cache update to avoid "in the same second
refresh".

filter the list of parent albums for "create a new album" based on permissions
even when create_whole_gallery is true

File:

• extensions/community/include/functions_community.inc.php (modified) (3 diffs)

extensions/community/include/functions_community.inc.php

@@ -26 +26 @@
   global $conf, $user;
 
-  if (!isset($conf['community_update']))
-  {
-    conf_update_param('community_update', time());
-  }
-  
-  if (isset($_SESSION['community_user_permissions']))
-  {
-    if ($_SESSION['community_update'] > $conf['community_update'])
-    {
-      return $_SESSION['community_user_permissions'];
-    }
+  $cache_key = community_get_cache_key();
+  if (!isset($cache_key))
+  {
+    $cache_key = community_update_cache_key();
+  }
+
+  // I (plg) don't understand why, but when you connect, you keep the
+  // permissions calculated for the "guest" : the session is "inheritated"
+  // from guest to the connected user, so I add a
+  // $_SESSION['community_user_id'] to force refresh if the permissions were
+  // not calculated for the right user
+  if (
+    isset($_SESSION['community_user_id'])
+    and $_SESSION['community_user_id'] == $user_id
+    and $_SESSION['community_cache_key'] == $cache_key
+    )
+  {
+    return $_SESSION['community_user_permissions'];
   }
 
@@ -199 +206 @@
 
   $_SESSION['community_user_permissions'] = $return;
-  $_SESSION['community_update'] = time();
+  $_SESSION['community_cache_key'] = $cache_key;
+  $_SESSION['community_user_id'] = $user_id;
 
   return $_SESSION['community_user_permissions'];
@@ -242 +250 @@
 }
 
+function community_update_cache_key()
+{
+  $cache_key = generate_key(20);
+  conf_update_param('community_cache_key', $cache_key);
+  return $cache_key;
+}
+
+function community_get_cache_key()
+{
+  global $conf;
+
+  if (isset($conf['community_cache_key']))
+  {
+    return $conf['community_cache_key'];
+  }
+  else
+  {
+    return null;
+  }
+}
 ?>