Changeset 9919 for extensions/jiwigo-ws-api/src/main/java/fr/mael/jiwigo/service/impl/CommentServiceImpl.java

Timestamp:

Mar 29, 2011, 8:21:25 PM (13 years ago)

Author:

mlg

Message:

Complete rewriting of the api
The api now uses interfaces everywhere (for the dao, services and session manager). This allows the developer to use his own implementations if he wants.
Deletion of the singletons. There are now getters and setters. It allows to make dependency injection.
Use of sl4j in the api, instead of using log4j.

Location:

extensions/jiwigo-ws-api/src/main/java/fr/mael/jiwigo/service/impl

Files:

• . (added)
• CommentServiceImpl.java (copied) (copied from extensions/jiwigo-ws-api/src/main/java/fr/mael/jiwigo/service/CommentService.java) (4 diffs)

extensions/jiwigo-ws-api/src/main/java/fr/mael/jiwigo/service/impl/CommentServiceImpl.java

@@ -1 @@
-package fr.mael.jiwigo.service;
+package fr.mael.jiwigo.service.impl;
 
 import java.io.IOException;
 import java.util.List;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 import fr.mael.jiwigo.dao.CommentDao;
 import fr.mael.jiwigo.om.Comment;
+import fr.mael.jiwigo.service.CommentService;
 import fr.mael.jiwigo.transverse.exception.ProxyAuthenticationException;
-import fr.mael.jiwigo.transverse.session.SessionManager;
 
 /*
@@ -25 +28 @@
  *
  */
-public class CommentService {
+public class CommentServiceImpl implements CommentService {
     /**
      * Logger
      */
-    public static final org.apache.commons.logging.Log LOG = org.apache.commons.logging.LogFactory
-            .getLog(CommentService.class);
+    private final Logger LOG = LoggerFactory.getLogger(CommentServiceImpl.class);
 
-    /**
-     * singleton
-     */
-    private static CommentService instance;
-
-    private SessionManager sessionManager;
-
-    /**
-     * @return the singleton
-     */
-    public static CommentService getInstance(SessionManager sessionManager) {
-        if (instance == null) {
-            instance = new CommentService(sessionManager);
-        }
-        return instance;
-    }
-
-    /**
-     * private constructor, to use a singleton
-     */
-    private CommentService(SessionManager sessionManager) {
-        this.sessionManager = sessionManager;
-    }
+    private CommentDao dao;
 
     /**
@@ -64 +44 @@
      */
     public List<Comment> list(Integer imageId) throws IOException, ProxyAuthenticationException {
-        return CommentDao.getInstance(sessionManager).list(imageId);
+        return dao.list(imageId);
     }
 
@@ -82 +62 @@
         comment.setImageId(imageId);
         comment.setAuthor(auteur);
-        return CommentDao.getInstance(sessionManager).create(comment);
+        return dao.create(comment);
+    }
+
+    public CommentDao getDao() {
+        return dao;
+    }
+
+    public void setDao(CommentDao dao) {
+        this.dao = dao;
     }