Gijs wrote:

Aha!

Thanks for the patch!

vi  maintain.inc.php and then

:%s/\"/\'/g

does the same :-). I tried that... however, this brings me to a new error


Parse error: syntax error, unexpected T_STRING in plugins/LocalFilesEditor/maintain.inc.php on line 30


in spostgresql-8.3-main.log : I *also* keep seeing this. I expect it is a similar type or related.

CEST STATEMENT: 
        SELECT id AS id,username AS username
        FROM piwigo_users
          ORDER BY CONVERT(username,CHAR)

I should learn to read more closely. It is VERY warm, maybe that counts as an excuse. I overlooked the
escape \ in front of the '.

:%s/\"/\\\'/g  would have done it..

It works now.

The

CEST STATEMENT: 
        SELECT id AS id,username AS username
        FROM piwigo_users
          ORDER BY CONVERT(username,CHAR)


however remains..

Gijs wrote:

Ah! Thanks. What can I do to fix this error locally? Replace some or all " by '  in files in /plugins/LocalFilesEditor?

If you can read and apply a diff file, here it comes :

index 35aca4b..0f1d31e 100644
--- a/plugins/LocalFilesEditor/maintain.inc.php
+++ b/plugins/LocalFilesEditor/maintain.inc.php
@@ -27,7 +27,7 @@ function plugin_install()
 
   $query = '
 INSERT INTO ' . CONFIG_TABLE . ' (param,value,comment)
-VALUES ("LocalFilesEditor" , "off" , "LocalFiles Editor plugin parameters");';
+VALUES (\'LocalFilesEditor\' , \'off\' , \'LocalFiles Editor plugin parameters\');';
 
   pwg_query($query);
 }
@@ -36,7 +36,7 @@ function plugin_uninstall()
 {
   global $prefixeTable;
 
-  $query = 'DELETE FROM ' . CONFIG_TABLE . ' WHERE param="LocalFilesEditor" LIMIT 1;';
+  $query = 'DELETE FROM ' . CONFIG_TABLE . ' WHERE param=\'LocalFilesEditor\' LIMIT 1;';
   pwg_query($query);
 }

Don't forget that apply that kind of patch prevents you to automatically upgrade to future releases.

Gijs wrote:

I could be posting this in the wrong thread. But this is one of the errors I get, when trying to install the local files plugin. Have not been able to find the bug ..

Warning: pg_query() [function.pg-query]: Query failed: ERROR: column "LocalFilesEditor" does not exist LINE 3: VALUES ("LocalFilesEditor" , "off" , "LocalFiles Editor plug... ^ in /(path) include/dblayer/functions_pgsql.inc.php on line 122
INSERT INTO piwigo_config (param,value,comment) VALUES ("LocalFilesEditor" , "off" , "LocalFiles Editor plugin parameters");
ERROR: column "LocalFilesEditor" does not exist LINE 3: VALUES ("LocalFilesEditor" , "off" , "LocalFiles Editor plug... ^

It's not related to AS keyword but it's also a PostgreSQL issue. PostgreSQL and SQLite (and probably others database engines) wanted fields values to enclosed by single quotes and not double ones. The error reads strange because PostgreSQL engine thinks "LocalFilesEditor" is a field and not a value. double quotes are use for fields to protect reserved words like "count" or things like that.

I created the new [Bugtracker] bug 1755 Feel free to do it yourself next time.

nicolas wrote:

Gijs wrote:

I will not move to 8.4 soon.. But I am slowly including all AS where needed..

I think it will hapen soon because next release (9.0) comes !

Not that hung up on following the latest. I use postgresql for more than just piwigo. Not keen on migrating all databases at this point in time.

Gijs wrote:

I'm guessing:

SELECT t.*, count(*) counter
SELECT t.*, count(*) AS counter

is the next one..

Il open a ticket in our bug tracker : [Bugtracker] bug 1754. Don't hesitate to post queries here after if I forgot somes !

Hi Nicolas!

Thanks for this.

so far I have added 'AS' in a few places. Did not keep a record, but will start doing that now.

these are the files I've edited so far:

config_default.inc.php
include/functions_user.inc.php
include/functions_notification.inc.php
include/functions_tag.inc.php

I'm running into loads more errors, with tags, with rss feed, with adding photo's .... I'll try and keep more detailed notes. I hoped a few quick edits would suffice, but ..

I will not move to 8.4 soon.. But I am slowly including all AS where needed..

I'm guessing:

SELECT t.*, count(*) counter
SELECT t.*, count(*) AS counter

is the next one..

Kult wrote:

nicolas wrote:

I cannot reproduce the problem. Can you help me to find it. When did you have the problem ?

During the installation process. I've set up all fields [Basic configuration, Database configuration, Admin configuration] click on the [Start Installation] button and I get this error.

I also try the query in psql and I also get the same error, until I place the AS keyword.

It seems that AS keyword is optionnal since release 8.4 and I used release 8.4.4.  So two solutions :

1) add the AS keyword in all queries where it's needed
2) change PostgreSQL required version to 8.4

I think the first one is the better one.

trying to make hay of the error message: notice this:

piwigo_categories as c LEFT JOIN piwigo

should that not be

piwigo_categories **AS** c LEFT JOIN piwigo



The docs of postgresql 8.3 seem to suggest SELECT can use aliases.

nicolas wrote:

I cannot reproduce the problem. Can you help me to find it. When did you have the problem ?

During the installation process. I've set up all fields [Basic configuration, Database configuration, Admin configuration] click on the [Start Installation] button and I get this error.

I also try the query in psql and I also get the same error, until I place the AS keyword.