Post A Reply

Zaphod: 2012-05-04 21:03:17

Thanks, that's perfect.
So I will be able to switch to piwigo 2.4 as soon at is released.

rvelices: 2012-05-04 11:42:09

Zaphod wrote:
plg wrote:
I hope we'll have time to re-implement the "follow orientation" feature from 2.3 to 2.4.
Any new for this?
Even if it's not implemented in the interface, currently it's not possible at all... even with something like:
Code:
{define_derivative name='derivative_params' width=160 height=90 crop=true}
in a template...

Code:

{define_derivative name='derivative_params' width=144 height=144 crop=true min_width=108 min_height=108}

Zaphod: 2012-05-03 22:33:56

plg wrote:
I hope we'll have time to re-implement the "follow orientation" feature from 2.3 to 2.4.

Any new for this?
Even if it's not implemented in the interface, currently it's not possible at all... even with something like:

Code:

{define_derivative name='derivative_params' width=160 height=90 crop=true}

in a template...

plg: 2012-05-03 22:17:13

Zaphod wrote:
I still have a "multiple size" screen like it was before, in addition to the "options / photo sizes".
Is this normal?

I get the following errors:
Code:
Notice: Undefined property: DerivativeParams::$quality in /homepages/(...)/betatest/admin/derivatives.php

Screen [Administration > Configuration > Multiple Size] will be removed before 2.4.0

plg: 2012-05-03 22:16:18

If I find the time before 2.4.0 (or right after, that's not blocking), I'll change the text field for sharpen/quality into a slider http://jqueryui.com/demos/slider/#steps this will avoid any mistake by users.

Zaphod: 2012-05-02 23:18:01

I still have a "multiple size" screen like it was before, in addition to the "options / photo sizes".
Is this normal?

I get the following errors:

Code:

Notice: Undefined property: DerivativeParams::$quality in /homepages/(...)/betatest/admin/derivatives.php

plg: 2012-05-02 00:01:09

ddtddt is OK. You can add $lang['Sharpen'].

plg: 2012-05-01 10:36:04

rvelices wrote:
Can we say errors are human and we add it now ? (I would really like to use this param)

I've asked ddtddt.

rvelices: 2012-04-30 19:10:55

plg wrote:
The only problem I see is that we have no "Sharpen" language key and it's too late to add one :-/

Can we say errors are human and we add it now ? (I would really like to use this param)

plg: 2012-04-30 18:17:24

Yes, it is planned to remove the original configuration screen. I used it to check my dev was OK.

I'm perfectly OK with the changes you propose. The only problem I see is that we have no "Sharpen" language key and it's too late to add one :-/

rvelices: 2012-04-30 17:17:11

- I don't know if you plan to remove the original "dev" multi size config screen, but if it's the case, is it ok to add the sharpen param in the new screen (it works well now with the imagick extension on recently upgraded piwigo.org) ?

- Before we release 2.4 is it ok to make the jpeg quality a global parameter in the code as it is in the new screen ?

plg: 2012-04-20 22:52:39

You know what's cool? I've found this in common.lang.php: $lang['Reset to default values'] (used on profile.php)

rvelices: 2012-04-20 09:02:38

plg wrote:
Either I code the "restore" for original size, or I move the button to the "Multiple Size" fieldset. What do you think is better?

Move the button

plg: 2012-04-19 22:58:26

rvelices, thanks for [Subversion] r14228

Either I code the "restore" for original size, or I move the button to the "Multiple Size" fieldset. What do you think is better?

plg: 2012-04-19 18:36:23

rvelices wrote:
plg wrote:
I think that one thing is really missing: the ability to restore default settings. The problem is that we can't add any other language key now. We have "restore" but not "restore default settings". rvelices, would you like to add a link "restore" + "javascript:are you sure?" in the Multiple Size fieldset?
I'll do something about it, but I'll let you handle the original size fieldset.

Great! I was not thinking about restoring default settings on the original size, but only about multiple size (something like clear_derivative_cache(); + conf_update_param('derivatives', ''); I suppose but I prefer you to it cleanly)

rvelices wrote:
Also note that if someone combines the usage of the two screens, the cache might not be correctly cleared because of watermark usage changes ...

I'll ask you to check again once the new Watermark screen is implemented :-)

Piwigo.org

Announcement

Topic review (newest first)

Zaphod wrote:

plg wrote:

Code:

Code:

plg wrote:

Code:

Zaphod wrote:

Code:

Code:

rvelices wrote:

plg wrote:

plg wrote:

rvelices wrote:

plg wrote:

rvelices wrote:

Board footer