hello
just to say at my first lecture my state of mind : it's a revolution ! I feel seduce by changing the way of using template and theme because of the over-complexicity of the current structure, but also a little scared of the management of the template. It's late and I have not thought about it deeply.
It will be easier for the theme manager ^^

Last edited by flop25 (2010-03-11 23:21:32)

To clarify:

1 - Template-extension
2 - Local-layout
3 - Themeconf.inc.php changes
4 - CSS consequences

5 - Impacts on migration

I have no idea on each point currently.
What will happen to 2.1 delivery?
Does that mean it will be postponed for a medium size period of release candidate?

I need to understand all of these events.

VDigital wrote:

1 - Template-extension

I wonder if it's really necessary to have template-extension + theme inheritance at the same time. It fills the same function, it may confuse users.

But we can keep template-extension the way they are today and decide later about theme.

VDigital wrote:

2 - Local-layout

There are several local-layout:
./template/yoga/local-layout.css
./template-common/local-layout.css

Adding a local theme is easier to understand in my opinion.

3 - Themeconf.inc.php changes

Sylvia/themeconf.inc.php before:

<?php
$themeconf = array(
  'template' => 'yoga',
  'theme' => 'Sylvia',
  'icon_dir' => 'template/yoga/theme/Sylvia/icon',
  'admin_icon_dir' => 'template/yoga/icon/admin',
  'mime_icon_dir' => 'template/yoga/theme/Sylvia/icon/mimetypes/',
  'local_head' => '
<!--[if IE]> 
        <link rel="stylesheet" href="template/yoga/theme/Sylvia/theme-ie.css" type="text/css">
<![endif]-->
  ',
);
?>

Sylvia/themeconf.inc.php after:

<?php
$themeconf = array(
  'theme'         => 'Sylvia',
  'parent'        => 'default',
  'icon_dir'      => 'theme/Sylvia/icon',
  'mime_icon_dir' => 'theme/Sylvia/icon/mimetypes/',
);
?>

+ Sylvia/local_head.tpl :

<!--[if IE]> 
        <link rel="stylesheet" href="{$ROOT_URL}theme/Sylvia/theme-ie.css" type="text/css">
<![endif]-->

4 - CSS consequences

None I think. P@t will confirm.

5 - Impacts on migration

All existing themes will need to be reorganized for compatibility. But it's not a really hard task compared to the improvement. Considering the low number of existing themes, no probleme for me to help theme creators for new organization.

What will happen to 2.1 delivery?

What do you mean?

Does that mean it will be postponed for a medium size period of release candidate?

No real change. This new architecture will save time on the theme manager creation (+ piwigo.org/ext adaptation)

plg wrote:

... to avoid the "10 ways to do the same thing" effect.

+1

I think it's a good idea if we can simplified the structure Piwigo

This can allow the release of more theme

I also had a short reply by grum (gally template developer, among other things)

grum wrote:

I read the forum topic very quickly this morning. Impacts are not that small, but without searching more deeply I have difficulties to see the consequences. The better is to commit now, then once done, it will be easier to see what may be wrong.

In the worst case, if the solution doesn't fit, we can also go back to the previous state.

really great ! (you already know that I am an adept of the KISS principle ;-)).