Announcement

  •  » Engine
  •  » Spread Menus in the core ?

#1 2011-05-01 23:47:20

mistic100
Former Piwigo Team
Lyon (FR)
2008-09-27
3271

Spread Menus in the core ?

I remember the first thing I done when I installed phpWebGallery (1.7) for the first time is to modify the core files (I don't know plugins yet ^^) to add the menu on all pages, except the picture page.

I don't know for what historical reason there is no menu on profile, search, comment.... pages, but I think it must be changed.
I don't see technical or navigation reason to not display the menu, moreover I think it's surprising for new user to see the menu disappear in a page it won't.

So what I purpose is to add the menu in all pages, and in the picture page only by a parameter (disabled by default)

Offline

 

#2 2011-05-02 07:11:42

LucMorizur
Member
Vienne (Isère) - France
2009-04-30
168

Re: Spread Menus in the core ?

I remember something has been done, at least on picture pages. VDigital participated, with the help of Tosca.


Our gallery : Le Site à Nous (a silly name in french, but here I don't care ;-) ! )
An event, a new gallery ? Plugin Event Cats
My test gallery : Tests Piwigo de Luc
Thanksalot for this beautiful project.

Offline

 

#3 2011-05-02 10:25:21

flop25
Piwigo Team
2006-07-06
6918

Re: Spread Menus in the core ?

see Spreamenu or hr_glass_xl theme for examples of what have been already done

In fact, I asked to Vdigital for an universel call for template var : a way to load in template any variable like the menubar or thumbnails ... he asked he was thinking of that but -as you know- he's no more on Piwigo

I agree it's a problem if the user can't see the menu on simple page as about, search etc but in the picture page it's different for vertical menu, but "displayable" for horizontal menu. And also think to plugin pages which may want to have the menu : like download multi shows the menu but that induce an error with my theme adding the menu (it seems that a if ( function_exists( 'initialize_menu') ) has no effect ). That's why a way to call the menu without redondance and just a short code could be good.


To get a better help : Politeness like Hello-A link-Your past actions precisely described
Check my extensions : more than 30 available
who I am and what I do : http://fr.gravatar.com/flop25
My gallery : an illustration of how to integrate Piwigo in your website

Offline

 

#4 2011-05-02 12:07:20

rvelices
Piwigo Team
2005-12-29
1960

Re: Spread Menus in the core ?

mistic100 wrote:

I don't know for what historical reason there is no menu on profile, search, comment.... pages, but I think it must be changed.
I don't see technical or navigation reason to not display the menu, moreover I think it's surprising for new user to see the menu disappear in a page it won't.

So what I purpose is to add the menu in all pages, and in the picture page only by a parameter (disabled by default)

Honestly I prefer the way it is today. I don't want a menu on the picture page because I want the photo to take all place ...

Offline

 

#5 2011-05-02 12:08:18

mistic100
Former Piwigo Team
Lyon (FR)
2008-09-27
3271

Re: Spread Menus in the core ?

me too, that's why a purpose a parameter for the picture page

Offline

 

#6 2011-05-06 14:05:12

mistic100
Former Piwigo Team
Lyon (FR)
2008-09-27
3271

Re: Spread Menus in the core ?

any opinion ?
Pierrick ? ^^

Offline

 

#7 2011-05-06 14:45:40

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13182

Re: Spread Menus in the core ?

As soon as the menu is hidden by default on picture.php, I would say it's a good idea.

Have you thought about the impact on non-core themes? (it would be good to have no real impact on themes/plugins for Piwigo 2.3, I mean nothing to change on them)


Latest blog post (November 9th 2018) Why Flickr could not remain free for ever

Online

 

#8 2011-05-06 15:03:54

mistic100
Former Piwigo Team
Lyon (FR)
2008-09-27
3271

Re: Spread Menus in the core ?

I will try ;)

Offline

 

#9 2011-05-06 18:31:40

mistic100
Former Piwigo Team
Lyon (FR)
2008-09-27
3271

Re: Spread Menus in the core ?

so at the moment I've tested to add the menu on all page except picture.php
here are the problems encountered :

Luciano Amodio, GBO_hk-3 (_clear), MoeWP minor css correction needed
OS_* must delete the included code from SpreadMenus
Simple, Stripped, Gally* no bug but template files could be modified to include the javascript menu

all others themes work fine :D
now I will look at the picture page, harder I think for non-default themes....

Last edited by mistic100 (2011-05-07 12:19:53)

Offline

 

#10 2011-05-07 12:19:02

mistic100
Former Piwigo Team
Lyon (FR)
2008-09-27
3271

Re: Spread Menus in the core ?

For the picture page :

BlancMont XL, GBO*, MontBlancXL, MoeWP, Sakura BW : minor css change needed
Gally, Luciano, OS*, Simple*, Sobre, Stripped : work but can add the menu

there is still a problem of floating for the comment layer, I'm solving it ;)

Offline

 

#11 2011-05-07 15:54:08

flop25
Piwigo Team
2006-07-06
6918

Re: Spread Menus in the core ?

as you seen hr_* and OS_* themes already have the menu initialize. It's ok I'll delete it, but I suggest you an idea :
use the themeconf to exclude page for displaying the menu, as I already did in hr_* and OS_*. The core theme may also have a config page to set this themeconf variable according to the wish of the user.


PS : don't forget the popup help page : that's why I think an exclude variable should be great

Last edited by flop25 (2011-05-07 16:01:55)


To get a better help : Politeness like Hello-A link-Your past actions precisely described
Check my extensions : more than 30 available
who I am and what I do : http://fr.gravatar.com/flop25
My gallery : an illustration of how to integrate Piwigo in your website

Offline

 

#12 2011-05-07 16:02:49

mistic100
Former Piwigo Team
Lyon (FR)
2008-09-27
3271

Re: Spread Menus in the core ?

use the themeconf to exclude page for displaying the menu, as I already did in hr_* and OS_*

will take a look

"there is still a problem of floating for the comment layer" what's the problem ?

thumnails are in float, menubar too, so the clear:both on hr.seperation breaks one or other float ^^

but this is solved with [Subversion] r10804

note : this commit just ask for a little change on OS_default :
on the picture_nav_buttons template delete (or change) ids lines 23 and 29 (I haven't see any difference without them)

Offline

 

#13 2011-05-07 16:16:28

flop25
Piwigo Team
2006-07-06
6918

Re: Spread Menus in the core ?

mistic100 wrote:

note : this commit just ask for a little change on OS_default :
on the picture_nav_buttons template delete (or change) ids lines 23 and 29 (I haven't see any difference without them)

ok thx ! it's marked as todo


To get a better help : Politeness like Hello-A link-Your past actions precisely described
Check my extensions : more than 30 available
who I am and what I do : http://fr.gravatar.com/flop25
My gallery : an illustration of how to integrate Piwigo in your website

Offline

 

#14 2011-05-07 16:59:31

mistic100
Former Piwigo Team
Lyon (FR)
2008-09-27
3271

Re: Spread Menus in the core ?

I've a problem with theme configuration feature :
if the menu is not displayed there is a 20em white space near the content block, because the css is not changed

I think to move the css property to template files

Code:

{if isset($MENUBAR)}
<style>.content { margin-left:20em; }</style>
{/if}

but with this method, if a theme change the wisth of the menu, it must redeclare the template... too bad !

how to preceed ?

Offline

 

#15 2011-05-07 17:02:33

flop25
Piwigo Team
2006-07-06
6918

Re: Spread Menus in the core ?

by using localhead of default ?


To get a better help : Politeness like Hello-A link-Your past actions precisely described
Check my extensions : more than 30 available
who I am and what I do : http://fr.gravatar.com/flop25
My gallery : an illustration of how to integrate Piwigo in your website

Offline

 
  •  » Engine
  •  » Spread Menus in the core ?

Board footer

Powered by FluxBB

github twitter facebook google+ newsletter Donate Piwigo.org © 2002-2019 · Contact