Hello,

I finally got time to provide the patch, http://piwigo.org/bugs/view.php?id=2943

Using the last git source code for VideoJS.

Add the following in your config
$conf['show_exif_fields'] = array(
  'Make',
  'Model',
  'ExifVersion',
  'Software',
  'DateTimeOriginal',
  'FNumber',
  'ExposureBiasValue',
  'FILE;FileSize',
  'ExposureTime',
  'Flash',
  'ISOSpeedRatings',
  'FocalLength',
  'FocalLengthIn35mmFilm',
  'WhiteBalance',
  'ExposureMode',
  'MeteringMode',
  'ExposureProgram',
  'LightSource',
  'Contrast',
  'Saturation',
  'Sharpness',
  'bitrate',
  'channel',
  'date_creation',
  'display_aspect_ratio',
  'duration',
  'filesize',
  'format',
  'frame_rate',
  'latitude',
  'longitude',
  'make',
  'model',
  'playtime_seconds',
  'sampling_rate',
  'type',
  );

Patch include/functions_metadata.inc.php as follow, a single line change.

# diff ../../include/functions_metadata.inc.php ../../include/functions_metadata.inc.php.bck
153c153
< if ($exif = @read_exif_data($filename) or $exif = trigger_change('format_exif_data', $exif=array(), $filename, $map))
---
> if ($exif = @read_exif_data($filename))


And now you can see the video Metadata using VideoJS.

What do you think?
Would it be possible to get this change include in the next release?

Would be nice to get some feedback.
The patch allow any plugin to display metadata as EXIF.
I believe it can be useful for GPX tacks or Videos or any non EXIF file.

rvelices wrote:

-it should be a different event name than the current one (which would be called 2 times)

I do agree it was my original commit.
I did create a new trigger and send the new file, http://piwigo.org/bugs/view.php?id=2943
In order to reduce the change, I used the same trigger and it avoid code duplication.

rvelices wrote:

-default should be null instead of empty array (otherwise the test in the line afterwards is useless I think)

Good point I will also update my code, to exit on non null $exif.

# diff ../../include/functions_metadata.inc.php ../../include/functions_metadata.inc.php.bck
153c153
< if ($exif = @read_exif_data($filename) or $exif = trigger_change('format_exif_data', $exif=null, $filename, $map))
---
> if ($exif = @read_exif_data($filename))

What about:

[pierrick@pierrick-desktop] ~/public_html/piwigo/dev/trunk
$ svn diff include/functions_metadata.inc.php 
Index: include/functions_metadata.inc.php
===================================================================
--- include/functions_metadata.inc.php  (revision 30766)
+++ include/functions_metadata.inc.php  (working copy)
@@ -150,9 +150,16 @@
   }
 
   // Read EXIF data
-  if ($exif = @read_exif_data($filename))
+  if ($exif = @read_exif_data($filename) or $exif2 = trigger_change('format_exif_data', $exif=null, $filename, $map))
   {
-    $exif = trigger_change('format_exif_data', $exif, $filename, $map);
+    if (!empty($exif2))
+    {
+      $exif = $exif2;
+    }
+    else
+    {
+      $exif = trigger_change('format_exif_data', $exif, $filename, $map);
+    }
 
     // configured fields
     foreach ($map as $key => $field)

This way we don't call trigger_change twice.

I have tried with [extension by maple] EXIF View and it works fine.

Looks good

Excellent!

Hi
my Galaxy S4 has no Recorded_Date in the meta information of the video files. I have to add the following lines in include/mediainfo.php, Row 126:

if (isset($general->Encoded_Date))
{
    $exif['date_creation'] = date( 'Y-m-d H:i:s', strtotime((string)$general->Encoded_Date));
}

With this, my videos has now also a creation date, one of the most important meta information for me.

Maybe you add these lines to the plugin also.

Best regards
Steve