Announcement

#1 2015-10-31 15:34:07

erAck
Piwigo Team
2015-09-06
232

tag_url_style=tag fails on numeric tags

Hi,

I have

$conf['tag_url_style'] = 'tag';

in my local config, which generally works, but fails on numeric tags where it falls back to id-tag, for example instead of "2015"  the tag "88-2015" is in the underlying URL. I wouldn't mind that much if clicking such would actually lead to the group of images tagged with "2015", but instead it gives "Page not found" and then redirects to the tags.php page. I reckon that probably the id is prefixed because of an alleged ambiguity of numeric tag name and numeric tag id, but then it should actually work.. Note that removing the "id-" part from the URL so that only the actual numeric tag is left works fine and the corresponding tagged images are displayed. Maybe until I reach 2015 tags ;-P

Piwigo version: 2.7.4
PHP: 5.6.9
MySQL: 5.5.44

Thanks for investigating :)


Running Piwigo at https://erack.net/gallery/

Offline

 

#2 2015-10-31 15:42:47

mistic100
Former Piwigo Team
Lyon (FR)
2008-09-27
3271

Re: tag_url_style=tag fails on numeric tags

thank you for pointing out this bug

can you submit it on https://github.com/Piwigo/Piwigo ?

Offline

 

#3 2015-10-31 17:02:54

erAck
Piwigo Team
2015-09-06
232

Re: tag_url_style=tag fails on numeric tags

Done, [Github] Piwigo issue #367
and issued a pull request with a fix that works for me, but see commit message, https://github.com/Piwigo/Piwigo/pull/368


Running Piwigo at https://erack.net/gallery/

Offline

 

#4 2015-11-11 12:35:33

erAck
Piwigo Team
2015-09-06
232

Re: tag_url_style=tag fails on numeric tags

I closed that pull request and created a new one with a change that doesn't work around the numeric id-tag result but instead doesn't create one, I encountered no problem so far. https://github.com/Piwigo/Piwigo/pull/371


Running Piwigo at https://erack.net/gallery/

Offline

 

#5 2015-12-10 19:15:23

erAck
Piwigo Team
2015-09-06
232

Re: tag_url_style=tag fails on numeric tags

erAck wrote:

https://github.com/Piwigo/Piwigo/pull/371

Not interested in that pull request? It's still lingering around. And still works for me ;)


Running Piwigo at https://erack.net/gallery/

Offline

 

Board footer

Powered by FluxBB

github twitter facebook google+ newsletter Donate Piwigo.org © 2002-2019 · Contact