Piwigo.org

windracer · 2017-06-07 22:15:03

I'm writing a plugin that moves photos between physical albums, preserving the metadata. I've got the basics working: when editing a photo (or video) that's already in a physical album, select the new Move tab, pick a target physical album, click Move:

The file on disk is moved from the source directory to the target and the IMAGES_TABLE and IMAGE_CATEGORY_TABLE tables are updated accordingly. This preserves all the tags, description, etc. etc.

What I'm trying to figure out now is how to manage the thumbnails, specifically:

- clean up the thumbnails left behind for the image's original location
- create thumbnails for the image's new location (I know the new thumbnails will be auto-generated when the photo is accessed for the first time, but ideally I'd create those as part of the move)

Poking around in the Piwigo functions (like the uploader), I found delete_element_derivatives. Would this handle the thumbnails (-cu, -me, -sq, -th, etc.)? If so, would it also handle the pwg_representatives (i.e., thumbnails for videos created by videojs)?

Any suggestions on how to properly handle this or the creation of the new thumbnails?

Right now the plugin only works on a single photo but I'd like to eventually add it to Batch Manager as well ... maybe version 2.0. :)

Thanks!

Piwigo version: 2.9.0
PHP version: 7.0.18-0ubuntu0.17.04.1
MySQL version: 5.7.18-0ubuntu0.17.04.1

Last edited by windracer (2017-06-07 22:15:46)

flop25 · 2017-06-08 10:49:16

Hello
delete_element_derivatives is removing only the generated resized pictures (-cu, -me, -sq, -th, etc.) by default all

for the representative, you could move it with the original object (representative_ext original_to_representative( $path, $infos['representative_ext']) ) ; you could also move the derivative since the tree is the same as the physical one, and avoid the issue of recreating it

eliz82 · 2017-06-08 17:38:18

great plugin, if you make it work with batch manager i will use it

windracer · 2017-06-08 17:52:04

flop25 wrote:
Hello
delete_element_derivatives is removing only the generated resized pictures (-cu, -me, -sq, -th, etc.) by default all

Thanks for the confirmation. I'll use that to remove the thumbnails/resizes from the source directory.

flop25 wrote:
for the representative, you could move it with the original object (representative_ext original_to_representative( $path, $infos['representative_ext']) ) ; you could also move the derivative since the tree is the same as the physical one, and avoid the issue of recreating it

Ok, I'll look into this. Thanks for the tips! Sounds like I'm on the right path.

windracer · 2017-06-08 21:39:34

I've got the representative handling working. Had to do a little more than I originally thought because the pwg_representative folder might not exist yet in the destination so I have to create it. And then I also wanted to remove the pwg_representative folder from the source if it was empty after the move.

Now on to the derivatives ...

windracer · 2017-06-09 01:48:13

Grrr ... just realized that representatives can also have derivatives. So in addition to the pwg_representative folder in the physical directory/album, there's also in the derivatives folder under /_data/i/...etc.

windracer · 2017-06-09 05:47:31

Ok, I think I've manage to cover all the bases. The plugin handles representatives (and their derivatives) and all other derivatives, so no orphans and no need to re-generate. I want to do some more testing and then I'll try and publish my first plugin!

windracer · 2017-06-10 03:58:16

Ok, first release!

http://piwigo.org/ext/extension_view.php?eid=859

ddtddt · 2017-06-10 05:46:38

Hi :-)

Can you add EN file for language support

windracer · 2017-06-10 06:02:11

Can you point me to instructions on how to do that? Everything is in English already.

ddtddt · 2017-06-10 06:13:50

Hi :-)

in main.inc.php add function to load language

Code:

add_event_handler('loading_lang', 'physical_photo_move_loading_lang');    
function physical_photo_move_loading_lang(){
  load_language('plugin.lang', PPM_PATH);
}

add folder 'language'

in forder language add folder 'en_UK'

in forder en_UK add files

description.txt and plugin.lang.php

description.txt ->

Code:

Move a photo (the actual file) from one physical album to another, preserving all metadata.

plugin.lang.php ->

Code:

<?php
$lang['Move Photo'] = 'Move Photo';
$lang['Current physical album:'] = 'Current physical album:';
$lang['Current file location:'] = 'Current file location:';
........
?>

windracer · 2017-06-10 18:01:41

Ok, seems straightforward enough. I already had the load_language in there, but no corresponding add_event or the language files, obviously.

So in plugin.lang.php, I should include a line for every @translate in my plugin, right?

flop25 · 2017-06-10 18:03:50

Yes

windracer · 2017-06-10 18:13:23

Also, it looks like I should redo my @translate lines and use variable names to make the lines in plugin.inc.php shorter. In other words this:

Code:

$lang['CURR_PHYS_ALBUM'] = 'Current physical album:';

instead of this:

Code:

$lang['Current physical album:'] = 'Current physical album:';

And then I'd have to add an en_US language folder with these files too since that's my own default language. And I'm guessing if I didn't, I end up seeing 'CURR_PHYS_ALBUM' on the page instead of the en_US translation.

Thank you!

flop25 · 2017-06-10 18:17:42

Absolutely
You're welcome

Piwigo.org

Announcement

#1 2017-06-07 22:15:03

Thumbnail management (creating new, deleting orphans)

#2 2017-06-08 10:49:16

Re: Thumbnail management (creating new, deleting orphans)

#3 2017-06-08 17:38:18

Re: Thumbnail management (creating new, deleting orphans)

#4 2017-06-08 17:52:04

Re: Thumbnail management (creating new, deleting orphans)

flop25 wrote:

flop25 wrote:

#5 2017-06-08 21:39:34

Re: Thumbnail management (creating new, deleting orphans)

#6 2017-06-09 01:48:13

Re: Thumbnail management (creating new, deleting orphans)

#7 2017-06-09 05:47:31

Re: Thumbnail management (creating new, deleting orphans)

#8 2017-06-10 03:58:16

Re: Thumbnail management (creating new, deleting orphans)

#9 2017-06-10 05:46:38

Re: Thumbnail management (creating new, deleting orphans)

#10 2017-06-10 06:02:11

Re: Thumbnail management (creating new, deleting orphans)

#11 2017-06-10 06:13:50

Re: Thumbnail management (creating new, deleting orphans)

Code:

Code:

Code:

#12 2017-06-10 18:01:41

Re: Thumbnail management (creating new, deleting orphans)

#13 2017-06-10 18:03:50

Re: Thumbnail management (creating new, deleting orphans)

#14 2017-06-10 18:13:23

Re: Thumbnail management (creating new, deleting orphans)

Code:

Code:

#15 2017-06-10 18:17:42

Re: Thumbnail management (creating new, deleting orphans)

Board footer