That's just how thing s work and nothing Piwigo specific.

Yes, things works this way, i know it. But, for example, if you look at any forum script you will not find such behavior. Why? Maybe answer is here: https://en.wikipedia.org/wiki/Post/Redirect/Get?

flop25 wrote:

for instance on that forum you can't, because it not the same page ; it calls the Add your comment page, then it displays the thread.

vBulletin forum software (and many others too) for example can add comment not opening new pages. And all works fine.

Let's look at two scenarios.
Forum software:
1. i write a comment
2. i press "Submit" button
3. i get a page with my new comment added
4. i press "refresh" in browser - all works fine, no warnings or duplicate submission occured.

I can call this behavior normal and predictable.

Piwigo:
1. i write a comment
2. i press "Submit" button
3. i get a page with my new comment added
4. i press "refresh" in browser and get a warning about duplicate form submit. To refresh a page normally i must close a page in browser and open it once more or go to address line and press Enter.

Moreover, browsers can behave differently. On Android i get warning in Chrome but not in Opera - pressing Refresh button does nothing here. Opera on desktop computer does not show any warning at all and just makes a duplicate submit.

And another one surprise. When i edit comment in Piwigo and press a submit button, comment is edited, page reloaded and after that pressing Refresh button does not trying to submit form again.

Looking at this I assume that "edit comment" action does redirect but "add comment" action does not.

I can not call this behavior normal and predictable.

P.S. Sorry for my English. Most part of this post was written with a little help from google. :)

Last edited by vuk (2018-09-09 23:08:29)

flop25 wrote:

you are probably too young to understand that's a feature and not a bug
The behavior of Opera IS a bug, since it's sending back the information without asking you (it did once and it has a checkbox Don't remind me)

Oh, great sensei, let me bow down to your great life experience. :) But let's throw out talks about my age and opera bugs and talk about completely different piwigo behavior in two situations - creating and editing comments. Which of these behaviors is a bug and why?

Yes, from the point of view of the IT specialist, I understand you. But let's put ourselves to the user place who does not even look at what's in the address line and does not bother about all these details about addresses and forms and just tries to use the site. User will discover completely different behavior in two similar situations, and, in the case of adding a comment, the behavior will differ from what he used to, using the majority of sites on the Internet.

And one more thing. I tried to make redirect just after comment insertion into the database.
file: include/picture_comment.inc.php
line: 74
added text: redirect($url_self);

Result is: comment added, pressing Refresh does not submit form again but notification about comment is lost.

And yes, i'm understend, it's a not right place to do that, but i'm just tried and look at the result.