Announcement

  •  » Requests
  •  » Improved HTML and layout

#1 2005-06-07 14:11:09

yoDan
Member
France
2005-06-05
39

Improved HTML and layout

Hello world,

I reworked PWG's main two pages, namely category.php (displaying thumbnails) and picture.php (displaying the picture and associated comments).
Here are the links:
http://yo.dan.free.fr/pwg/category.htm
http://yo.dan.free.fr/pwg/picture.htm

The most visible part is the thumbnail adapting to the viewport's width. Other improvements include
* proper markup (semantic markup, clean ids, ...)
* improved accessibility (font family, color and size, forms, links)
* flexible layout (for those of you using a capable browser (i.e. not IE), have a look at the alternative stylesheets)

What do you think? What is missing? The layout and colors are based on the "clear" template. Are there features you like better in the original "clear" template? (I will argue ;-)

Hope to hear from you soon. Feel free to discuss in English or in French.

-- Daniel
A note about alternate stylesheets.It is a way to use different CSS files for the same (x)html code. In Firefox, open the View menu, then "Page style". In Mozilla, it is in "View"->"Use style". In Opera, look in "View"->"Style". No support in IE. The default layout uses a left menu bar (just as in many PWG layout), a "right navBar" style is available, as well as a "top navBar" style (menus popup when hovered) and a "top navBar funky" (with rounded borders only visible in gecko-based browsers).

Offline

 

#2 2005-06-08 00:11:46

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13195

Re: Improved HTML and layout

This is terrific! Really a great improvement in XHTML+CSS construction. This will first make a great template and surely integrated in the official release :-)

I've some comment about your code like "why do I find (semanticaly invalid) tables in each item of the (semanticaly valid) list of thumbnails ?"... but I have to go to sleep now because I work tomorrow.

Offline

 

#3 2005-06-08 11:16:09

yoDan
Member
France
2005-06-05
39

Re: Improved HTML and layout

Hi z0rglub, thanks for your feedback.

z0rglub wrote:

why do I find (semanticaly invalid) tables in each item of the (semanticaly valid) list of thumbnails ?

You are not going to like the answer, prepare to be surprised: that is because of Gecko.
As soon as gecko (Mozilla, Firefox and other browsers using gecko rendering code) supports "inline-block" or "inline-table" value for the "display" CSS property, or if we do not want to bother with Firefox support, I will drop the tables. You do want to support gecko, right? ;-) (so do I)
References: http://www.spartanicus.utvinternet.ie/c … ptions.htm and http://www.spartanicus.utvinternet.ie/g … tions.htm.

On top of my head, others changes I made and some explanations:
* using user's default font-size (i.e. 100% or greater, not micro-fonts like 12px or 10px)
* not using Verdana for anything but titles
* greater color contrast (avoid dark-gray over light-gray)
* structured forms, so that clicking on "Login" actually gives the focus to the login input field (same for the auto-login check-box)
* made links look like links (always colored and underlined, with feedback when hovered)
* avoided making links to current page

You see, mostly accessibility-related changes, nothing too drastic. Some references about (not) using Verdana on the web, and why I (and others) recommend using HTML instead of XHTML.

Cheers,
-- Daniel

Offline

 

#4 2005-06-09 01:11:01

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13195

Re: Improved HTML and layout

Hi yoDan,

yoDan wrote:

Are there features you like better in the original "clear" template?

In picture.php, I do prefer the way icons are presented in template "clear" release 2. (on the right you find navigation icons, I will soon add "go to first" and "go to last" icons).

http://le-gall.net/pierrick/blog/images/screenshot_clear-2.png

yoDan wrote:

why I (and others) recommend using HTML instead of XHTML

Sorry for having forgotten to read your DOCTYPE :-/ I will deeply read the linked article, not sure to agree but why not.

yoDan wrote:

You do want to support gecko, right?

I do. Personnaly, support for MSIE has no kind of importance (on my personnal gallery). I now understand why you can't avoid using tables.


To continue (why am I the only one to give some feedback?), let's talk about the creation of a full template based on your work! You made 90%, what remains is the packaging and integration in *.tpl instead of *.html. Would you like to package the template or do you want me to take this action? (How do you wand to call your template?)

Offline

 

#5 2005-06-09 03:18:23

xaviounet
Member
2005-05-11
58

Re: Improved HTML and layout

Hi,

What a very good improvement!
I like a lot what you did.
Just a little thing, on your picture page, there is a problem of display on the computer I use at work. The line at the beginning of the pink square behind the comments cuts sometimes the beginning of a comment.
I also prefer the arrows on the right but it is personnal.

Thank you!
And good work!

Offline

 

#6 2005-06-09 19:21:07

yoDan
Member
France
2005-06-05
39

Re: Improved HTML and layout

To all:

Here is an easy way to contribute to PWG: go look at the two sample pages I posted earlier, see if it looks good, and report any display problem, misalignment, disappearing or overlapping text, or whatever. Please do it, the data you will report is precious to us.
Important information to include in your report are details about your browser (name, version, platform) and precise description of the problem (http link to a screenshot displaying the problem is perfect). Thanks!

xaviounet wrote:

Just a little thing, on your picture page, there is a problem of display on the computer I use at work. The line at the beginning of the pink square behind the comments cuts sometimes the beginning of a comment.

I don't see no pink square! :o)
I am suspecting you are using IE 5.5, but would really need more details. Does the problem disappear as you scroll the page?

Thanks for the feedback, I will respond to the other points tomorrow. Now is time to unplug. :-/
Bye,
-- Daniel

Offline

 

#7 2005-06-10 07:18:07

xaviounet
Member
2005-05-11
58

Re: Improved HTML and layout

Sorry, I didn't explain very well
Here is a screenshot (made at a computer at my work place) of the problem that I can see each time I use IE version 6.00.29
http://ile.des.dieux.free.fr/pwg.htm
You can see the comments going little by little on the left, even the title of the comments...
but no problem with the other browsers...

Talk to you soon

Last edited by xaviounet (2005-06-10 07:20:24)

Offline

 

#8 2005-06-15 12:55:02

yoDan
Member
France
2005-06-05
39

Re: Improved HTML and layout

Sorry for the delay, real-life work is keeping me busy these days...

xaviounet wrote:

Here is a screenshot (made at a computer at my work place) of the problem that I can see each time I use IE version 6.00.29

Thanks, that should be fixed now (setting a padding-bottom length to BLOCKQUOTEs caused IE to shift follow-up contents to the left! Oh dear)
I also reverted to the previous layout as far as navigation arrows are concerned (left, up, right).
Any other problem or suggestion?

z0rglub, I understand you might be frustrated to have to wait so long for my action. If you have some spare time, you are welcome to package the template. You could name it after the original "clear" template, possibly "clear2", I don't know. If you can wait until July, or if you are yourself busy, I will do it.

All the best,
-- Daniel

Offline

 

#9 2005-06-28 15:59:44

yoDan
Member
France
2005-06-05
39

Re: Improved HTML and layout

Regarding:

z0rglub wrote:

I find (semanticaly invalid) tables in each item of the (semanticaly valid) list of thumbnails ?"

I have an update that may well fix the problem. What do you think of http://yo.dan.free.fr/pwg/category2.htm ?
Seems to work in Opera, FireFox (except that the margin is ignored: thumbnails are too close to each other), IE6 (except a minor border-bottom quirk). I haven't tested it in other browsers, so please let me know if there is any problem.

Offline

 

#10 2005-06-30 11:25:09

Sephi
Former Piwigo Team
Suisse
2004-11-28
430

Re: Improved HTML and layout

A very good template I think. The code is very clean and well structured, very nice. ^^
There's just one thing I don't like : the pictures are underlined, like the links. I understand you want to underline all the links, but I think the thumbnails would look better without the underlining.

Offline

 

#11 2005-06-30 15:13:04

yoDan
Member
France
2005-06-05
39

Re: Improved HTML and layout

Sephi wrote:

pictures are underlined, like the links. I understand you want to underline all the links, but I think the thumbnails would look better without the underlining.

I too dislike the underlining. It is even explicitely disabled:

Code:

.thumbnails SPAN A:first-child { border: none }

I guess you are viewing the page in IE or any ancient browser that does not understand the first-child pseudo-class selector. ;-)
In the final template, it will probably be worth adding a "class=no_underline" to the A element containing the IMG thumbnail.

Thanks for your impressions. Any other thought or browser testing?

-- Daniel

Offline

 

#12 2005-06-30 15:41:32

Sephi
Former Piwigo Team
Suisse
2004-11-28
430

Re: Improved HTML and layout

yoDan wrote:

I guess you are viewing the page in IE or any ancient browser that does not understand the first-child pseudo-class selector. ;-)

I'm surprised, because I'm using Mozilla Firefox (I'm not mad enough to use IE)...
The version I use is the 1.0.4.

The pictures are not underlined in the "gallery" section (http://yo.dan.free.fr/pwg/category2.htm), but they are in the "picture" section (http://yo.dan.free.fr/pwg/picture.htm). Maybe we were not speaking about the same page. :)

Offline

 

#13 2005-07-05 03:05:33

yoDan
Member
France
2005-06-05
39

Re: Improved HTML and layout

Indeed, Sephi, we were not talking of the same thing. :o)
I disabled the underlining in question.

Offline

 

#14 2005-07-11 12:07:09

Eric B
Member
2003-10-02
90

Re: Improved HTML and layout

I like your template so much that I d like to use it! Can I?
Is there a link where I could download the files?

Offline

 

#15 2005-07-12 01:05:06

yoDan
Member
France
2005-06-05
39

Re: Improved HTML and layout

Eric, all,

Turning these two sample pages into a template is a work in progress. Actually, I am stuck at a very early stage (still figuring out how to create a pwg gallery: I was not a PWG user), but I remain confident that I will come up with a template "shortly". ;-)
Seriously, thanks for caring, I will try and get something out real soon.

Offline

 
  •  » Requests
  •  » Improved HTML and layout

Board footer

Powered by FluxBB

github twitter facebook google+ newsletter Donate Piwigo.org © 2002-2019 · Contact