Piwigo.org

VDigital · 2010-03-19 22:04:22

Why not this?

Code:

local
|
|-- css
|   |-- rules.css
|   |-- clear-rules.css
|   `-- dark-rules.css
|
|-- language
|   |
|   |-- fr_FR.php
|   |-- en_EN.php
|
|-- database.php
`-- config.php

KISS, not?

nicolas · 2010-03-20 14:48:43

To avoid security issue or to easily protect database config file I think it will be better to put config.inc.php and database.inc.php in a config subdirectory of local.

I think we should keep double extension .inc.php to say that theses files are included.

VDigital · 2010-03-20 17:22:16

Sounds strong and clear!

P@t · 2010-03-20 17:36:29

Ok... I'll commit that... nicolas will do the database.inc.php move.

For language files, I prefer fr_FR.lang.php, en_UK.lang.php, etc...
It's easier to modify load_language function, and it's more logical to keep .lang.php extension.

rvelices · 2010-03-21 20:16:34

I think its a lot cleaner now: all "user" files in one dir ...

P@t · 2010-03-21 20:44:49

rvelices wrote:
I think its a lot cleaner now: all "user" files in one dir ...

What about prefilter for local css loading?
Do you have better solution?

rvelices · 2010-03-21 21:28:49

P@t wrote:
What about prefilter for local css loading?
Do you have better solution?

No I don't have a better solution. I'm happy that it is done only during template compilation ...

rub · 2010-03-22 17:21:07

First: Bad point! New local architecture is new theme architecture.
Don't open a new topic?

Great idea to put local on a unique and localizated place!

rvelices wrote:
P@t wrote:
What about prefilter for local css loading?
Do you have better solution?
No I don't have a better solution. I'm happy that it is done only during template compilation ...

It's dangerous for user witch add manually css file. Isn'it?
It's not possible to add a rule witch force compile template when a file is added or deleted on local directory?

P@t · 2010-03-22 22:03:57

rub wrote:
rvelices wrote:
P@t wrote:
What about prefilter for local css loading?
Do you have better solution?
No I don't have a better solution. I'm happy that it is done only during template compilation ...
It's dangerous for user witch add manually css file. Isn'it?
It's not possible to add a rule witch force compile template when a file is added or deleted on local directory?

No... the aim of prefilter is to avoid file_exists function.
If we use file_exists function, we don't have to use prefilter at all (but we lose performances)
But I hope that everyone will use LocalFiles Editor ;-)

rub · 2010-03-22 23:45:09

P@t wrote:
rub wrote:
rvelices wrote:

No I don't have a better solution. I'm happy that it is done only during template compilation ...
It's dangerous for user witch add manually css file. Isn'it?
It's not possible to add a rule witch force compile template when a file is added or deleted on local directory?
No... the aim of prefilter is to avoid file_exists function.
If we use file_exists function, we don't have to use prefilter at all (but we lose performances)

I didn't talk of file_exists function but more to a global function witch indicate a change (I don't have this function).

P@t wrote:
But I hope that everyone will use LocalFiles Editor ;-)

Not sure ;-) (A test on local gallery with ftp transfer of new file on production gallery for example)

tosca · 2010-03-23 00:14:16

rub wrote:
P@t wrote:
But I hope that everyone will use LocalFiles Editor ;-)
Not sure ;-) (A test on local gallery with ftp transfer of new file on production gallery for example)

+1

Last edited by tosca (2010-03-23 00:15:21)

P@t · 2010-03-23 01:44:52

rub wrote:
I didn't talk of file_exists function but more to a global function witch indicate a change (I don't have this function).

I don't have too... and I had looking for it for a while!

mathiasm · 2010-04-03 14:29:43

With the new architecture, the [Bugtracker] ticket 243 seems meaningless, no ?

plg · 2010-04-03 16:23:54

mathiasm wrote:
With the new architecture, the [Bugtracker] ticket 243 seems meaningless, no ?

closed.

Piwigo.org

Announcement

#46 2010-03-19 22:04:22

Re: New architecture for themes

Code:

#47 2010-03-20 14:48:43

Re: New architecture for themes

#48 2010-03-20 17:22:16

Re: New architecture for themes

#49 2010-03-20 17:36:29

Re: New architecture for themes

#50 2010-03-21 20:16:34

Re: New architecture for themes

#51 2010-03-21 20:44:49

Re: New architecture for themes

rvelices wrote:

#52 2010-03-21 21:28:49

Re: New architecture for themes

P@t wrote:

#53 2010-03-22 17:21:07

Re: New architecture for themes

rvelices wrote:

P@t wrote:

#54 2010-03-22 22:03:57

Re: New architecture for themes

rub wrote:

rvelices wrote:

P@t wrote:

#55 2010-03-22 23:45:09

Re: New architecture for themes

P@t wrote:

rub wrote:

rvelices wrote:

P@t wrote:

#56 2010-03-23 00:14:16

Re: New architecture for themes

rub wrote:

P@t wrote:

#57 2010-03-23 01:44:52

Re: New architecture for themes

rub wrote:

#58 2010-04-03 14:29:43

Re: New architecture for themes

#59 2010-04-03 16:23:54

Re: New architecture for themes

mathiasm wrote:

Board footer