plg wrote:

The directory local is not the same as the directory _data which should be considered as a cache, that can be emptied at any time without breaking Piwigo. The other difference is that _data does not have to be visible on HTTP request while local must be.

In fact I store my plugin config files in _data ...

Ideally we should somehow be able to simplify for the users
1. - 'persistent' directory without required url access (_data/plugins, database config ...)
2. - 'persistent' directory with required url access (local/css)
3. - 'cache' directory without required url access (templates_c.)
4. - 'cache' directory with required url access (local/combined)

1. and 2. should be backed up by the user ...

plg wrote:

I have a problem with this change.

I would like to have $conf[local_dir], set to './local' by default. Unfortunately, the standard way to customize parameter settings is to overwrite them in.... local/config/config.inc.php. You see the problem: we can't define the $conf[local_dir] in $conf[local_dir]/config/config.inc.php

Moreover, in include/common.inc.php, local/config/database.inc.php is included before configuration files.

Any idea?

Define this setting at the installation time?

rvelices wrote:

Maybe just do it simple, modify config_default on piwigo.com and include at the end config_default_piwigo.com.php ???

Yes, if I want to solve the problem just for Piwigo.com, adding a $conf[local_dir] in include/config_default and changing it would be enough. On Piwigo.com, I use a $_SERVER[specific_var] that is set by the web server (setEnv with Apache, setenv.add-environment with Lighttpd) for each virtualhost.

A simple way to solve the problem would something like this in include/config_default :

$conf['local_dir'] = './local';
if (isset($_SERVER['PWG_LOCAL_DIR']))
{
    $conf['local_dir'] = $_SERVER['PWG_LOCAL_DIR'];
}

With a page in the Piwigo documentation that explains how to set the $_SERVER['PWG_LOCAL_DIR'] from Apache or Lighttpd.

But the danger is that it would be possible to overwrite $conf[local_dir] in $conf[local_dir]/config/config.inc.php. The only way I have in mind to prevent overwriting would be to use a constant instead of $conf[local_dir] in include/config_default (and not in include/constants because $conf must be already defined) :

if (isset($_SERVER['PWG_LOCAL_DIR']))
{
    define(PWG_LOCAL_DIR, $_SERVER['PWG_LOCAL_DIR']);
}
else
{
    define(PWG_LOCAL_DIR, './local');
}

With this solution + documentation page on "how to set $_SERVER['PWG_LOCAL_DIR'] from your web server", this makes an easy multisite solution for Piwigo, which does not depend on the URL.

On Nginx, the equivalent of Apache setEnv is fastcgi_param

As I can't define PWG_LOCAL_DIR in include/config_default, I've moved this code into include/common:

define(
  'PWG_LOCAL_DIR',
  isset($_SERVER['PWG_LOCAL_DIR'])
    ? $_SERVER['PWG_LOCAL_DIR']
    : PHPWG_ROOT_PATH.'local/'
);

@include(PWG_LOCAL_DIR .'config/database.inc.php');
[...]
include(PHPWG_ROOT_PATH . 'include/config_default.inc.php');
@include(PWG_LOCAL_DIR. 'config/config.inc.php');

The problem is that I must duplicate this code everywhere include/common is not loaded : install.php, upgrade.php, upgrade_feed.php (well OK, that's only 3 files, it's not that a big deal)

plg wrote:

Code:

define(
  'PWG_LOCAL_DIR',
...
    : PHPWG_ROOT_PATH.'local/'
);

Please no PHPWG_ROOT_PATH. It should be relative to the root ! Let the code use PHPWG_ROOT_PATH or get_root_url depending on the page ...

plg wrote:

would that be better? (so that we can use get_root_url().PWG_LOCAL_DIR somewhere else ?)

Yes :). It must be used when sending to the browser combined_css and combined_url in template.php . It is required to be different if we have question_mark_in_url = false