Piwigo.org

mistic100 · 2011-05-07 17:08:59

but It will ask all 'non-common' themes to add a localhead too, isn't it ?

want I want is a impact-less method, so authors just have to modify one line in their css (and YES I live in a "bisounours" [equivalent in english ?] world ^^)

Last edited by mistic100 (2011-05-07 17:09:11)

flop25 · 2011-05-07 17:13:58

I can't test this we but I remembered the localhead of parent themes are loaded : it's not a tpl file as the other

mistic100 · 2011-05-07 17:16:22

yes they are

so I've find a good solution : margin-left are declared by theme as they wish but I add on the default localhead

Code:

{if !isset($MENUBAR)}<style type="text/css">.content {ldelim} margin-left:0; }</style>{/if}

it's the inverse logic ^^

edit : but some themes have 'load_parent_local_head' => false :s
edit2 : the same don't exclude pages :)

Last edited by mistic100 (2011-05-07 17:25:01)

mistic100 · 2011-05-07 18:00:47

here is a first try [Subversion] r10812

sum up of future corrections needed on themes :
Luciano Amodio, BlancMont XL, GBO*, MontBlancXL, MoeWP, Sakura BW : minor css change needed
OS_*, hr_* must delete the included code from SpreadMenus
Gally, Luciano, OS*, Simple*, Sobre, Stripped : work but can add the menu on picture and/or other pages

and don't forget to add '400' to the list of merged extensions before release Piwigo 2.3 ^^

Last edited by mistic100 (2011-05-07 18:02:37)

flop25 · 2011-05-07 19:45:49

mistic100 wrote:
here is a first try [Subversion] r10812

if isset($themeconf['Exclude']) is true the menubar will not be displayed according to the code

if (isset($themeconf['Exclude']) AND !in_array('theProfilePage', $themeconf['Exclude']))
is better

2 more things what we need to discuss :
- you've deleted the link "href="{$U_HOME}" title="{'Home'|@translate}": I disagree, the ways to go back to the home page are currently not very user-friendly, so one more link is better.
- you give the choice to the admin to display or not the menu on picture page... welll I don't know... adding a config page for theme sounds better but it implies that all themes must be changed... is there a way to set this option to false by default -for retrocompatibility for themes- and to manage this from a config page for core themes ?

mistic100 · 2011-05-07 19:55:11

flop25 wrote:
if isset($themeconf['Exclude']) is true the menubar will not be displayed according to the code

if (isset($themeconf['Exclude']) AND !in_array('theProfilePage', $themeconf['Exclude']))
is better

right... sometimes I make some stupid errors

flop25 wrote:
you've deleted the link "href="{$U_HOME}" title="{'Home'|@translate}": I disagree, the ways to go back to the home page are currently not very user-friendly, so one more link is better.

Personnaly I always navigate through the menu and can't stand "multi-menu" websites, but if you think it's better for "the masses" ^^

flop25 wrote:
you give the choice to the admin to display or not the menu on picture page... welll I don't know... adding a config page for theme sounds better but it implies that all themes must be changed... is there a way to set this option to false by default -for retrocompatibility for themes- and to manage this from a config page for core themes ?

don't really understand, the parameter is actually false by default

Last edited by mistic100 (2011-05-07 19:55:26)

mistic100 · 2011-05-07 20:17:06

mistic100 wrote:
flop25 wrote:
if isset($themeconf['Exclude']) is true the menubar will not be displayed according to the code

if (isset($themeconf['Exclude']) AND !in_array('theProfilePage', $themeconf['Exclude']))
is better
right... sometimes I make some stupid errors

finally... no, because with your code, if $themeconf['Exclude'] isn't declared then the menu will not be shown

edit : my version works : if I add 'Exclude' => array('theIdentificationPage') then the menu is only masked on login page..... or I don't understand what you mean

Last edited by mistic100 (2011-05-07 20:50:14)

flop25 · 2011-05-08 13:14:14

mistic100 wrote:
mistic100 wrote:
flop25 wrote:
if isset($themeconf['Exclude']) is true the menubar will not be displayed according to the code

if (isset($themeconf['Exclude']) AND !in_array('theProfilePage', $themeconf['Exclude']))
is better
right... sometimes I make some stupid errors
finally... no, because with your code, if $themeconf['Exclude'] isn't declared then the menu will not be shown

edit : my version works : if I add 'Exclude' => array('theIdentificationPage') then the menu is only masked on login page..... or I don't understand what you mean

oh never mind ... it's one my "stupid errors" ^^

fot the last point, I'll experiment and think again before to come again.

Piwigo.org

Announcement

#16 2011-05-07 17:08:59

Re: Spread Menus in the core ?

#17 2011-05-07 17:13:58

Re: Spread Menus in the core ?

#18 2011-05-07 17:16:22

Re: Spread Menus in the core ?

Code:

#19 2011-05-07 18:00:47

Re: Spread Menus in the core ?

#20 2011-05-07 19:45:49

Re: Spread Menus in the core ?

mistic100 wrote:

#21 2011-05-07 19:55:11

Re: Spread Menus in the core ?

flop25 wrote:

flop25 wrote:

flop25 wrote:

#22 2011-05-07 20:17:06

Re: Spread Menus in the core ?

mistic100 wrote:

flop25 wrote:

#23 2011-05-08 13:14:14

Re: Spread Menus in the core ?

mistic100 wrote:

mistic100 wrote:

flop25 wrote:

Board footer