Piwigo.org

You are not logged in. (Register / Login)

Announcement

#1 2012-05-24 17:13:09

plg
Piwigo Team
Location: Paris, France, Europe
Registered: 2002-04-05
Posts: 11717
Website

[multisize] default size

Hi rvelices,

In [Forum, post 127614 by rvelices in topic 18755] [multisize] AJAX load for thumbnails I'm not sure you replied to my question "how to I know which size is the default size?".

As we have changed the default dimensions for sizes, and that size L was 648x576 and is now 1008x756, this is now far too big for a default size. I would like to switch the default size to size M instead (which is currently 792x594 by default).


Latest blog post on Piwigo.com: Piwigo 2.5 on Piwigo.com (March 7th, 2013)

Offline

#2 2012-05-24 17:26:48

Billr
Piwigo Team, forum moderator
Registered: 2011-06-22
Posts: 144

Re: [multisize] default size

In support of this, a common default the past 10 years or so for monitor display has been 800x600 (SVGA).

Offline

#3 2012-05-24 19:05:35

rvelices
Piwigo Team
Registered: 2005-12-29
Posts: 1556
Website

Re: [multisize] default size

plg wrote:

As we have changed the default dimensions for sizes, and that size L was 648x576 and is now 1008x756, this is now far too big for a default size. I would like to switch the default size to size M instead (which is currently 792x594 by default).

OK, but please put the defaiult size in config_default

Offline

#4 2012-05-24 20:02:22

plg
Piwigo Team
Location: Paris, France, Europe
Registered: 2002-04-05
Posts: 11717
Website

Re: [multisize] default size

Actually, I don't understand what in the code makes size L as default size. I search, I read, I can't find :-/


Latest blog post on Piwigo.com: Piwigo 2.5 on Piwigo.com (March 7th, 2013)

Offline

#5 2012-05-24 21:43:39

rvelices
Piwigo Team
Registered: 2005-12-29
Posts: 1556
Website

Re: [multisize] default size

plg wrote:

Actually, I don't understand what in the code makes size L as default size. I search, I read, I can't find :-/

picture.php function default_picture_content
$deriv_type = pwg_get_session_var('picture_deriv', IMG_LARGE);

Offline

#6 2012-05-24 22:08:51

plg
Piwigo Team
Location: Paris, France, Europe
Registered: 2002-04-05
Posts: 11717
Website

Re: [multisize] default size

Perfect, I was searching in include/derivative_std_params.inc.php instead of performing a grep on IMG_LARGE on all *.php files!

Are you ok for this new parameter in include/config_defaults.inc.php?

Code:

// 'small', 'medium' or 'large'
$conf['derivative_default_size'] = 'medium';

and this change in picture.php?

Code:

$deriv_type = pwg_get_session_var('picture_deriv', $conf['derivative_default_size']);

(twice on the page)

We can't use the constants defined in include/derivative_std_params.inc.php.


Latest blog post on Piwigo.com: Piwigo 2.5 on Piwigo.com (March 7th, 2013)

Offline

#7 2012-05-24 22:40:10

rvelices
Piwigo Team
Registered: 2005-12-29
Posts: 1556
Website

Re: [multisize] default size

plg wrote:

Are you ok for this new parameter in include/config_defaults.inc.php?

perfect

Offline

#8 2012-05-25 01:12:46

plg
Piwigo Team
Location: Paris, France, Europe
Registered: 2002-04-05
Posts: 11717
Website

Re: [multisize] default size


Latest blog post on Piwigo.com: Piwigo 2.5 on Piwigo.com (March 7th, 2013)

Offline

Board footer

Powered by FluxBB

About this website · Donate · Contact Piwigo project © 2002-2013