Piwigo.org

plg · 2012-06-28 13:16:29

Piwigo 2.4.0 was released nearly 7 days ago and we already see many things we can improve to avoid problems.

1) [Bugtracker, bug 2672, fixed] [ImageMagick] invalid option sampling-factor for old versions of ImageMagick

On old versions of ImageMagick, the sampling-factor doesn't work. Several users have reported the probleme on ImageMagick 6.2.8. If we could detect the version of ImageMagick, store it in the session for example, then we can only use this option on recent version (don't know which version exactly) of ImageMagick.

2) [Bugtracker, bug 2674, fixed] cssmin 3.0.1 requires PHP 5.2.4

cssmin.class.php seems to require a very recent version of PHP and many users don't have it yet. If we could separate merging and minifying, then if PHP_VERSION < 5.? (not even sure that 5.2.0 is enough, see [Forum, post 131345 by samli in topic 19700] Upgrade from 2.3.5 to 2.4 failed -- big time.) Piwigo only merges without minifying (no use of cssmin.class.php)

3) [Bugtracker, bug 2677, fixed] smarter check of the current version and required upgrade

Smarter check of $conf['piwigo_db_version'] : sometimes the upgrade fails at some point but all migration tasks are applied. Unfortunately, $conf['piwigo_db_version'] is not updated to "2.4" which makes include/common.inc.php always redirect to upgrade.php (which doesn't see any upgrade to apply...).

4) [Bugtracker, bug 2669, fixed] cancel migration task 121 and create a dedicated plugin

On Free.fr, it seems that the extra lines in .htaccess (migration task http://piwigo.org/dev/browser/branches/ … tabase.php ) are breaking the website, we could add a simple check on $_SERVER['HTTP_HOST']

5) [Bugtracker, bug 2668, fixed] php warnings on glob() function watermarks + multi size

6) [Bugtracker, bug 2661, fixed] sql error in admin / history /search tab

7) [Bugtracker, bug 2671, fixed] check compatibility for extensions is broken

Anything else?

deserteagle · 2012-06-28 15:09:34

for multiple size, separate different size photos in different folder for cache folder. see my poster here

http://piwigo.org/forum/viewtopic.php?id=19765

plg · 2012-06-28 15:12:23

This is not a really a bug but an important change that doesn't look very mandatory.

flop25 · 2012-06-28 15:12:27

we have seen this, here is just for confirmed bug; we will talk about your proposition on your thread

rvelices · 2012-06-28 16:55:29

same old history of file permissions / umask / suexec vs module ...
(not sure we can do anything without a proper setup ...)

flop25 · 2012-06-28 16:59:20

Also a problem with htaccess : fr http://fr.piwigo.org/forum/viewtopic.php?id=22265

flop25 · 2012-06-29 10:34:54

about htaccess maybe an option in Tools, Maintenance for deleting/adding it [Bugtracker, bug 2669, fixed] cancel migration task 121 and create a dedicated plugin

flop25 · 2012-06-29 10:57:01

plg wrote:
3) smarter check of $conf['piwigo_db_version'] : sometimes the upgrade fails at some point but all migration tasks are applied. Unfortunately, $conf['piwigo_db_version'] is not updated to "2.4" which makes include/common.inc.php always redirect to upgrade.php (which doesn't see any upgrade to apply...).

I was more thinking of removing/changing l329 in upgrade.php
else
{
die('No upgrade required, the database structure is up to date');
}
Instead of that, checking if the last xxx-database.php correspond to "select id from piwigo_upgrade order by id+0 desc limit 0;" and if it's ok, checking if the piwigo_db_version needs to be updated too

plg · 2012-06-29 12:09:39

flop25 wrote:
about htaccess maybe an option in Tools, Maintenance for deleting/adding it [Bugtracker, bug 2669, fixed] cancel migration task 121 and create a dedicated plugin

Or maybe juste completely remove the migration task 121 and create a plugin which adds lines in .htaccess.

fatman · 2012-06-29 13:38:43

if I enable $conf['question_mark_in_urls'] = false;
the url in picture.php will become

../../../i.php/galleries/XXXXXXXX
../../../galleries/XXXXXXX

flop25 · 2012-06-29 13:43:00

fatman wrote:
if I enable $conf['question_mark_in_urls'] = false;
the url in picture.php will become

../../../i.php/galleries/XXXXXXXX
../../../galleries/XXXXXXX

if you have a question or a problem please open a new thread

flop25 · 2012-06-29 13:46:56

I added : [Bugtracker, bug 2670, open] Invalid argument supplied for foreach() in .../piwigo/admin/configuration.php on line 503
edit : forget it, it has been corrected thx to rvelices

Last edited by flop25 (2012-06-29 17:03:27)

fatman · 2012-06-29 15:03:30

flop25 wrote:
fatman wrote:
if I enable $conf['question_mark_in_urls'] = false;
the url in picture.php will become

../../../i.php/galleries/XXXXXXXX
../../../galleries/XXXXXXX
if you have a question or a problem please open a new thread

I think plg is asking for bug report as first....

anyway, it should be caused by $page['root_path'] in section_init.php is incorrect build.

flop25 · 2012-06-29 15:06:28

fatman wrote:
flop25 wrote:
fatman wrote:
if I enable $conf['question_mark_in_urls'] = false;
the url in picture.php will become

../../../i.php/galleries/XXXXXXXX
../../../galleries/XXXXXXX
if you have a question or a problem please open a new thread
I think plg is asking for bug report as first....

anyway, it should be caused by $page['root_path'] in section_init.php is incorrect build.

yes for bug confirmed ; yours is new to our knowledge
So please open a new thread and explain if the pictures are displayed or not with these url, of you tried with the config set as true etc

plg · 2012-06-30 00:26:53

plg wrote:
1) on old versions of ImageMagick, the sampling-factor doesn't work. Several users have reported the probleme on ImageMagick 6.2.8. If we could detect the version of ImageMagick, store it in the session for example, then we can only use this option on recent version (don't know which version exactly) of ImageMagick.

[Bugtracker, bug 2672, fixed] [ImageMagick] invalid option sampling-factor for old versions of ImageMagick

For now, I have simply deactivated the option. Later we can improve the way we detect IM version and use this option when IM_version > X (X must be found as well). The idea of version 2.4.1 is to make 2.4 more stable.

Piwigo.org

Announcement

#1 2012-06-28 13:16:29

Release 2.4.1 under preparation

#2 2012-06-28 15:09:34

Re: Release 2.4.1 under preparation

#3 2012-06-28 15:12:23

Re: Release 2.4.1 under preparation

#4 2012-06-28 15:12:27

Re: Release 2.4.1 under preparation

#5 2012-06-28 16:55:29

Re: Release 2.4.1 under preparation

#6 2012-06-28 16:59:20

Re: Release 2.4.1 under preparation

#7 2012-06-29 10:34:54

Re: Release 2.4.1 under preparation

#8 2012-06-29 10:57:01

Re: Release 2.4.1 under preparation

plg wrote:

#9 2012-06-29 12:09:39

Re: Release 2.4.1 under preparation

flop25 wrote:

#10 2012-06-29 13:38:43

Re: Release 2.4.1 under preparation

#11 2012-06-29 13:43:00

Re: Release 2.4.1 under preparation

fatman wrote:

#12 2012-06-29 13:46:56

Re: Release 2.4.1 under preparation

#13 2012-06-29 15:03:30

Re: Release 2.4.1 under preparation

flop25 wrote:

fatman wrote:

#14 2012-06-29 15:06:28

Re: Release 2.4.1 under preparation

fatman wrote:

flop25 wrote:

fatman wrote:

#15 2012-06-30 00:26:53

Re: Release 2.4.1 under preparation

plg wrote:

Board footer