Piwigo.org

LucMorizur · 2014-02-03 22:06:52

Hi;

I just discovered that function conf_update_param (in include/functions.inc.php) updates the database, but doesn't update global variable array $conf. This creates a small bug in [extension by Eric] LCAS, as $conf is used immediately after using conf_update_param to display the new configuration. Thus the configuration shown is the old one, though parameters are properly stored in the database (and thus the displayed config is correct after updating or reloading the page).

Is this functionning intended, or shall I open a ticket in the bugtracker?

mistic100 · 2014-02-03 22:10:46

Hi

Without being intented I didn't changed it when I saw it because I guess it can cause bugs to change the behavior of the method.
But it could have been changed for 2.6 (major release, compatibility breaks, etc.)

And the solution is simple : update $conf yourself :-)

flop25 · 2014-02-03 22:12:01

indeed we have to load_conf_from_db

mistic100 · 2014-02-03 22:13:14

That's overkill

flop25 · 2014-02-03 22:14:20

mistic100 wrote:
That's overkill

that's only once a admin form for options is send so that's once every... months?

mistic100 · 2014-02-03 22:18:01

I didn't say it is unoptimized :-)

Personally I always build $conf['myplugin'] from config form and give it to conf_update_param
That way I am always sure what it is in DB and it clean potentially corrupted config

LucMorizur · 2014-02-04 23:10:26

Well, I chose to build $conf['LoginCaseAccentsSensitivity'] before updating the DB...

But I think that for version 2.7, it would be logical to update $conf in function conf_update_param...

Thanks!

mistic100 · 2014-02-04 23:25:46

[Bugtracker] ticket 3038

Piwigo.org

Announcement

#1 2014-02-03 22:06:52

[resolved] conf_update_param doesn't update $conf

#2 2014-02-03 22:10:46

Re: [resolved] conf_update_param doesn't update $conf

#3 2014-02-03 22:12:01

Re: [resolved] conf_update_param doesn't update $conf

#4 2014-02-03 22:13:14

Re: [resolved] conf_update_param doesn't update $conf

#5 2014-02-03 22:14:20

Re: [resolved] conf_update_param doesn't update $conf

mistic100 wrote:

#6 2014-02-03 22:18:01

Re: [resolved] conf_update_param doesn't update $conf

#7 2014-02-04 23:10:26

Re: [resolved] conf_update_param doesn't update $conf

#8 2014-02-04 23:25:46

Re: [resolved] conf_update_param doesn't update $conf

Board footer