Announcement

  •  » Beta testing
  •  » [2.7] Custom Themes / Admin section changes

#1 2014-09-23 07:44:25

Serge D
Member
US
2014-07-15
315

[2.7] Custom Themes / Admin section changes

2.7 test results:

* Themes -  GD theme has been converted/verified and I did not find big issues, all but admin section...
* Admin section - changes applied to left side navigation menu are such that they do not allow to determine via css if section is expanded/collapsed as it was before using .ui-accordion
   It would be very useful if along with modifying visibility of UL element, some sort of class would be set to section header section. In fact, if you do that then visibility would be maintained automatically based on simple hierarchy like dt.active, dt.active+dd
I know Piwigo does not promote styling of admin section, but having more class attributes set in 2.6 was handy
* Use of themeconf[colorscheme] - this is global setting, while in fact it should be allowed to be set dynamically. Would it be safe to set it in add_event_handler('init', 'mytheme_init'); ?

Last edited by Serge D (2014-09-23 07:52:53)

Offline

 

#2 2014-09-23 09:53:05

mistic100
Former Piwigo Team
Lyon (FR)
2008-09-27
3271

Re: [2.7] Custom Themes / Admin section changes

the {$ACTIVE_MENU} template variable tells you which menu is open

--

yes no problem, it is intended to work that way

Offline

 

#3 2014-09-23 10:27:09

rvelices
Piwigo Team
2005-12-29
1960

Re: [2.7] Custom Themes / Admin section changes

Serge D wrote:

* Use of themeconf[colorscheme] - this is global setting, while in fact it should be allowed to be set dynamically. Would it be safe to set it in add_event_handler('init', 'mytheme_init'); ?

just set it when themeconf.inc.php is loaded as here:

http://piwigo.org/dev/browser/trunk/the … nc.php#L13

Offline

 

#4 2014-09-23 10:28:37

mistic100
Former Piwigo Team
Lyon (FR)
2008-09-27
3271

Re: [2.7] Custom Themes / Admin section changes

rvelices wrote:

Serge D wrote:

* Use of themeconf[colorscheme] - this is global setting, while in fact it should be allowed to be set dynamically. Would it be safe to set it in add_event_handler('init', 'mytheme_init'); ?

just set it when themeconf.inc.php is loaded as here:

http://piwigo.org/dev/browser/trunk/the … nc.php#L13

themes could need to change it depending on which style is loaded (Stripped for example) :-)

Offline

 

#5 2014-09-23 10:29:06

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13182

Re: [2.7] Custom Themes / Admin section changes

even more dynamic if you have several styles in your theme :-)

http://piwigo.org/dev/browser/extension … nc.php#L63

Code:

  'colorscheme' => 'white' == $stripped['themeStyle'] ? 'clear' : 'dark',

Latest blog post (November 9th 2018) Why Flickr could not remain free for ever

Offline

 

#6 2014-09-23 15:38:08

Serge D
Member
US
2014-07-15
315

Re: [2.7] Custom Themes / Admin section changes

ok, this may work, need to test, but it breaks concept of using events

Offline

 
  •  » Beta testing
  •  » [2.7] Custom Themes / Admin section changes

Board footer

Powered by FluxBB

github twitter facebook google+ newsletter Donate Piwigo.org © 2002-2019 · Contact