Hi flop25,
It seems that Bootstrap tour is broken with Internet Explorer: on a visit, we always go to admin start page and we have a JS error on all pages (impossible to use the upload form for example). This is a big problem for all Internet Explorer users (not only the old versions, even IE11 is impacted)
The problem seems to be on http://piwigo.org/dev/browser/trunk/plu … e.js#L1005 with the toString.call, which has a problem with IE, see [Github] bootstrap-tour issue #214
And I also see that you have patched Bootstrap tour, with http://piwigo.org/dev/browser/trunk/plu … stom.patch which removes the "{}." before toString.call. And this is precisely what is suggest to be the problem on [Github] bootstrap-tour commit 73532cfb
Why did you apply this patch?
Was the 0.9.3 code breaking something?
Should we upgrade to version 0.10.1?
Piwigo version: 2.7
Offline
Hi
good thing I let that patch, so I can remember that the goal was to add currentPath.replace("http://", "").replace("https://", " and not removing the {} ; that's a side effect
we can upgrade as long as we can apply the changes in the patch
Offline
I have a long todo list but that "kicked my ass" (^^) so i'm gonna fix it today and/or tomorrow
Offline
I'm working on it. It's OK with version 0.10.1 + a part of your patch. I'm commiting it.
Offline
I commited the minimum on 2.7 [Subversion] r30942 and an update to 0.10.1 + your patch on trunk [Subversion] r30941
Offline
flop25, please review my commits and tell me if I made it the good way.
I have already patched Piwigo.com, but I think we should release a Piwigo 2.7.4 (+ some security bug fixes that were privately reported)
Offline
great! :)
thx
Offline