Announcement

  •  » Beta testing
  •  » [Take a Tour] blocking bug with Internet Explorer

#1 2015-02-10 13:33:47

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13159

[Take a Tour] blocking bug with Internet Explorer

Hi flop25,

It seems that Bootstrap tour is broken with Internet Explorer: on a visit, we always go to admin start page and we have a JS error on all pages (impossible to use the upload form for example). This is a big problem for all Internet Explorer users (not only the old versions, even IE11 is impacted)

The problem seems to be on http://piwigo.org/dev/browser/trunk/plu … e.js#L1005 with the toString.call, which has a problem with IE, see [Github] bootstrap-tour issue #214

And I also see that you have patched Bootstrap tour, with http://piwigo.org/dev/browser/trunk/plu … stom.patch which removes the "{}." before toString.call. And this is precisely what is suggest to be the problem on [Github] bootstrap-tour commit 73532cfb

Why did you apply this patch?
Was the 0.9.3 code breaking something?
Should we upgrade to version 0.10.1?

Piwigo version: 2.7


Latest blog post (May 3rd 2018) New subscription form

Offline

 

#2 2015-02-10 14:09:44

flop25
Piwigo Team
2006-07-06
6811

Re: [Take a Tour] blocking bug with Internet Explorer

Hi
good thing I let that patch, so I can remember that the goal was to add currentPath.replace("http://", "").replace("https://", " and not removing the {} ; that's a side effect

we can upgrade as long as we can apply the changes in the patch


To get a better help : Politeness like Hello-A link-Your past actions precisely described
Check my extensions : more than 30 available
who I am and what I do : http://fr.gravatar.com/flop25
My gallery : an illustration of how to integrate Piwigo in your website

Offline

 

#3 2015-02-10 14:11:23

flop25
Piwigo Team
2006-07-06
6811

Re: [Take a Tour] blocking bug with Internet Explorer

I have a long todo list but that "kicked my ass" (^^) so i'm gonna fix it today and/or tomorrow


To get a better help : Politeness like Hello-A link-Your past actions precisely described
Check my extensions : more than 30 available
who I am and what I do : http://fr.gravatar.com/flop25
My gallery : an illustration of how to integrate Piwigo in your website

Offline

 

#4 2015-02-10 14:38:54

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13159

Re: [Take a Tour] blocking bug with Internet Explorer

I'm working on it. It's OK with version 0.10.1 + a part of your patch. I'm commiting it.


Latest blog post (May 3rd 2018) New subscription form

Offline

 

#5 2015-02-10 14:59:07

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13159

Re: [Take a Tour] blocking bug with Internet Explorer

I commited the minimum on 2.7 [Subversion] r30942 and an update to 0.10.1 + your patch on trunk [Subversion] r30941


Latest blog post (May 3rd 2018) New subscription form

Offline

 

#6 2015-02-10 15:04:24

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13159

Re: [Take a Tour] blocking bug with Internet Explorer

flop25, please review my commits and tell me if I made it the good way.

I have already patched Piwigo.com, but I think we should release a Piwigo 2.7.4 (+ some security bug fixes that were privately reported)


Latest blog post (May 3rd 2018) New subscription form

Offline

 

#7 2015-02-10 15:35:50

flop25
Piwigo Team
2006-07-06
6811

Re: [Take a Tour] blocking bug with Internet Explorer

great! :)
thx


To get a better help : Politeness like Hello-A link-Your past actions precisely described
Check my extensions : more than 30 available
who I am and what I do : http://fr.gravatar.com/flop25
My gallery : an illustration of how to integrate Piwigo in your website

Offline

 
  •  » Beta testing
  •  » [Take a Tour] blocking bug with Internet Explorer

Board footer

Powered by FluxBB

github twitter facebook google+ newsletter Donate Piwigo.org © 2002-2018 · Contact