Announcement

  •  » Engine
  •  » Reply To, Comments on Album and Stripped

#1 2015-10-19 11:03:15

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13791

Reply To, Comments on Album and Stripped

Hi,

When Comments on Album is active + Reply To on Stripped Theme, when you have at least on comment on your album, then line http://piwigo.org/dev/browser/extension … st.tpl#L80

Code:

jQuery("document").ready(function(jQuery) {
  var rT=jQuery(".replyTo");
  if (rT.length !=0) {
    var trT=rT.attr("title");
    var pe=trT.search(" ");
    if (pe>0) trT=trT.substring(0,pe);
    rT.text("["+trT+"]");
  }
});

We have a rT :

Code:

<a href="#commentform" class="replyTo" onclick="replyTo('16', 'Monique');">Reply</a>

... but with no "title" attribute, and then the .search is broken. The javascript error blocks RV ThumbnScroller (which is my original problem actually, but RV ThumbnScroller has no issue)

Here come my questions: do you think this code is useful in Stripped? Let's remove it?

Offline

 

#2 2015-10-19 11:12:56

flop25
Piwigo Team
2006-07-06
7037

Re: Reply To, Comments on Album and Stripped

hi
Does the plugin Reply To work on Stripped if you remove that js from Stripped and with Comments on Album? to know if we still can have the feature


To get a better help : Politeness like Hello-A link-Your past actions precisely described
Check my extensions : more than 30 available
who I am and what I do : http://fr.gravatar.com/flop25
My gallery : an illustration of how to integrate Piwigo in your website

Offline

 

#3 2015-10-19 20:03:24

mistic100
Former Piwigo Team
Lyon (FR)
2008-09-27
3277

Re: Reply To, Comments on Album and Stripped

what's the prupose of this snippet on the first place ?

Reply To plugin never adds titles to it's links

Offline

 

#4 2015-10-19 21:15:13

flop25
Piwigo Team
2006-07-06
7037

Re: Reply To, Comments on Album and Stripped

mistic100 wrote:

what's the prupose of this snippet on the first place ?

don't know as much as you


To get a better help : Politeness like Hello-A link-Your past actions precisely described
Check my extensions : more than 30 available
who I am and what I do : http://fr.gravatar.com/flop25
My gallery : an illustration of how to integrate Piwigo in your website

Offline

 

#5 2015-10-20 14:50:07

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13791

Re: Reply To, Comments on Album and Stripped

I just removed this piece of code and everything seems to work fine (no more JS error, still able to click on "reply" button).

Offline

 

#6 2015-10-20 14:55:53

flop25
Piwigo Team
2006-07-06
7037

Re: Reply To, Comments on Album and Stripped

Does Reply To plugin works on stripped?


To get a better help : Politeness like Hello-A link-Your past actions precisely described
Check my extensions : more than 30 available
who I am and what I do : http://fr.gravatar.com/flop25
My gallery : an illustration of how to integrate Piwigo in your website

Offline

 

#7 2015-10-20 15:02:35

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13791

Re: Reply To, Comments on Album and Stripped

Offline

 

#8 2015-10-20 15:04:09

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13791

Re: Reply To, Comments on Album and Stripped

flop25 wrote:

Does Reply To plugin works on stripped?

yes

Offline

 

#9 2015-10-20 15:04:34

flop25
Piwigo Team
2006-07-06
7037

Re: Reply To, Comments on Album and Stripped

so everything is ok


To get a better help : Politeness like Hello-A link-Your past actions precisely described
Check my extensions : more than 30 available
who I am and what I do : http://fr.gravatar.com/flop25
My gallery : an illustration of how to integrate Piwigo in your website

Offline

 
  •  » Engine
  •  » Reply To, Comments on Album and Stripped

Board footer

Powered by FluxBB

github twitter newsletter Donate Piwigo.org © 2002-2024 · Contact