Hi Patrick.

My plugin adds a tab to the admin area of a physical photo or album. When I use $_GET['tab'] (in admin.php) on an album, I get '35' but I also have an image with an id that returns '35' to $_GET['tab'] to the plugin. I need to be able to figure out if my plugin tab is being accessed from a photo or album and I can't rely on just the id.

Appreciate it! :)

https://github.com/jradwan/Piwigo-physi … /admin.php

I wrote what I thought would be a good function to determine the item type based on id. In admin.php:

// retrieve the item id and type
$item_id = ($_GET['image_id']);
$item_type = ppm_check_item_type($item_id);

ppm_check_item_type is in include/functions.inc.php:

/ determine if an item is a photo or album
function ppm_check_item_type($item_id)
{
  $item_type = 'none';
  $item_info = get_image_infos($item_id);
  if (!is_null($item_info))
  {
    // this is a photo
    $item_type = 'photo';
  }
  else
  {
    // this is a physical album
    $item_type = 'album';
  }
  return $item_type;
}

My mistake there is assuming that if get_image_infos returns no information, the item is an album. But if an album and a photo have the same id, that code mistakenly identifies the item as a photo and then my later code fails because it expects to be working on an album and not a photo. Hope I'm explaining that enough ...

Last edited by windracer (2018-01-24 18:16:26)

I think plg wanted the actual code to know what you want to do then

i don't see on which page you have an url with a $_GET['tab'] existing and being potentially an image or an album...

windracer wrote:

I linked to my Github repo above where the full code is.

oops sorry

so you're adding a link depending to the source  https://github.com/jradwan/Piwigo-physi … nc.php#L37 so why you're not adding a second parameter in order to add the photo/album info?

1- don't use a GET/POST or anything that the suer can manipulate, directly in an url, for safety reasons ( check XSS)
Use our function check_input_parameter()  [Github] Piwigo file admin/photo.php@L35
2-  why not just : 'url' => get_root_url().'admin.php?page=plugin-physical_photo_move-'.$image_id_checked'.'&ppm_type=image'  There you're sending a second $_GET, the $_GET['ppm_type']

That worked, flop25, thanks for the suggestion.

In main.inc.php I set

'url' => get_root_url().'admin.php?page=plugin-physical_photo_move-'.$_GET['image_id'].'&ppm_type='.$id,

Where $id will be 'photo' or 'album'. Then in admin.php I added the parameter check:

check_input_parameter('ppm_type', $_GET, false, '/^(photo|album)$/');

And used the new parameter in my if statements directly, eliminating the need for my separate ppm_check_item_type function:

if ($_GET['ppm_type'] == 'photo')
{
...
}
elseif ($_GET['ppm_type'] == 'album')
{
...
}

Seems to work! Still need to do some testing, but I think that'll do it. Thanks again.

Thanks for the kind words and your continued assistance!

I've released v2.00 of the plugin now.