Announcement

  •  » Extensions
  •  » [MugShot] feedback on configuration page

#1 2018-02-22 15:30:41

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13171

[MugShot] feedback on configuration page

Hi cccraig,

I have tested [extension by cccraig] Mug Shot. It works fine in the gallery but I think the configuration page should be improved to be "usable".

1) the list of groups should not be a "comma,separated,list,of,group,names". It is not user friendly. Use a select box with auto-complete instead. Take a look at how [extension by plg] Private Share does it.

2) by default " Crop faces for auto tagging* " is set to "No", but for now you do not seem to provide the ability to "auto crop". I would completely drop this option as long as there is no implementation (and remove the long sentence which is confusing for users).

3) add a tab on the config page, see how [extension by plg] Contribute to Demo does it

4) when you submit the config form, you should display a success message and use the appropriate new values in the form


Latest blog post (May 3rd 2018) New subscription form

Offline

 

#2 2018-02-22 22:54:57

cccraig
Member
2017-09-17
3

Re: [MugShot] feedback on configuration page

Thanks for the feedback, I'll see about incorporating these suggestions soon.

Offline

 

#3 2018-03-10 22:33:55

cccraig
Member
2017-09-17
3

Re: [MugShot] feedback on configuration page

New version with all suggestions incorporated has been posted! :-). Some of my other plugins could benefit from these suggestions as well, I hope to update them soon.

Offline

 

#4 2018-03-12 05:00:38

Jessy
Member
2018-03-07
13

Re: [MugShot] feedback on configuration page

Firstly thanks to you for this revision. but we 're using a custum database prefix which seems not supported, isn't ?

Plugin activation:

Code:

Warning:  [mysql error 1146] Table 'mydb.piwigo_tags' doesn't exist
CREATE TRIGGER `sync_mug_shot`
      AFTER DELETE ON `piwigo_tags`
      FOR EACH ROW DELETE FROM face_tag_positions
      WHERE face_tag_positions.tag_id = old.id in /home/test/public_html/piwigo2/include/dblayer/functions_mysqli.inc.php on line 845

Code:

Warning: Cannot modify header information - headers already sent by (output started at /home/test/public_html/piwigo2/include/dblayer/functions_mysqli.inc.php:844) in /home/test/public_html/piwigo2/include/page_header.php on line 101

Offline

 

#5 2018-03-12 19:44:41

cccraig
Member
2017-09-17
3

Re: [MugShot] feedback on configuration page

Thanks for the notice, I've uploaded a new version (1.2.1) that should fix this issue. I'm using a custom prefix as well but apparently it was failing silently on my machine.

Offline

 

#6 2018-03-13 19:26:05

Jessy
Member
2018-03-07
13

Re: [MugShot] feedback on configuration page

Really quick ;) Many thanks to you. It's seems right (activation step) for now... even if this warning is displayed (settings page)

Code:

Notice: Use of undefined constant PSHARE_ADMIN_BASE_URL - assumed 'PSHARE_ADMIN_BASE_URL' in /home/test/public_html/piwigo2/plugins/MugShot/admin.php on line 61

Code:

Warning: Cannot modify header information - headers already sent by (output started at /home/test/public_html/pwg/plugins/MugShot/admin.php:61) in /home/test/public_html/piwigo2/include/page_header.php on line 101

Link to admin.php?page=plugin&section=MugShot/admin.php

Offline

 

#7 2018-03-13 23:59:49

Jessy
Member
2018-03-07
13

Re: [MugShot] feedback on configuration page

I 'll try on a fresh install later ;) but new database's table seems not created on plugin activation (1.2.1) at this time

This "face_tag_positions" table is added by 1.2 without prefix (not 1.2.1)

Last edited by Jessy (2018-03-18 01:35:48)

Offline

 

#8 2018-03-18 01:33:42

Jessy
Member
2018-03-07
13

Re: [MugShot] feedback on configuration page

Jessy wrote:

I 'll try on a fresh install later ;) but new database's table seems not created on plugin activation (1.2.1) at this time

In fact... only if there is no tag

Offline

 

#9 2018-03-31 17:31:19

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13171

Re: [MugShot] feedback on configuration page

I don't like the trigger in MySQL. I highly suspect it won't work depending on your MySQL flavour (MySQL/MariaDB) and version. I recommend using Piwigo triggers instead. Unfortunately, we have no trigger for tag deletion :-/ We have some for {user,photo,album,comment} but not for tags. I have opened a request [Github] Piwigo issue #854 (and also [Github] Piwigo issue #855 for groups, by the way)

Once we will have this trigger, I advise you convert your MySQL trigger to a Piwigo trigger :-)


Latest blog post (May 3rd 2018) New subscription form

Offline

 

#10 2018-03-31 17:37:09

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13171

Re: [MugShot] feedback on configuration page

I am testing version 1.2.1, and I encounter 2 major issues:

1)  Warning: array_intersect(): Argument #1 is not an array in plugins/MugShot/main.inc.php on line 45
2)  Notice: Use of undefined constant PSHARE_ADMIN_BASE_URL - assumed 'PSHARE_ADMIN_BASE_URL' in plugins/MugShot/admin.php on line 61


Latest blog post (May 3rd 2018) New subscription form

Offline

 

#11 2018-08-27 18:05:24

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13171

Re: [MugShot] feedback on configuration page

up :-)


Latest blog post (May 3rd 2018) New subscription form

Offline

 
  •  » Extensions
  •  » [MugShot] feedback on configuration page

Board footer

Powered by FluxBB

github twitter facebook google+ newsletter Donate Piwigo.org © 2002-2018 · Contact