Ok, got that working. Looks like I need to do the l10n messages as well so once I finish that I'll upload a new release.
Offline
windracer wrote:
Ok, got that working. Looks like I need to do the l10n messages as well so once I finish that I'll upload a new release.
After, you must autorise Piwigo-TranslationTeam in github ;-)
Offline
After, you must autorise Piwigo-TranslationTeam in github ;-)
So many steps! ;) Ok, I'll do that too.
What's the best practice for translating l10n strings? I have a a few that append in variables so it looks like I'll have to build the string first. In other words this:
$debug_line_1 = l10n('DBG_SRC_ALBUM').$source_cat_name.' (id: '.$storage_cat_id.')'; array_push( $page['messages'], l10n($debug_line_1) );
instead of this:
array_push( $page['messages'], l10n('source album: '.$source_cat_name.' (id: '.$storage_cat_id.')') );
Rather than calling l10n the second time (in array_push) should I just use sprintf (since there's no need to re-translate since that was done beforehand)?
Last edited by windracer (2017-06-11 01:15:28)
Offline
eliz82 wrote:
great plugin, if you make it work with batch manager i will use it
I've added Batch Manager support in v1.0.
Offline
Hi, getting an error when activating the Physical Photo Move plugin
Parse error: syntax error, unexpected '[' in /home/***/public_html/***.com/piwigo/plugins/physical_photo_move/include/functions.inc.php on line 102
Any ideas?
Offline
vynz wrote:
Hi, getting an error when activating the Physical Photo Move plugin
Parse error: syntax error, unexpected '[' in /home/***/public_html/***.com/piwigo/plugins/physical_photo_move/include/functions.inc.php on line 102
What version of PHP are you using? I had a user report a similar issue with 5.3.x and upgrading to 5.6.x resolved the issue:
[Github] Piwigo-physical_photo_move issue #6
I use 7.x myself.
Offline
windracer wrote:
What version of PHP are you using? I had a user report a similar issue with 5.3.x and upgrading to 5.6.x resolved the issue:
[Github] Piwigo-physical_photo_move issue #6
I use 7.x myself.
Using PHP 5.6.30
Offline
vynz wrote:
windracer wrote:
What version of PHP are you using? I had a user report a similar issue with 5.3.x and upgrading to 5.6.x resolved the issue:
[Github] Piwigo-physical_photo_move issue #6
I use 7.x myself.Using PHP 5.6.30
Wait. It may be 5.3
Not sure if I am reading the right version being used.
Offline
it's in admin.php?page=maintenance
Offline
vynz wrote:
vynz wrote:
windracer wrote:
What version of PHP are you using? I had a user report a similar issue with 5.3.x and upgrading to 5.6.x resolved the issue:
[Github] Piwigo-physical_photo_move issue #6
I use 7.x myself.Using PHP 5.6.30
Wait. It may be 5.3
Not sure if I am reading the right version being used.
Hey. It activates after switching to PHP v5.60
Thanks. Going to try it out.
Offline
vynz wrote:
Hey. It activates after switching to PHP v5.60 Thanks. Going to try it out.
No problem! Guess I need to add that to the release notes. :)
Offline