Announcement

  •  » Extensions
  •  » [Plugin] Physical Browser Uploader

#16 2018-02-19 20:21:34

eliz82
Member
Romania
2016-04-27
237

Re: [Plugin] Physical Browser Uploader

Here we go again :) ... 2.9.f it's working fine for me

Deleted the plugin, installed again from my Piwigo admin options. Uploaded like 10 files with Chrome and IE11. Both working fine, all the images I uploaded are physically on the server.

me: unix, nginx, php 5.6

Offline

 

#17 2018-02-19 20:47:19

eliz82
Member
Romania
2016-04-27
237

Re: [Plugin] Physical Browser Uploader

windracer wrote:

2.9.f is now broken. The image previews and info work in Chrome, but upload does not: "Upload form is incomplete, please select an album and an image file"

I've tried selecting the album first, then images, and vice versa, same error. Also tried IE, same problem.

By the way, you can try to uncomment lines 61-62 from admin.php , you should see the $POST and $FILES array. Maybe you can see something useful.

Offline

 

#18 2018-02-19 22:11:36

windracer
Member
St. Pete, FL
2014-12-28
214

Re: [Plugin] Physical Browser Uploader

Ok, I think it's related to post_max_size. I did some more testing and with files under 2mb, they uploaded fine. If I tred a 2.1mb file, I get the "Error on file "test.JPG" : The uploaded file exceeds the upload_max_filesize directive in php.ini: 2MB" message as expected.

If I try a bunch of files that go over the 8M post_max_size, THAT'S when I get the "Upload form is incomplete, please select an album and an image file" message (the arrays are empty):

Code:

FILES Array
(
)

POST Array
(
)

So nothing is posted and your plugin thinks the upload form is incomplete, which technically I guess it is since PHP won't do the POST since it's greater than the post_max_size.

Ubuntu 17.10, PHP 7.1.11

Offline

 

#19 2018-02-19 23:46:16

eliz82
Member
Romania
2016-04-27
237

Re: [Plugin] Physical Browser Uploader

I observed when I created the plugin that PHP is incomplete when throwing errors
http://php.net/manual/en/features.file- … errors.php
Only check for 1 of the possible INI errors using a weird method, you must send "upload_max_filesize" as a hidden input and that is automatically checked.

For "post_max_size" and "max_file_uploads" you must implement similar hidden input methods and check for error yourself as PHP default error codes do not contain that.
For "max_file_uploads" I implemented both JS and PHP error checking. For "post_max_size" I was to lazy.

But if I use form elements "required" attribute on client side it's probably safe to replace that "empty POST/FILES error" that you had with a "post_max_size" error. Only a non-browser (ex. CURL) will be able to bypass "required", to make an empty POST/FILES request.

Last edited by eliz82 (2018-02-19 23:46:34)

Offline

 

#20 2018-06-01 19:50:23

georg441
Member
2018-06-01
2

Re: [Plugin] Physical Browser Uploader

Looks like this plugin is exactly what I need but the download link in your first post doesn't seem to work for me. The plugin doesn't show up in my admin panel either.

How do I get this?

Offline

 

#21 2018-06-01 23:06:15

windracer
Member
St. Pete, FL
2014-12-28
214

Re: [Plugin] Physical Browser Uploader

It looks like the extension has been removed from the repository. At least, I can't find it anymore either.

Offline

 
  •  » Extensions
  •  » [Plugin] Physical Browser Uploader

Board footer

Powered by FluxBB

github twitter facebook google+ newsletter Donate Piwigo.org © 2002-2018 · Contact